Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: dakingun@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-1.src.rpm Description: SciGraphica is a free (GPL) scientific application for data analysis and technical graphics. It pretends to be a clone of the popular commercial (and expensive) application "Microcal Origin". It fully supplies plotting features for 2D, 3D and polar charts.
Please note that this will not build in mock at the moment, as it depends on libscigraphica, which I've just submitted for reviews.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
paul@all-the-johnsons.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |paul@all-the-johnsons.co.uk BugsThisDependsOn| |220967 OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-12-29 13:52 EST ------- I've got libscigraphica so I shall do this as well :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-12-31 08:38 EST ------- rpmlint is giving 2 warnings for the main package - looks like you need a devel subpackage adding
W: scigraphica devel-file-in-non-devel-package /usr/share/pixmaps/scigraphica/stock_pixmaps.h W: scigraphica devel-file-in-non-devel-package /usr/share/pixmaps/scigraphica/pixmaps.h
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-12-31 09:22 EST ------- Builds cleanly in mock
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From dakingun@gmail.com 2006-12-31 18:28 EST ------- (In reply to comment #2)
rpmlint is giving 2 warnings for the main package - looks like you need a devel subpackage adding
W: scigraphica devel-file-in-non-devel-package /usr/share/pixmaps/scigraphica/stock_pixmaps.h W: scigraphica devel-file-in-non-devel-package /usr/share/pixmaps/scigraphica/pixmaps.h
The rpmlint warnings can be ignored as those *.h are just listings of the contained pixmaps, I don't think they are being used to build anything. I've corrected the package not to own %{_libdir}/%{name} (already owned by libscigraphical) but it sub-directory that it creates.
Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From paul@all-the-johnsons.co.uk 2007-01-01 08:17 EST ------- NO.
scigraphica should own the libdir and libscigraphica should add to it - NOT the other way around!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-01 10:25 EST ------- Please correct libscigraphica first.
Apparently --------------------------------------- BuildRequires: gtk2-devel gtk+extra-devel BuildRequires: pkgconfig --------------------------------------- This should be required by libscigraphica-devel, not by BuildRequires of this package.
---------------------------------------- %post -p /sbin/ldconfig %postun -p /sbin/ldconfig ---------------------------------------- This is not necessary because no libraries installed by this package are installed under default path on which ldconfig tries to search.
(In reply to comment #5)
NO. scigraphica should own the libdir and libscigraphica should add to it - NOT the other way around!
See my comments on bug 220967.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From dakingun@gmail.com 2007-01-01 13:22 EST -------
With fixes, Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-3.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From dakingun@gmail.com 2007-01-01 21:44 EST ------- I discovered building this package (as is in last spec) fails when python-numarry is installed. This is because the configure script is kinda confused by python-numarry and python-numeric both providing 'arrayobject.h'. This is resolved in this build.
Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-4.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-03 06:31 EST ------- Seemingly okay (quickly checked), I leave this package as judgment by Paul.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-03 06:40 EST ------- ONE NOTE:
On current FC-devel, scigraphica (actually libscigraphica) causes segv on exit. However, I suspect that this is due to ORBit2 or gtk2 or something else (strongly suspect ORBit2).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From paul@all-the-johnsons.co.uk 2007-01-21 05:58 EST ------- Fails to build in mock. You need to add BR gtk2-devel to the spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-21 08:21 EST ------- (In reply to comment #11)
Fails to build in mock. You need to add BR gtk2-devel to the spec
Really? Rebuilding scigraphica requires libscigraphica-devel (bug 220967), libscigraphica-devel requires gtk+extras-devel, and gtk+extra-devel requires gtk2-devel...
For me mockbuild succeeds (with libscigraphica(-devel) correctly installed for scigraphica mockbuild).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-21 08:24 EST ------- Created an attachment (id=146085) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=146085&action=vie...) Mock build log of scigraphica-2.1.0-4.fc7
Mockbuild log of scigraphica-2.1.0-4 on FC7 i386 (for me).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From paul@all-the-johnsons.co.uk 2007-01-21 08:27 EST ------- Buildsys here was updated at 7am (GMT) today which would have sucked in any libscigraphica updates. Mock fails to build here full stop.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-21 09:19 EST ------- Then, still fails on mockbuild? If so, would you attach a mockbuild log with --debug option?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
------- Additional Comments From dakingun@gmail.com 2007-01-21 23:40 EST ------- (In reply to comment #14)
Buildsys here was updated at 7am (GMT) today which would have sucked in any libscigraphica updates. Mock fails to build here full stop.
It seems to me (from the tone of the message) that you think libscigraphica is in Extras tree already; but the review (bug #220967) is still waiting on you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
paul@all-the-johnsons.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From paul@all-the-johnsons.co.uk 2007-01-28 08:07 EST ------- Okay, it's happy again!
rpmlint is not quiet - it's complaining about the two .h files in pixmaps. I've looked at them and will allow it on this occassion. I'm not happy though.
mock is happy (x86)
Review
Good
Consistent use of macros No permission or ownership issues No static libs docs included devel not built, no pkgconfig required rpm not missing any required software actually works Includes desktop icon
Unhappy but will allow .h files in non-devel package
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
Bug 220968 depends on bug 220967, which changed state.
Bug 220967 Summary: Review Request: libscigraphica - A library of gtk+ widgets for SciGraphica https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220967
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220968
dakingun@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From dakingun@gmail.com 2007-02-02 11:58 EST ------- Imported and built too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scigraphica - Scientific application for data analysis and technical graphics
https://bugzilla.redhat.com/show_bug.cgi?id=220968
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org