[Bug 1114413] New: Review Request: python-flask-cors - Flask extension to support cross origin resource sharing
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
Bug ID: 1114413 Summary: Review Request: python-flask-cors - Flask extension to support cross origin resource sharing Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: lsm5@switzerlandmail.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://lsm5.fedorapeople.org/python-flask-cors/python-flask-cors.spec SRPM URL: http://lsm5.fedorapeople.org/python-flask-cors/SRPMS/python-flask-cors-1.3.1...
Description: Flask-CORS is a simple extension to Flask allowing you to support cross origin resource sharing (CORS) using a simple decorator.
Fedora Account System Username: lsm5
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7089416
$ rpmlint python-flask-cors.spec SRPMS/python-flask-cors-1.3.1-1.fc21.src.rpm RPMS/noarch/python3-flask-cors-1.3.1-1.fc21.noarch.rpm RPMS/noarch/python-flask-cors-1.3.1-1.fc21.noarch.rpm python3-flask-cors.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-flask-cors/LICENSE python-flask-cors.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-flask-cors/LICENSE 3 packages and 1 specfiles checked; 0 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
Lokesh Mandvekar lsm5@switzerlandmail.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mgoldman@redhat.com
--- Comment #1 from Lokesh Mandvekar lsm5@switzerlandmail.ch --- Hi Marek, since you patched docker-registry to not use this, this package might be low priority, but just throwing it out there.
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
Lokesh Mandvekar lsm5@switzerlandmail.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|medium |low Severity|medium |low
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
Lokesh Mandvekar lsm5@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|low |medium Flags| |fedora-review? Severity|low |medium
--- Comment #2 from Lokesh Mandvekar lsm5@fedoraproject.org --- Marek, looks like the docker-registry 0.7.3 doesn't work without flask-cors, so we probably need this to go in as well.
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
Lokesh Mandvekar lsm5@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mgoldman@redhat.com Assignee|mgoldman@redhat.com |tom.prince@ualberta.net
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
Tom Prince tom.prince@ualberta.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|tom.prince@ualberta.net |lsm5@fedoraproject.org
--- Comment #3 from Tom Prince tom.prince@ualberta.net ---
This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues ====== [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/vagrant/1114413-python-flask-cors/licensecheck.txt
Licsence appears to be MIT not BSD.
[!]: Requires correct, justified where necessary.
- Missing direct depedency on six. - Not clear what all the buildrequires are for. -
[!]: Latest version is packaged.
- The lastest version appears to be 1.9.0.
[!]: %check is present and all tests pass.
- Although %check is present, upstream doesn't include test in source package. It appears that this is fixed in the most recent release.
[!]: This following line appears useless.
find %{py3dir} -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|'
[!]: PKG-INFO is already installed (in .egg-info). It shouldn't also be installed in /usr/share/doc
[!]: It apperas conventional to include __pycache__.
[!]: There should be an issue upstream for not installing _version.py.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -flask-cors [?]: Package functions as described. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [?]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-flask-cors-1.3.1-1.fc20.noarch.rpm python3-flask-cors-1.3.1-1.fc20.noarch.rpm python-flask-cors-1.3.1-1.fc20.src.rpm python-flask-cors.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-flask-cors/LICENSE python3-flask-cors.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-flask-cors/LICENSE 3 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint python-flask-cors python3-flask-cors python-flask-cors.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-flask-cors/LICENSE python3-flask-cors.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-flask-cors/LICENSE 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:'
Requires -------- python-flask-cors (rpmlib, GLIBC filtered): python(abi) python-flask
python3-flask-cors (rpmlib, GLIBC filtered): python(abi) python3-flask
Provides -------- python-flask-cors: python-flask-cors
python3-flask-cors: python3-flask-cors
Source checksums ---------------- http://pypi.python.org/packages/source/F/Flask-Cors/Flask-Cors-1.3.1.tar.gz : CHECKSUM(SHA256) this package : 351c1be901e7b16f533ad1c11ba7e86911270620ad7ec5f8c01b622d2b05f91a CHECKSUM(SHA256) upstream package : 351c1be901e7b16f533ad1c11ba7e86911270620ad7ec5f8c01b622d2b05f91a
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1114413 Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
Lokesh Mandvekar lsm5@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
Lokesh Mandvekar lsm5@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|lsm5@fedoraproject.org |tom.prince@ualberta.net
--- Comment #4 from Lokesh Mandvekar lsm5@fedoraproject.org --- Hi Tom,
The bug was assigned to you cause you'd be doing the review. Unless you reassigned it to me cause you didn't wanna continue :)
Let me know :)
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
--- Comment #5 from Lokesh Mandvekar lsm5@fedoraproject.org --- Tom, sorry about the delay.
%changelog * Fri Oct 10 2014 Lokesh Mandvekar lsm5@fedoraproject.org - 1.9.0-1 - update to 1.9.0 - correct license - trim down BR list
Latest koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7823387
Spec URL: https://lsm5.fedorapeople.org/python-flask-cors/python-flask-cors.spec SRPM URL: https://lsm5.fedorapeople.org/python-flask-cors/SRPMS/python-flask-cors-1.9....
I'll check with upstream about _version.py or perhaps we could install in a non-standard location
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
--- Comment #6 from Tom Prince tom.prince@ualberta.net --- I've submitted https://github.com/wcdolphin/flask-cors/pull/93 to address _version.
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
--- Comment #7 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117
https://bugzilla.redhat.com/show_bug.cgi?id=1114413
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Last Closed| |2016-04-02 02:44:18
--- Comment #8 from Lokesh Mandvekar lsm5@redhat.com --- Closing this one as I don't really need it anymore. This used to be a dependency for docker-registry but the latter has been retired.
If anyone is interested in this, please clone this bug and continue with the package review.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla