[Bug 1266804] New: Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support - package-review

List overview All Threads
Download

newer

[Bug 1266804] New: Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

older

[Bug 459751] Review Request:...

[Bug 1160475] New: Review Request:...

Red Hat Bugzilla

27 Sep 2015 27 Sep '15

8:43 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

Bug ID: 1266804 Summary: Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: puntogil@libero.it QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://gil.fedorapeople.org/springframework-integration.spec SRPM URL: https://gil.fedorapeople.org/springframework-integration-3.0.7-1.fc22.src.rp... Description: Extends the Spring programming model to support the well-known Enterprise Integration Patterns. Spring Integration enables lightweight messaging within Spring-based applications and supports integration with external systems via declarative adapters. Those adapters provide a higher-level of abstraction over Spring's support for remoting, messaging, and scheduling. Spring Integration's primary goal is to provide a simple model for building enterprise integration solutions while maintaining the separation of concerns that is essential for producing maintainable, testable code.

Fedora Account System Username: gil

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by thread

Red Hat Bugzilla

27 Sep 27 Sep

8:46 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1266806

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1266806 [Bug 1266806] Review Request: springframework-social-twitter - Spring Social Twitter API binding and connect support

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:47 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183 (FE-JAVASIG)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:49 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |968136

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=968136 [Bug 968136] Review Request: camel - Apache Camel integration framework

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11 Nov 11 Nov

10:05 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

--- Comment #1 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- gil's scratch build of springframework-integration-3.0.7-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11799497

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Nov 15 Nov

3:33 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

PeteV pete0verse@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |pete0verse@gmail.com

--- Comment #2 from PeteV pete0verse@gmail.com --- change : %prep %setup -q -n %{oname}-%{namedversion} -a1

to: %prep %setup -q -n %{name}-%{namedversion} -a1

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:35 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

--- Comment #3 from PeteV pete0verse@gmail.com --- (In reply to PeteV from comment #2)

...

change : %prep %setup -q -n %{oname}-%{namedversion} -a1

never mind I see you have that as a global,excuse

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:49 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

--- Comment #4 from gil cattaneo puntogil@libero.it --- Spec URL: https://gil.fedorapeople.org/springframework-integration.spec SRPM URL: https://gil.fedorapeople.org/springframework-integration-3.0.7-1.fc23.src.rp...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

21 Nov 21 Nov

8:24 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804 Bug 1266804 depends on bug 1266806, which changed state.

Bug 1266806 Summary: Review Request: springframework-social-twitter - Spring Social Twitter API binding and connect support https://bugzilla.redhat.com/show_bug.cgi?id=1266806

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

23 Nov 23 Nov

9:50 a.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

Paulo Andrade paulo.cesar.pereira.de.andrade@gmail.com changed:

--- Comment #5 from Paulo Andrade paulo.cesar.pereira.de.andrade@gmail.com --- I will review this package in exchange for review of https://bugzilla.redhat.com/show_bug.cgi?id=1278081

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:30 a.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

Paulo Andrade paulo.cesar.pereira.de.andrade@gmail.com changed:

--- Comment #6 from Paulo Andrade paulo.cesar.pereira.de.andrade@gmail.com --- Hi Gil. Only cut&paste of fedora-review from points I would like some feedback.

[!]: Latest version is packaged. Upstream says latest stable version is 4.2.2. But I see in spec the comment # Newer release require springframework >= 4.1.7.RELEASE

[!]: %check is present and all tests pass. I will trust you it is working correctly, from the build log: $ grep "^Tests run: .* Time elapsed.*" /home/pcpa/1266804-springframework-integration/results/build.log Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.206 sec - in org.springframework.integration.router.RouterConcurrencyTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.948 sec - in org.springframework.integration.twitter.config.TestSendingMessageHandlerParserTests Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.springframework.integration.twitter.config.TestSearchReceivingMessageSourceParserTests Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.292 sec - in org.springframework.integration.twitter.config.TestReceivingMessageSourceParserTests Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.002 sec - in org.springframework.integration.twitter.ignored.TestSendingDMsUsingNamespace Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.springframework.integration.twitter.ignored.TestReceivingUsingNamespace Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.001 sec - in org.springframework.integration.twitter.ignored.TestSendingUpdatesUsingNamespace

[!]: Packages should try to preserve timestamps of original installed files. It is common practive to keep timestamp when converting from dos to unix line ending. For example: sed -i 's/\r//' src/dist/*.txt Should be something like: for file in src/dist/*.txt; do sed -i.orig 's|\r||g' $file touch -r $file.orig $file rm $file.orig done

It took me two tries to understand I should run: $ tar zxf v3.0.7.RELEASE.gz $ sh spring-integration-get-poms.sh 3.0.7.RELEASE to regenerate the poms tarball First I tried using %version :)

I consider the package approved. I leave it for you to decide about using the commands to preserve timestamp, because it is indeed changing the file, so, I am fine with either. Just that some reviewers prefer it corrected and some do not care :)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:54 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

--- Comment #7 from gil cattaneo puntogil@libero.it --- (In reply to Paulo Andrade from comment #6)

...

Hi Gil.

Hi Paulo,

...

Only cut&paste of fedora-review from points I would like some feedback.

[!]: Latest version is packaged. Upstream says latest stable version is 4.2.2. But I see in spec the comment # Newer release require springframework >= 4.1.7.RELEASE

Compatibility problems ... for now we can use this release

...

[!]: %check is present and all tests pass. I will trust you it is working correctly, from the build log: $ grep "^Tests run: .* Time elapsed.*" /home/pcpa/1266804-springframework-integration/results/build.log Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.206 sec - in org.springframework.integration.router.RouterConcurrencyTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.948 sec - in org.springframework.integration.twitter.config. TestSendingMessageHandlerParserTests Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.springframework.integration.twitter.config. TestSearchReceivingMessageSourceParserTests Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.292 sec - in org.springframework.integration.twitter.config. TestReceivingMessageSourceParserTests Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.002 sec - in org.springframework.integration.twitter.ignored.TestSendingDMsUsingNamespace Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.springframework.integration.twitter.ignored.TestReceivingUsingNamespace Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.001 sec - in org.springframework.integration.twitter.ignored. TestSendingUpdatesUsingNamespace

Seem this tests try to use some unsupported features in our koji build system e.g. (web) connection

...

[!]: Packages should try to preserve timestamps of original installed files. It is common practive to keep timestamp when converting from dos to unix line ending. For example: sed -i 's/\r//' src/dist/*.txt Should be something like: for file in src/dist/*.txt; do sed -i.orig 's|\r||g' $file touch -r $file.orig $file rm $file.orig done

Done

...

It took me two tries to understand I should run: $ tar zxf v3.0.7.RELEASE.gz $ sh spring-integration-get-poms.sh 3.0.7.RELEASE to regenerate the poms tarball First I tried using %version :)

Fix comment about poms archive

...

I consider the package approved. I leave it for you to decide about using the commands to preserve timestamp, because it is indeed changing the file, so, I am fine with either. Just that some reviewers prefer it corrected and some do not care :)

Spec URL: https://gil.fedorapeople.org/springframework-integration.spec SRPM URL: https://gil.fedorapeople.org/springframework-integration-3.0.7-1.fc23.src.rp...

Thanks for your quick review

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:01 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

--- Comment #8 from gil cattaneo puntogil@libero.it --- Request for new package: https://admin.fedoraproject.org/pkgdb/package/requests/1786 https://admin.fedoraproject.org/pkgdb/package/requests/1787

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:14 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

gil cattaneo puntogil@libero.it changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183 (FE-JAVASIG) |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:13 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/springframework-integration

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:13 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- springframework-integration-3.0.7-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-4358760719

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:59 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

24 Nov 24 Nov

8:54 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- springframework-integration-3.0.7-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update springframework-integration' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-4358760719

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2 Dec 2 Dec

3:50 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- springframework-integration-3.0.7-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:50 p.m.

New subject: [Bug 1266804] Review Request: springframework-integration - Extends the Spring Enterprise Integration Patterns Support

https://bugzilla.redhat.com/show_bug.cgi?id=1266804

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3519

Age (days ago)

3584

Last active (days ago)

package-review@lists.fedoraproject.org

19 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla