[Bug 968596] New: Review Request: nodejs-detective - Node.js module to find all calls to require() - package-review

List overview All Threads
Download

newer

[Bug 968596] New: Review Request: nodejs-detective - Node.js module to find all calls to require()

older

[Bug 977121] New: Review Request:...

[Bug 983961] Review Request:...

Red Hat Bugzilla

30 May 2013 30 May '13

12:41 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Bug ID: 968596 Summary: Review Request: nodejs-detective - Node.js module to find all calls to require() Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jamielinux@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org

Spec URL: http://jamielinux.fedorapeople.org/nodeunit/nodejs-detective.spec SRPM URL: http://jamielinux.fedorapeople.org/nodeunit/SRPMS/nodejs-detective-2.1.2-1.f... Fedora Account System Username: jamielinux

Description: Node.js module to find all calls to require(), no matter how crazily nested, using a proper walk of the AST.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qTrtjnwE0D&a=cc_unsubscribe

Show replies by date

Red Hat Bugzilla

30 May 30 May

12:58 a.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Jamie Nguyen jamielinux@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |968601

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RiAGC2TXyS&a=cc_unsubscribe

Red Hat Bugzilla

1 a.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Jamie Nguyen jamielinux@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |968598, 968599

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qg4jLNUrbW&a=cc_unsubscribe

Red Hat Bugzilla

1:05 a.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Jamie Nguyen jamielinux@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=41k8QhOMT0&a=cc_unsubscribe

Red Hat Bugzilla

3 Jun 3 Jun

12:57 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Bug 968596 depends on bug 968599, which changed state.

Bug 968599 Summary: Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis https://bugzilla.redhat.com/show_bug.cgi?id=968599

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eT44mkaBpG&a=cc_unsubscribe

Red Hat Bugzilla

18 Jun 18 Jun

7:46 a.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Bug 968596 depends on bug 968598, which changed state.

Bug 968598 Summary: Review Request: nodejs-escodegen - ECMAScript code generator https://bugzilla.redhat.com/show_bug.cgi?id=968598

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rj1O3TYq5i&a=cc_unsubscribe

Red Hat Bugzilla

17 Jul 17 Jul

5:35 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

T.C. Hollingsworth tchollingsworth@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OmVx0oTwj4&a=cc_unsubscribe

Red Hat Bugzilla

5:47 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

T.C. Hollingsworth tchollingsworth@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #1 from T.C. Hollingsworth tchollingsworth@gmail.com ---

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

Status: APPROVED, with TODOs

==== TODO Post-Review ====

[!]: Please enable the tests; they seem to work now.

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually.

MIT in LICENSE -> OK

[x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). nodejs macros used -> OK [x]: Package is named according to the Package Naming Guidelines. nodejs- prefix used -> OK [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. %{nodejs_arches} used -> OK [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged.

% npm -q view detective version 2.1.2

[x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass.

the tests work now, please enable them

[x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: nodejs-detective-2.1.2-1.fc20.noarch.rpm nodejs-detective-2.1.2-1.fc20.src.rpm nodejs-detective.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-detective.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-detective.noarch: W: only-non-binary-in-usr-lib nodejs-detective.noarch: W: dangling-symlink /usr/lib/node_modules/detective/node_modules/escodegen /usr/lib/node_modules/escodegen nodejs-detective.noarch: W: dangling-symlink /usr/lib/node_modules/detective/node_modules/esprima /usr/lib/node_modules/esprima nodejs-detective.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-detective.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 7 warnings.

Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-detective nodejs-detective.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-detective.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-detective.noarch: W: only-non-binary-in-usr-lib nodejs-detective.noarch: W: dangling-symlink /usr/lib/node_modules/detective/node_modules/escodegen /usr/lib/node_modules/escodegen nodejs-detective.noarch: W: dangling-symlink /usr/lib/node_modules/detective/node_modules/esprima /usr/lib/node_modules/esprima 1 packages and 0 specfiles checked; 0 errors, 5 warnings. # echo 'rpmlint-done:'

Requires -------- nodejs-detective (rpmlib, GLIBC filtered): nodejs(engine) npm(escodegen) npm(esprima)

Provides -------- nodejs-detective: nodejs-detective npm(detective)

Source checksums ---------------- http://registry.npmjs.org/detective/-/detective-2.1.2.tgz : CHECKSUM(SHA256) this package : 5a7d8dbbab2d7708d3d226b3d89612a7e4869f85db5c73606fc30a2c58c23ec8 CHECKSUM(SHA256) upstream package : 5a7d8dbbab2d7708d3d226b3d89612a7e4869f85db5c73606fc30a2c58c23ec8

Generated by fedora-review 0.4.0 (b80cd0f) last change: 2013-07-09 Buildroot used: fedora-rawhide-vanilla-x86_64 Command line :./try-fedora-review -b968596

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TRcwkj1196&a=cc_unsubscribe

Red Hat Bugzilla

6:13 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Jamie Nguyen jamielinux@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #2 from Jamie Nguyen jamielinux@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/nodeunit/nodejs-detective.spec SRPM URL: http://jamielinux.fedorapeople.org/nodeunit/SRPMS/nodejs-detective-2.1.2-2.f...

* Wed Jul 17 2013 Jamie Nguyen jamielinux@fedoraproject.org - 2.1.2-2 - enable tests

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IdP9PzlQXh&a=cc_unsubscribe

Red Hat Bugzilla

6:13 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

--- Comment #3 from Jamie Nguyen jamielinux@fedoraproject.org --- New Package SCM Request ======================= Package Name: nodejs-detective Short Description: Node.js module to find all calls to require() Owners: jamielinux patches Branches: f18 f19 el6 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lkkXSZjdoz&a=cc_unsubscribe

Red Hat Bugzilla

6:37 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t8t3McNgGn&a=cc_unsubscribe

Red Hat Bugzilla

6:37 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J9FZHUv6LQ&a=cc_unsubscribe

Red Hat Bugzilla

9:45 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gL6fiTc1o1&a=cc_unsubscribe

Red Hat Bugzilla

9:45 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

--- Comment #5 from Fedora Update System updates@fedoraproject.org --- nodejs-detective-2.1.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-detective-2.1.2-2.fc19

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fBv3e4ug6E&a=cc_unsubscribe

Red Hat Bugzilla

9:46 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

--- Comment #6 from Fedora Update System updates@fedoraproject.org --- nodejs-detective-2.1.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-detective-2.1.2-2.fc18

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WrjpQ0NVia&a=cc_unsubscribe

Red Hat Bugzilla

9:46 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodejs-detective-2.1.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-detective-2.1.2-2.el6

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M6uUdcRW4J&a=cc_unsubscribe

Red Hat Bugzilla

11:30 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Jamie Nguyen jamielinux@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rPADwCbekX&a=cc_unsubscribe

Red Hat Bugzilla

30 Jul 30 Jul

7:42 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Fedora Update System updates@fedoraproject.org changed:

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nodejs-detective-2.1.2-2.fc19 has been pushed to the Fedora 19 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o64YowE208&a=cc_unsubscribe

Red Hat Bugzilla

7:53 p.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Fedora Update System updates@fedoraproject.org changed:

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nodejs-detective-2.1.2-2.fc18 has been pushed to the Fedora 18 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J9qpDAz6Z3&a=cc_unsubscribe

Red Hat Bugzilla

6 Aug 6 Aug

1:29 a.m.

New subject: [Bug 968596] Review Request: nodejs-detective - Node.js module to find all calls to require()

https://bugzilla.redhat.com/show_bug.cgi?id=968596

Fedora Update System updates@fedoraproject.org changed:

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- nodejs-detective-2.1.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CWtZxU71t2&a=cc_unsubscribe

4370

Age (days ago)

4438

Last active (days ago)

package-review@lists.fedoraproject.org

19 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla