Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: vishnu - DIET add-on packages
https://bugzilla.redhat.com/show_bug.cgi?id=783073
Summary: Review Request: vishnu - DIET add-on packages Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: karlthered@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://hguemar.fedorapeople.org/diet/vishnu.spec SRPM URL: http://hguemar.fedorapeople.org/diet/vishnu-1.2.6-1.fc16.src.rpm Description: vishnu is a diet add-on that brings: * User Management System * Tasks Management System (abstraction layers over batch schedulers) * File Management System * Information Management System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=783073
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |783071
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=783073
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org
--- Comment #1 from Michael Scherer misc@zarb.org 2012-03-24 15:23:42 EDT --- So now that diet is in, this one should be the next.
- the license is not present in all cases. For exemple, if I install vishnu-ums-server, it just pull vshnu-core-server, and there is no license
- the copying file is IMHO not sufficient, maybe you should bundle the rest in License/*
- rm -rf $RPM_BUILD_ROOT is not needed in %install
- I think you should use the %version in %setup and in $SOURCE0
- there is no url for Source0, nor any indication on where to get the source code
- the servers do not need to be started by systemd ?
- like diet, I assume the tests are not practical to run on koji/mock ?
- I am sure that better description could help to understand what each packages do ( even if this is rather specialized )
- there is support for documentation created by doxygen, wouldn't that be useful to enable it ?
https://bugzilla.redhat.com/show_bug.cgi?id=783073
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m
--- Comment #2 from Mario Blättermann mario.blaettermann@gmail.com --- Any progress in this review...?
https://bugzilla.redhat.com/show_bug.cgi?id=783073
--- Comment #3 from Haïkel Guémar karlthered@gmail.com --- i need to update the package to latest version.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=783073
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(karlthered@gmail. | |com)
https://bugzilla.redhat.com/show_bug.cgi?id=783073
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Flags|needinfo?(karlthered@gmail. | |com) | Last Closed| |2014-06-09 07:49:16
--- Comment #4 from Haïkel Guémar karlthered@gmail.com --- Let's drop it, upstream is not interested anymore interacting with the FOSS community.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla