[Bug 1208217] New: Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

Bug ID: 1208217
           Summary: Review Request: swig2 - Connects C/C++/Objective C to
                    some high-level programming languages
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Description:

SWIG is a software development tool that connects programs
  written in C and C++ with a variety of high-level programming
  languages.  SWIG is used with different types of target
  languages including common scripting languages such as
  Javascript, Perl, PHP, Python, Tcl and Ruby.  The list of
  supported languages also includes non-scripting languages
  such as C#, Common Lisp (CLISP, Allegro CL, CFFI, UFFI), D,
  Go language, Java including Android, Lua, Modula-3, OCAML,
  Octave, Scilab and R.  Also several interpreted and compiled
  Scheme implementations (Guile, MzScheme/Racket, Chicken) are
  supported.  SWIG is most commonly used to create high-level
  interpreted or compiled programming environments, user
  interfaces, and as a tool for testing and prototyping C/C++
  software.  SWIG is typically used to parse C/C++ interfaces and
  generate the 'glue code' required for the above target languages
  to call into the C/C++ code.  SWIG can also export its parse
  tree in the form of XML and Lisp s-expressions.  SWIG is free
  software and the code that SWIG generates is compatible with
  both commercial and non-commercial projects.

Issues:

fedora-review shows no obvious issues.  AFAIK there might be some false
  positives from rpmlint.

FAS-User:

besser82

Urls:

Spec URL: http://besser82.fedorapeople.org/review/swig2.spec
  SRPM URL: http://besser82.fedorapeople.org/review/swig2-2.0.12-1.fc23.src.rpm

Additional Information:

The current version of SWIG (3.0.X) in Fedora 21+ generates valid
  but run-time segfaulting code for Python-bindings, when using
  `-builtin -modernargs`-flags during wrapper-generation.  Thus I
  need this compat-pkg for SHOGUN and possibly other packages.

Thanks for review in advance!

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

--- Comment #1 from Björn "besser82" Esser  ---
Koji Builds:

el5:  no build  --->  autotools are too old
  el6:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9393797
  F20:  no build  --->  SWIG (v2.0.11) works fine here
  F21:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9393801
  F22:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9393807
  Frh:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9393812

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

--- Comment #2 from Björn "besser82" Esser  ---
Updated Koji Builds:

el5:  no build  --->  autotools are too old
  el6:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9393903
  F20:  no build  --->  SWIG (v2.0.11) works fine here
  F21:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9393913
  F22:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9393917
  Frh:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9393923

* * *

Additional Information:

The current version of SWIG (3.0.X) in Fedora 21+ generates valid
  but run-time segfaulting code for Python-bindings, when using
  `-builtin -modernargs`-flags during wrapper-generation.  Thus I
  need this compat-pkg for SHOGUN and possibly other packages.

Testsuite works fine on Koji, but fails for whatever reason in local
  mock-builds.  Running fedora-review with flag:
  `-o "--no-cleanup-after --no-clean --without=testsuite"`
  should do the trick.

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

--- Comment #3 from Björn "besser82" Esser  ---
Updated and fixed Koji Builds:

el5:  no build  --->  autotools are too old
  el6:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9394095
  F20:  no build  --->  SWIG (v2.0.11) works fine here
  F21:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9394101
  F22:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9394105
  Frh:  https://koji.fedoraproject.org/koji/taskinfo?taskID=9394114

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

Christian Dersch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #4 from Christian Dersch  ---
Taken :)

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

Christian Dersch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #5 from Christian Dersch  ---
Approved!

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package contains the mandatory BuildRequires and Requires:.
  Note: Explicit dependency on perl-devel is not allowed
  See: http://fedoraproject.org/wiki/Packaging:Perl

===> Is ok in this case, testsuie requirement

- Header files in -devel subpackage, if present.
  Note: swig2-doc : /usr/share/doc/swig2/Examples/android/class/jni/example.h
  swig2-doc : /usr/share/doc/swig2/Examples/android/extend/jni/example.h
  swig2-doc : /usr/share/doc/swig2/Examples/chicken/class/example.h swig2-doc
  : /usr/share/doc/swig2/Examples/chicken/overload/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/contract/simple_cxx/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/csharp/arrays/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/csharp/callback/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/csharp/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/csharp/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/csharp/extend/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/csharp/funcptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/csharp/reference/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/csharp/template/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/csharp/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/d/callback/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/d/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/d/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/d/extend/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/d/funcptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/d/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/go/callback/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/go/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/go/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/go/extend/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/go/funcptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/go/reference/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/go/template/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/go/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/guile/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/guile/matrix/vector.h swig2-doc :
  /usr/share/doc/swig2/Examples/guile/std_vector/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/java/callback/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/java/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/java/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/java/extend/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/java/funcptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/java/reference/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/java/template/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/java/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/lua/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/lua/embed3/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/lua/exception/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/lua/funcptr3/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/lua/import/bar.h swig2-doc :
  /usr/share/doc/swig2/Examples/lua/import/base.h swig2-doc :
  /usr/share/doc/swig2/Examples/lua/import/foo.h swig2-doc :
  /usr/share/doc/swig2/Examples/lua/import/spam.h swig2-doc :
  /usr/share/doc/swig2/Examples/lua/owner/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/lua/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/modula3/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/modula3/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/modula3/exception/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/modula3/reference/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/mzscheme/std_vector/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ocaml/scoped_enum/foo.h swig2-doc :
  /usr/share/doc/swig2/Examples/ocaml/shapes/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ocaml/std_string/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ocaml/std_vector/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ocaml/stl/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ocaml/strings_test/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/callback/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/extend/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/funcptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/funcptr2/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/module_load/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/operator/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/reference/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/template/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/octave/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/perl5/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/perl5/funcptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/perl5/import/bar.h swig2-doc :
  /usr/share/doc/swig2/Examples/perl5/import/base.h swig2-doc :
  /usr/share/doc/swig2/Examples/perl5/import/foo.h swig2-doc :
  /usr/share/doc/swig2/Examples/perl5/import/spam.h swig2-doc :
  /usr/share/doc/swig2/Examples/perl5/multiple_inheritance/example.h swig2-doc
  : /usr/share/doc/swig2/Examples/perl5/reference/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/perl5/value/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/perl5/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/perl5/xmlstring/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/callback/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/disown/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/extend/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/funcptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/overloading/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/proxy/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/reference/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/sync/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/value/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/php/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/pike/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/pike/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/pike/overload/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/pike/template/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/callback/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/docstrings/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/exception/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/exceptproxy/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/extend/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/funcptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/funcptr2/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/import/bar.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/import/base.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/import/foo.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/import/spam.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/import_template/bar.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/import_template/base.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/import_template/foo.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/import_template/spam.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/operator/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/reference/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/smartptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/smartptr/smartptr.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/std_map/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/std_vector/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/swigrun/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/template/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/python/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/r/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/exception_class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/free_function/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/funcptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/funcptr2/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/import/bar.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/import/base.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/import/foo.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/import/spam.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/import_template/bar.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/import_template/base.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/import_template/foo.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/import_template/spam.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/mark_function/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/operator/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/overloading/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/reference/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/std_vector/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/template/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/value/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/ruby/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/class/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/enum/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/funcptr/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/import/bar.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/import/base.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/import/foo.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/import/spam.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/operator/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/reference/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/std_vector/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/value/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/tcl/variables/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/xml/example.h swig2-doc :
  /usr/share/doc/swig2/Examples/xml/example_inl.h swig2-doc :
  /usr/share/doc/swig2/Examples/xml/example_xml.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

===> Examples only => Nothing which should be in -devel => OK

- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find LICENSE in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

===> Package uses %license tag => OK

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later) (with incorrect FSF address)", "GPL (v3 or later)",
     "Unknown or generated". 1603 files have unknown license. Detailed output
     of licensecheck in /home/review/1208217-swig2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib64/ccache(ccache),
     /usr/share/swig(swig)

===> Should be ok

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 962560 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in swig2-devel
     , swig2-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.

===> Works fine in Koji, for unknown reasons not on local machines and in mock.
     Please keep this in mind and maybe report as a bug

[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Package should not use obsolete m4 macros
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: swig2-2.0.12-1.fc23.x86_64.rpm
          swig2-devel-2.0.12-1.fc23.noarch.rpm
          swig2-doc-2.0.12-1.fc23.noarch.rpm
          swig2-2.0.12-1.fc23.src.rpm
swig2.x86_64: W: only-non-binary-in-usr-lib
swig2-doc.noarch: E: wrong-script-interpreter
/usr/share/doc/swig2/Examples/guile/matrix/runme.scm ./matrix
4 packages and 0 specfiles checked; 1 errors, 1 warnings.

===> Not an issue imho

Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:

Requires
--------
swig2-doc (rpmlib, GLIBC filtered):

swig2 (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpcre.so.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)
    swig2-common

swig2-devel (rpmlib, GLIBC filtered):
    swig2

Provides
--------
swig2-doc:
    swig2-doc

swig2:
    swig
    swig2
    swig2(x86-64)

swig2-devel:
    swig2-common
    swig2-devel

Source checksums
----------------
http://downloads.sourceforge.net/project/swig/swig/swig-2.0.12/swig-2.0.12.t...
:
  CHECKSUM(SHA256) this package     :
65e13f22a60cecd7279c59882ff8ebe1ffe34078e85c602821a541817a4317f7
  CHECKSUM(SHA256) upstream package :
65e13f22a60cecd7279c59882ff8ebe1ffe34078e85c602821a541817a4317f7

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -o --no-cleanup-after
--no-clean --without=testsuite -b 1208217
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api, C/C++, Perl
Disabled plugins: Java, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

Björn "besser82" Esser  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-cvs?

--- Comment #6 from Björn "besser82" Esser  ---
Thanks for the review, Christian!  :D

* * *

New Package SCM Request
=======================
Package Name: swig2
Short Description: Connects C/C++/Objective C to some high-level programming
languages
Upstream URL: http://swig.sourceforge.net/
Owners: besser82
Branches: el5 el6 f21 f22
InitialCC: ml-sig

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

Patrick Uiterwijk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

--- Comment #7 from Patrick Uiterwijk  ---
Git done (by process-git-requests).

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

--- Comment #8 from Fedora Update System  ---
swig2-2.0.12-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/swig2-2.0.12-1.el5

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

--- Comment #9 from Fedora Update System  ---
swig2-2.0.12-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/swig2-2.0.12-1.el6

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

--- Comment #10 from Fedora Update System  ---
swig2-2.0.12-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/swig2-2.0.12-1.el7

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

--- Comment #11 from Fedora Update System  ---
swig2-2.0.12-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/swig2-2.0.12-1.fc21

[Bug 1208217] Review Request: swig2 - Connects C/C++/Objective C to some high-level programming languages

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208217

--- Comment #12 from Fedora Update System  ---
swig2-2.0.12-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/swig2-2.0.12-1.fc22