Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226657
Summary: Merge Review: xrestop Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: sandmann@redhat.com
Fedora Merge Review: xrestop
http://cvs.fedora.redhat.com/viewcvs/devel/xrestop/ Initial Owner: sandmann@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: xrestop
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226657
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |kevin@tummy.com Flag| |fedora-review?
------- Additional Comments From kevin@tummy.com 2007-02-04 09:45 EST ------- I would be happy to review this package. Look for a full review in a bit.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: xrestop
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226657
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kevin@tummy.com |sandmann@redhat.com Flag|fedora-review? |fedora-review-
------- Additional Comments From kevin@tummy.com 2007-02-04 10:01 EST -------
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 5ff774ff9cbb5997f0fb68e712dee302 xrestop-0.2.tar.gz 5ff774ff9cbb5997f0fb68e712dee302 xrestop-0.2.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. See below - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane:
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. See below - Should have dist tag See below - Should package latest version 0 outstanding bugs - check for outstanding bugs on package.
Issues:
1. Buildroot should be the standard one.
2. rpmlint says: E: xrestop zero-length /usr/share/doc/xrestop-0.2/NEWS
Drop the NEWS file? Also the INSTALL file is the generic autotools one, and should also be dropped.
3. Should use the dist tag?
4. The latest version is 0.4 upstream. I think you can then also drop the man patch as this is fixed upstream.
5. There's some odd # SUBDIRS= comments that should get removed...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: xrestop
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226657
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO AssignedTo|sandmann@redhat.com |kevin@tummy.com Flag|fedora-review- |needinfo?(sandmann@redhat.co | |m), fedora-review?
------- Additional Comments From kevin@tummy.com 2007-02-23 22:07 EST ------- Resetting flags and such per the new offical review guidelines: https://www.redhat.com/archives/fedora-maintainers/2007-February/msg00682.ht...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: xrestop
https://bugzilla.redhat.com/show_bug.cgi?id=226657
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
------- Additional Comments From kevin@tummy.com 2008-03-21 21:09 EST ------- Any news here?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226657
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Flag|fedora-review?, |fedora-review+ |needinfo?(sandmann@redhat.c | |om) |
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2009-09-26 16:22:09 EDT --- As far as I can tell you've never commited to this package, do you still want to maintain it?
Items 1 and 5 are outstanding still... all the others have been fixed by other people over the years.
The buildroot does meet the guidelines, even though it's not a standard one. The comments are not a blocker.
I guess I will go ahead and APPROVE this review, but it seems odd to have a package maintained by someone who has never once commited to it.
package-review@lists.fedoraproject.org