https://bugzilla.redhat.com/show_bug.cgi?id=1621608
Bug ID: 1621608 Summary: Review Request: iyfct - Side scrolling endless runner game Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: alexjnewt@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://mystro256.fedorapeople.org/iyfct.spec SRPM URL: https://mystro256.fedorapeople.org/iyfct-1.0.2-20160510git.7fe93a4.fc27.src....
Description: The goal of the game is to survive as long as you can. Jump over trains with closed doors and try (as much as possible) to run through trains with open doors to avoid birds and tunnels.
Fedora Account System Username: mystro256
https://bugzilla.redhat.com/show_bug.cgi?id=1621608
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michel@michel-slm.name Flags| |fedora-review?
--- Comment #1 from Michel Alexandre Salim michel@michel-slm.name --- Reviewing this
https://bugzilla.redhat.com/show_bug.cgi?id=1621608
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alexjnewt@gmail.com Flags| |needinfo?(alexjnewt@gmail.c | |om)
--- Comment #2 from Michel Alexandre Salim michel@michel-slm.name --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues ## MUST - License field in the package spec file matches the actual license. please change to "GPLv3 and CC-BY" - Package consistently uses macros. Could you use %{name}.appdata.xml for the appdata file, since you use it for the other files? ## SHOULD - Latest version is packaged. any reason you use a revision from 2016? There are more recent commits (note: this is a non-blocker so if you have a valid reason that's fine) - Patches link to upstream bugs/comments/lists or are otherwise justified. your patch actually adds new files; they are probably fine to maintain separately from upstream but could you add them as individual source files? That will make them easier to maintain. Ideally also submit each of them upstream as pull request(s) and add the link(s) in the spec
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* CC by (v3.0)". 26 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/1621608-iyfct/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: iyfct-1.0.2-20160510git.7fe93a4.fc28.noarch.rpm iyfct-1.0.2-20160510git.7fe93a4.fc28.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory iyfct.noarch: W: invalid-url URL: https://github.com/SimonLarsen/iyfct <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires -------- iyfct (rpmlib, GLIBC filtered): /bin/sh love
Provides -------- iyfct: application() application(iyfct.desktop) iyfct metainfo() metainfo(iyfct.appdata.xml)
Source checksums ---------------- https://github.com/SimonLarsen/iyfct/archive/7fe93a494d4a3addd590585a9241a09... : CHECKSUM(SHA256) this package : d71b0d4915dc9c732931a06295f5ebe963c62bc880ce1ad0d805a927fb5294d3 CHECKSUM(SHA256) upstream package : d71b0d4915dc9c732931a06295f5ebe963c62bc880ce1ad0d805a927fb5294d3
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1621608 Buildroot used: fedora-28-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1621608
Jeremy Newton alexjnewt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(alexjnewt@gmail.c | |om) |
--- Comment #3 from Jeremy Newton alexjnewt@gmail.com --- Thanks for the review!
Some comments: - The latest commit will only work on F29+ due to dependency on love 11.0, so I built this with the latest commit that will work for stable Fedora/EPEL7. Once I'm done importing, I plan to bump it to a newer snapshot for F29/Rawhide. - I maintain packages for other games from this upstream developer; he doesn't have interest in maintaining appdata, so I maintain them. It's fairly trivial with a lot of overlap between them, so I don't mind.
Here's updated files. I didn't bump the release because it's just minor/doc changes: Spec URL: https://mystro256.fedorapeople.org/iyfct.spec SRPM URL: https://mystro256.fedorapeople.org/iyfct-1.0.2-20160510git.7fe93a4.fc27.src....
https://bugzilla.redhat.com/show_bug.cgi?id=1621608
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |michel@michel-slm.name Flags|fedora-review? |fedora-review+
--- Comment #4 from Michel Alexandre Salim michel@michel-slm.name --- Everything looks good (I'm assuming you're maintaining a separate Git tree somewhere which is why the patch makes sense, and that's a non-blocker anyway)
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1621608
--- Comment #5 from Jeremy Newton alexjnewt@gmail.com --- Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1621608
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/iyfct
https://bugzilla.redhat.com/show_bug.cgi?id=1621608
Jeremy Newton alexjnewt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-08-25 15:12:47
--- Comment #7 from Jeremy Newton alexjnewt@gmail.com --- Thanks Gwyn!
I've build it in rawhide and updated to the latest snapshot. Thanks again!
https://koji.fedoraproject.org/koji/buildinfo?buildID=1139363
I'll make a new package a bit later.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com