[Bug 760153] New: Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb - package-review

List overview All Threads
Download

newer

[Bug 760153] New: Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

older

[Bug 798616] New: Review Request:...

[Bug 760155] New: Review Request:...

Red Hat Bugzilla

5 Dec 2011 5 Dec '11

6:42 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

https://bugzilla.redhat.com/show_bug.cgi?id=760153

Summary: Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: thomas.moschny@gmx.de QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---

Spec URL: http://thm.fedorapeople.org/xcb-util-wm/xcb-util-wm.spec SRPM URL: http://thm.fedorapeople.org/xcb-util-wm/xcb-util-wm-0.3.8-1.fc16.src.rpm Description: XCB util-wm module provides the following libraries:

- ewmh: Both client and window-manager helpers for EWMH. - icccm: Both client and window-manager helpers for ICCCM.

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3563676

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

2 Apr 2 Apr

1:02 p.m.

New subject: [Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=760153

Tom "spot" Callaway tcallawa@redhat.com changed:

--- Comment #1 from Tom "spot" Callaway tcallawa@redhat.com 2012-04-02 16:02:23 EDT --- Review =======

There are some minor cleanups you can make like:

* drop rm -rf %{buildroot} from %install * drop default defattr lines * drop BuildRoot line * Use %{name}%{?_isa} instead of just %{name} in explicit Requires: * Fix the devel description (s/xcb-utilwm/xcb-util-wm).

But all of those are minor. Just consider making those changes before committing.

Good:

- rpmlint checks return: xcb-util-wm.src: W: spelling-error Summary(en_US) libxcb -> Libby xcb-util-wm.src: W: spelling-error %description -l en_US ewmh -> whew xcb-util-wm.src: W: spelling-error %description -l en_US icccm -> ICC xcb-util-wm.x86_64: W: spelling-error Summary(en_US) libxcb -> Libby xcb-util-wm.x86_64: W: spelling-error %description -l en_US ewmh -> whew xcb-util-wm.x86_64: W: spelling-error %description -l en_US icccm -> ICC xcb-util-wm-devel.x86_64: W: spelling-error Summary(en_US) vm -> cm, v, m xcb-util-wm-devel.x86_64: W: spelling-error %description -l en_US utilwm -> utility

All safe to ignore.

- package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r

APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3 Apr 3 Apr

12:14 a.m.

New subject: [Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=760153

Thomas Moschny thomas.moschny@gmx.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #2 from Thomas Moschny thomas.moschny@gmx.de 2012-04-03 03:14:04 EDT --- Thanks for the review spot!

New Package SCM Request ======================= Package Name: xcb-util-wm Short Description: Client and window-manager helper library on top of libxcb Owners: thm Branches: f17 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:55 a.m.

New subject: [Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=760153

--- Comment #3 from Jon Ciesla limburgher@gmail.com 2012-04-03 09:55:00 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5 Apr 5 Apr

7:29 a.m.

New subject: [Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=760153

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:29 a.m.

New subject: [Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=760153

--- Comment #4 from Fedora Update System updates@fedoraproject.org 2012-04-05 10:29:47 EDT --- xcb-util-wm-0.3.8-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xcb-util-wm-0.3.8-2.fc17

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6 Apr 6 Apr

4:23 p.m.

New subject: [Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=760153

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #5 from Fedora Update System updates@fedoraproject.org 2012-04-06 19:23:52 EDT --- xcb-util-wm-0.3.8-2.fc17 has been pushed to the Fedora 17 testing repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

13 Apr 13 Apr

9:30 p.m.

New subject: [Bug 760153] Review Request: xcb-util-wm - Client and window-manager helper library on top of libxcb

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=760153

Fedora Update System updates@fedoraproject.org changed:

--- Comment #6 from Fedora Update System updates@fedoraproject.org 2012-04-14 00:30:08 EDT --- xcb-util-wm-0.3.8-2.fc17 has been pushed to the Fedora 17 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4458

Age (days ago)

4589

Last active (days ago)

package-review@lists.fedoraproject.org

7 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla