[Bug 707923] New: Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections

https://bugzilla.redhat.com/show_bug.cgi?id=707923

Summary: Review Request: rubygem-net-ssh-gateway - A simple
                    library to assist in establishing tunneled Net::SSH
                    connections
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

Spec URL: http://people.redhat.com/vondruch/rubygem-net-ssh-gateway.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-net-ssh-gateway-1.1.0-1.fc16.src.r...
Description: A simple library to assist in establishing tunneled Net::SSH
connections

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3093375

[Bug 707923] Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=707923

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]

[Bug 707923] Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=707923

--- Comment #1 from Marcela Mašláňová  2011-06-02 09:57:42 EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license ?
- license field must match actual license ?
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

License: I found LGPL in setup.rb. Why should it be MIT only?

resolvedeps-f16 ~/Downloads/rubygem-net-ssh-gateway-1.1.0-1.fc16.noarch.rpm 
Binary dependencies resolvable. Ok.

[Bug 707923] Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=707923

--- Comment #2 from Vít Ondruch  2011-06-06 09:00:48 EDT ---
(In reply to comment #1)
> License: I found LGPL in setup.rb. Why should it be MIT only?

I have removed setup.rb. It is actually

1) Bundled external dependency.
2) Not required dependency, since setup.rb is useful only if you get the
software as tarball and you want to install it in Ruby.

Spec URL: http://people.redhat.com/vondruch/rubygem-net-ssh-gateway.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-net-ssh-gateway-1.1.0-2.fc16.src.r...

[Bug 707923] Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=707923

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #3 from Marcela Mašláňová  2011-06-06 09:52:06 EDT ---
APPROVED

[Bug 707923] Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=707923

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Vít Ondruch  2011-06-06 11:15:29 EDT ---
Thank you for your review!

New Package SCM Request
=======================
Package Name: rubygem-net-ssh-gateway
Short Description: A simple library to assist in establishing tunneled Net::SSH
connections
Owners: vondruch
Branches: 
InitialCC:

[Bug 707923] Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=707923

--- Comment #5 from Jon Ciesla  2011-06-06 11:47:19 EDT ---
Git done (by process-git-requests).

[Bug 707923] Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=707923

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
        Last Closed|                            |2011-06-07 04:40:05