[Bug 454416] New: Review Request: mingw-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Summary: Review Request: mingw-zlib - MinGW Windows zlib
                    compression library
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://www.annexia.org/tmp/mingw/mingw-zlib.spec
SRPM URL: http://www.annexia.org/tmp/mingw/mingw-zlib-1.2.3-1.fc10.src.rpm
Description: MinGW Windows zlib compression library

Incomplete packaging guidelines:
https://fedoraproject.org/wiki/PackagingDrafts/MinGW

This is zlib cross-compiled for Windows.  We have packaged quite a few
libraries for Fedora so far, but not submitted them yet in case there
are problems with the packaging guidelines.  ZLib was chosen as a typical
library, simple and with no dependencies.

[Bug 454416] Review Request: mingw-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mingw-zlib - MinGW Windows zlib compression library

https://bugzilla.redhat.com/show_bug.cgi?id=454416

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |454408, 454410, 454412,
                   |                            |454414

[Bug 454416] Review Request: mingw-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

John Poelstra  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Customer Facing|                            |---

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: mingw-zlib  |Review Request:
                   |- MinGW Windows zlib        |mingw32-zlib - MinGW
                   |compression library         |Windows zlib compression
                   |                            |library
              Alias|                            |mingw32-zlib

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

--- Comment #1 from Richard W.M. Jones   2008-10-16 16:31:15 EDT ---
Spec URL:
http://hg.et.redhat.com/misc/fedora-mingw--devel/?cmd=manifest;manifest=5a13...
SRPM URL:
http://www.annexia.org/tmp/mingw/fedora-9/src/SRPMS/mingw32-zlib-1.2.3-10.fc...

Updated package to conform with the approved packaging guidelines:
http://fedoraproject.org/wiki/Packaging/MinGW

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |467395

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |467396

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |467397

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |467401

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |467405

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |467414

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Bug 454416 depends on bug 454408, which changed state.

Bug 454408 Summary: Review Request: mingw32-binutils - MinGW Windows binutils
https://bugzilla.redhat.com/show_bug.cgi?id=454408

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |CURRENTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Bug 454416 depends on bug 454410, which changed state.

Bug 454410 Summary: Review Request: mingw32-gcc - MinGW Windows cross-compiler (GCC) for C and C++
https://bugzilla.redhat.com/show_bug.cgi?id=454410

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Adam Tkac  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |needinfo?([e-mail]
                   |                            |)

--- Comment #2 from Adam Tkac   2008-12-10 09:07:04 EDT ---
SRPM and SPEC links seem incorrect. Could you please update them? I will take
care about review.

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?([e-mail] |
                   |)                           |

--- Comment #3 from Richard W.M. Jones   2008-12-10 11:17:39 EDT ---
Thanks for looking at this.  Here are the correct URLs for this package:

Spec URL:
http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/zli...
SRPM URL:
http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-zlib-1.2.3-10.f...

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Bug 454416 depends on bug 454414, which changed state.

Bug 454414 Summary: Review Request: mingw32-w32api - MinGW Windows cross-compiler Win32 header files
https://bugzilla.redhat.com/show_bug.cgi?id=454414

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Bug 454416 depends on bug 454412, which changed state.

Bug 454412 Summary: Review Request: mingw32-runtime - MinGW Windows cross-compiler runtime and root filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=454412

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Peter Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Peter Robinson   2008-12-16 10:01:37 EDT ---
Adam are you still reviewing this?

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Adam Tkac  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Adam Tkac   2008-12-17 08:20:18 EDT ---
Sorry for late response.

Formal review:

source files match upstream: YES
package meets naming and versioning guidelines: YES
specfile is properly named, is cleanly written and uses macros consistently:
YES
dist tag is present: YES
build root is correct: YES
license field matches the actual license: YES
latest version is being packaged: YES
BuildRequires are proper: YES
compiler flags are appropriate: NO
%clean is present: YES
package builds in mock (Rawhide/x86_64): YES
-------
rpmlint is silent: NO:

$ rpmlint mingw32-zlib-1.2.3-10.fc11.src.rpm
mingw32-zlib.src:46: W: configure-without-libdir-spec
- wouldn't be better to add "--libdir=%{_mingw32_libdir}" configure parameter?

$ rpmlint mingw32-zlib-1.2.3-10.fc11.noarch.rpm
mingw32-zlib.noarch: W: no-documentation
mingw32-zlib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/zlib.h
mingw32-zlib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libz.dll.a
mingw32-zlib.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/zconf.h
mingw32-zlib.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libz.dll.a
mingw32-zlib.noarch: W: non-standard-dir-in-usr i686-pc-mingw32
- OK (there is no reason to separate headers to -devel - noone will use
  mingw32-zlib-libs package without -devel on Fedora)
------
final provides and requires look sane: YES
doesn't own any directories it shouldn't: YES
no duplicates in %files: YES
file permissions are appropriate: YES
code, not content: YES
documentation is small, so no -docs subpackage is necessary: YES
----------------------------------------------------------------

Currently I see two problems:
- compiler flags are not correct, it seems you have to add
"CFLAGS=%{_mingw32_cflags}" parameter to make

- static version of library is packaged:
$ file /usr/i686-pc-mingw32/sys-root/mingw/lib/libz.dll.a
/usr/i686-pc-mingw32/sys-root/mingw/lib/libz.dll.a: current ar archive

MinGW packaging guidelines says that static libraries should be packaged in
-static subpackage (http://fedoraproject.org/wiki/Packaging/MinGW, "Static
libraries" statement). Yes, it is pedantry but guidelines should be honoured.

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

--- Comment #6 from Richard W.M. Jones   2008-12-18 05:19:43 EDT ---
Just a quick note that libz.dll.a isn't a static library, in
the sense meant by the guidelines.

Under Windows, DLLs are split into two parts:  The foo-1.dll
which is the shared library needed at runtime.  But if you
want to link with the shared library, you need a library of
stub routines, called foo.dll.a (for cross-compilation)
or more normally foo.lib if this was a real Windows machine.

We actually remove the real static libraries from all of
the mingw32-* packages.

I'll take a look at the rest in an hour or two.

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

--- Comment #7 from Richard W.M. Jones   2008-12-18 06:28:33 EDT ---
Thanks for looking at this package.  Here is an updated package
that sets CFLAGS correctly (and I've verified that they are passed
to gcc).

Spec URL:
http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/zli...
SRPM URL:
http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-zlib-1.2.3-11.f...

* Thu Dec 18 2008 Richard W.M. Jones  - 1.2.3-11
- Pass correct CFLAGS to build.

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Adam Tkac  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #8 from Adam Tkac   2008-12-18 07:02:08 EDT ---
(In reply to comment #6)
> Just a quick note that libz.dll.a isn't a static library, in
> the sense meant by the guidelines.
>
> Under Windows, DLLs are split into two parts:  The foo-1.dll
> which is the shared library needed at runtime.  But if you
> want to link with the shared library, you need a library of
> stub routines, called foo.dll.a (for cross-compilation)
> or more normally foo.lib if this was a real Windows machine.

Ah, I didn't know how things work. Thanks for your explanation.

With correct CFLAGS package is OK => reviewed (formal review is in comment #5)

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #9 from Richard W.M. Jones   2008-12-18 07:07:31 EDT ---
New Package CVS Request
=======================
Package Name: mingw32-zlib
Short Description: MinGW Windows zlib compression library
Owners: rjones berrange lfarkas
Branches: EL-5 F-10
InitialCC:

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #10 from Kevin Fenzi   2008-12-20 22:56:14 EDT ---
cvs done.

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

--- Comment #11 from Richard W.M. Jones   2008-12-21 06:29:48 EDT ---
Thanks Adam and Kevin.

Imported and built.

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |479874

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |467416

[Bug 454416] Review Request: mingw32-zlib - MinGW Windows zlib compression library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=454416

Thomas Sailer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Thomas Sailer   2009-04-30 12:02:51 EDT ---
The native zlib package also generates the minizip and minizip-devel packages.
These are also libraries and thus eligible for mingw32. Why have they been
dropped?