[Bug 1655297] New: Review Request: libqmatrixclient - A Qt5 library to write cross-platform clients for Matrix

https://bugzilla.redhat.com/show_bug.cgi?id=1655297

Bug ID: 1655297
           Summary: Review Request: libqmatrixclient - A Qt5 library to
                    write cross-platform clients for Matrix
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Created attachment 1510624
  --> https://bugzilla.redhat.com/attachment.cgi?id=1510624&action=edit
fedora-review

Spec URL: http://marcdeop.fedorapeople.org/libqmatrixclient.spec
SRPM URL:
http://marcdeop.fedorapeople.org/libqmatrixclient-0.4.0-1.fc28.src.rpm

Fedora Account System Username: marcdeop

Description: A Qt5 library to write cross-platform clients for Matrix

fedora-review attached

[Bug 1655297] Review Request: libqmatrixclient - A Qt5 library to write cross-platform clients for Matrix

https://bugzilla.redhat.com/show_bug.cgi?id=1655297

Artur Iwicki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Artur Iwicki  ---
> %{__mkdir_p} build

Macro forms of system executables should not be used.
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
> %package devel
> Requires:   %{name} = %{version}-%{release}

This should be an arched dependency - "Requires: %{name}%{?isa}".

[Bug 1655297] Review Request: libqmatrixclient - A Qt5 library to write cross-platform clients for Matrix

https://bugzilla.redhat.com/show_bug.cgi?id=1655297

--- Comment #2 from Marc Deop  ---
(In reply to Artur Iwicki from comment #1)
> > %{__mkdir_p} build
>
> Macro forms of system executables should not be used.
> https://fedoraproject.org/wiki/Packaging:Guidelines#Macros

Fixed
> > %package devel
> > Requires:   %{name} = %{version}-%{release}
>
> This should be an arched dependency - "Requires: %{name}%{?isa}".

Also fixed.

The files can be found now at:
Spec URL: http://marcdeop.fedorapeople.org/libqmatrixclient.spec
SRPM URL:
http://marcdeop.fedorapeople.org/libqmatrixclient-0.4.0-2.fc28.src.rpm

Thanks a lot Artur Iwicki!