[Bug 845890] New: Review Request: python-django-tinymce - TinyMCE form field editor for Django applications - package-review

List overview All Threads
Download

newer

[Bug 845890] New: Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

older

[Bug 902503] New: Review Request:...

[Bug 917330] New: Review Request:...

Red Hat Bugzilla

5 Aug 2012 5 Aug '12

9:50 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=845890

Bug ID: 845890 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: python-django-tinymce - TinyMCE form field editor for Django applications Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: yuwang@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora

Spec URL: http://yuwang.fedorapeople.org/python-django-tinymce.spec SRPM URL: http://yuwang.fedorapeople.org/python-django-tinymce-1.5-1.fc16.src.rpm Description: A Django application that contains a widget to render a form field as a TinyMCE editor. Fedora Account System Username: yuwang

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

6 Aug 6 Aug

3:16 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

Matthias Runge mrunge@matthias-runge.de changed:

--- Comment #1 from Matthias Runge mrunge@matthias-runge.de --- some comments before doing a real review: - CFLAGS not required for noarch - you need to obsolete the latest pushed version. is this 1.5-3? If yes, then

- what is the latest version? the changelog is ordered by date, but version numbers increase/decrease I see a version django-tinymce-1.5-5.fc18 in koji, but not in any repo. Did you push it once?

* Fri Aug 3 2012 Yuguang Wang yuwang@redhat.com - 1.5-1 - package rename to python-django-tinymce

* Wed Jul 18 2012 Fedora Release Engineering rel-eng@lists.fedoraproject.org - 1.5-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild

* Fri Jan 13 2012 Fedora Release Engineering rel-eng@lists.fedoraproject.org - 1.5-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild

- homepage is probably now: https://github.com/aljosa/django-tinymce

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

3:21 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

Matthias Runge mrunge@matthias-runge.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |736776

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

8 Aug 8 Aug

9:42 p.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #2 from Yuguang Wang yuwang@redhat.com --- (In reply to comment #1)

...

some comments before doing a real review:

CFLAGS not required for noarch

I've removed CFLAGS from spec.

...

you need to obsolete the latest pushed version. is this 1.5-3? If yes, then

what is the latest version? the changelog is ordered by date, but version

numbers increase/decrease I see a version django-tinymce-1.5-5.fc18 in koji, but not in any repo. Did you push it once?

I didn't push any version newer than 1.5-3, seem 1.5-5 is available in koji. I've bumped the obsolete version in spec for a work around.

...

Fri Aug 3 2012 Yuguang Wang yuwang@redhat.com - 1.5-1

package rename to python-django-tinymce

Wed Jul 18 2012 Fedora Release Engineering

rel-eng@lists.fedoraproject.org - 1.5-2

Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild

Fri Jan 13 2012 Fedora Release Engineering

rel-eng@lists.fedoraproject.org - 1.5-3

Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild

The changelogs above are not added by me. I obtained the latest spec from another package django-tinymce(https://bugzilla.redhat.com/show_bug.cgi?id=728823).

however, I've removed the weird un-ordered date. Thanks for your help :) latest spec/srpm: Spec URL: http://yuwang.fedorapeople.org/python-django-tinymce.spec SRPM URL: http://yuwang.fedorapeople.org/python-django-tinymce-1.5-2.fc16.src.rpm Description: A Django application that contains a widget to render a form field as a TinyMCE editor. Fedora Account System Username: yuwang

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

9 Aug 9 Aug

12:57 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #3 from Matthias Runge mrunge@matthias-runge.de --- Reading my comment from #c1 again, it looks like I simply didn't wrote, what I meant (or didn't made that clear)

Orphans and changelog are still incorrect.

You may not start with a release number 1, those have to be increasing during each package version. Since you're providing django-tinymce-1.5-2, and obsoleting everything less than django-tinymce-1.5-5, you're obsoleting especially this newer version, too.

It's no problem, to have a renamed package starting with release number 6, or 10, or 17, if the preceding package had release number 5, 9, or 16.

- It also looks like you didn't remove cflags from build-section. - As stated in #c1, you should change package homepage, since the old one simply states: MOVED TO GITHUB

code and issues at github

https://github.com/aljosa/django-tinymce

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:24 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #4 from Yuguang Wang yuwang@redhat.com --- Release bumped to 6. CFLAGS removed. Project homepage changed to github.

Spec URL: http://yuwang.fedorapeople.org/python-django-tinymce.spec SRPM URL: http://yuwang.fedorapeople.org/python-django-tinymce-1.5-6.fc16.src.rpm Description: A Django application that contains a widget to render a form field as a TinyMCE editor. Fedora Account System Username: yuwang

Unfortunately the project page in github didn't provide a linkable url to download the tarball, I've added comment on where I obtained the upstream tarball.

$ rpmlint python-django-tinymce.spec /rpmbuild/SRPMS/python-django-tinymce-1.5-6.fc16.src.rpm python-django-tinymce.spec: W: invalid-url Source0: aljosa-django-tinymce-f3d4b92.tar.gz python-django-tinymce.src: W: invalid-url Source0: aljosa-django-tinymce-f3d4b92.tar.gz 1 packages and 1 specfiles checked; 0 errors, 2 warnings.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

14 Aug 14 Aug

2:26 p.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

Matthias Runge mrunge@matthias-runge.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #5 from Matthias Runge mrunge@matthias-runge.de --- Sorry for lagging this.

BuildRequires: python-devel still should read python2-devel

I guess, you could correct that during import.

Package APPROVED.

Since I'm already maintaining tinymce, would you accept me as co-maintainer?

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

9:42 p.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

Yuguang Wang yuwang@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #6 from Yuguang Wang yuwang@redhat.com --- (In reply to comment #5)

...

Sorry for lagging this.

BuildRequires: python-devel still should read python2-devel

I guess, you could correct that during import.

Package APPROVED.

Thanks.

...

Since I'm already maintaining tinymce, would you accept me as co-maintainer?

I'm happy about this ;)

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

9:44 p.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #7 from Yuguang Wang yuwang@redhat.com --- New Package SCM Request ======================= Package Name: python-django-tinymce Short Description: TinyMCE form field editor for Django applications Owners: yuwang mrunge Branches: f17 f18 el6 InitialCC: yuwang mrunge

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

15 Aug 15 Aug

1:38 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #8 from Matthias Runge mrunge@matthias-runge.de --- Since, django-rename targets only on f18+, I'll change the SCM request.

(cf. https://fedoraproject.org/wiki/User:Bkabrda/Django_rename).

Please take care to retire django-tinymce (cf. http://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life )

New Package SCM Request ======================= Package Name: python-django-tinymce Short Description: TinyMCE form field editor for Django applications Owners: yuwang mrunge Branches: f18 InitialCC: yuwang mrunge

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

5:55 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

6:53 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:

--- Comment #10 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com --- Since it seems that everything was built successfuly, I'm closing this bug.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

6:54 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

https://bugzilla.redhat.com/show_bug.cgi?id=845890

Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |840369

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4 Feb 4 Feb

2:15 p.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845890

Ralph Bean rbean@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |rbean@redhat.com

--- Comment #11 from Ralph Bean rbean@redhat.com --- *** Bug 907598 has been marked as a duplicate of this bug. ***

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2kqmylnLZw&a=cc_unsubscribe

Red Hat Bugzilla

7 Feb 7 Feb

1:54 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845890

Matthias Runge mrunge@redhat.com changed:

--- Comment #12 from Matthias Runge mrunge@redhat.com --- Package Change Request ====================== Package Name: python-django-tinymce New Branches: el6 Owners: mrunge ralph

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yGdT9o3LAV&a=cc_unsubscribe

Red Hat Bugzilla

7:21 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #13 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wqcDcGCp6v&a=cc_unsubscribe

Red Hat Bugzilla

8:03 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #14 from Ralph Bean rbean@redhat.com --- *** Bug 907614 has been marked as a duplicate of this bug. ***

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FClAJGbCFA&a=cc_unsubscribe

Red Hat Bugzilla

8:47 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- python-django-tinymce-1.5.1b4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-django-tinymce-1.5.1b4-1.el6

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=68wPlCjJ8V&a=cc_unsubscribe

Red Hat Bugzilla

26 Feb 26 Feb

8:59 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- python-django-tinymce-1.5.1b4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-django-tinymce-1.5.1b4-1.fc18

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LnqbvUr1Iy&a=cc_unsubscribe

Red Hat Bugzilla

11 Mar 11 Mar

2:36 p.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- python-django-tinymce-1.5.1b4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e9ZOmHxVcY&a=cc_unsubscribe

Red Hat Bugzilla

12 Mar 12 Mar

3:24 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845890

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ktms8hur9I&a=cc_unsubscribe

Red Hat Bugzilla

3:24 a.m.

New subject: [Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845890

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- python-django-tinymce-1.5.1b4-1.fc18 has been pushed to the Fedora 18 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dxTYL9ssDT&a=cc_unsubscribe

4516

Age (days ago)

4734

Last active (days ago)

package-review@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla