Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: walters@redhat.com QAContact: fedora-package-review@redhat.com
Spec URL: http://download.mugshot.org/extras/canvas/source/hippo-canvas.spec SRPM URL: http://download.mugshot.org/extras/canvas/source/hippo-canvas-0.2.13-2.src.r... Description: This library will be necessary for eventual packaging of the "bigboard" Mugshot sidebar. Likely in the future we will change the Mugshot package to depend on this as well.
I mostly just tweaked a spec file originally written by John Palmieri. This is not my first RPM, though I do not currently maintain any Fedora packages; thus this will be my first in the new system.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
walters@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
------- Additional Comments From mclasen@redhat.com 2007-04-19 13:16 EST ------- The spec file looks fine in general, just a few minor comments:
A full source url is generally preferred, if you have one.
I wondered about the fact that the -devel package does not install a .pc file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-04-28 11:57 EST ------- Created an attachment (id=153716) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=153716&action=vie...) mock build log of hippo-canvas-0.2.13-2 on FC-devel i386
Mock build on FC-devel i386 failed as attached.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mclasen@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
------- Additional Comments From mclasen@redhat.com 2007-05-03 13:44 EST ------- rpmlint output: E: hippo-canvas zero-length /usr/share/doc/hippo-canvas-0.2.13/AUTHORS E: hippo-canvas zero-length /usr/share/doc/hippo-canvas-0.2.13/README W: hippo-canvas-devel no-documentation W: hippo-canvas-python no-documentation
Package name: ok Spec file name: ok Packaging guidelines: ok, just some cosmetic things: - Descriptions should be full sentences ending in a .. - Typo: "multipul" should be "multiple" License: ok, I assume. But I wonder why you need any of the "mugshot trademark" stuff in this package. Wouldn't it be easier to just make this straight GPL, since there is no actual "Mugshot" in this package, it is just a canvas... License file included: ok Spec file language and clarity: excellent Upstream source: ok Package build: Missing BRs: pygtk2-devel, pycairo-devel Relocatable: n/a Directory ownership: ok File lists: ok %clean section: ok Macro use: ok Content: ok Large docs: n/a %doc files: AUTHORS and README are empty, so either remove them or (better) put something in them. Headers: ok pc file: n/a shared libs: ok static libs: n/a -devel dependencies: ok .la file: ok .desktop files: n/a %install section cleans buildroot: ok filename encoding: ok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
------- Additional Comments From walters@redhat.com 2007-05-03 14:48 EST ------- Thanks for the comments, I've fixed most of these issues I believe, with the exception of the doc warnings for hippo-canvas-{devel,python}; just talked with Havoc about the LICENSE and we're going to make it plain LGPL I think.
A new version should be uploaded now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From mclasen@redhat.com 2007-05-03 23:07 EST ------- Yes, looks fine. Approved. I guess you need a sponsor now to get the package actually built. Of the desktop team, I know that at least alex is a sponsor, so you may want to ask him for sponsorship.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
------- Additional Comments From bdpepple@ameritech.net 2007-05-07 15:44 EST ------- Colin, I'm willing to be your sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
bdpepple@ameritech.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|mclasen@redhat.com |bdpepple@ameritech.net
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
------- Additional Comments From bdpepple@ameritech.net 2007-05-07 17:07 EST ------- MD5Sums: 966b23b717fad5c6d3efaac199b64b93 hippo-canvas-0.2.17.tar.gz
Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * No deprecated fields used * All necessary BuildRequires listed. * All desired features are enabled * Package rebuilds as non-root user * rpmlint only produces the following warnings that are fine: W: hippo-canvas-devel no-documentation W: hippo-canvas-python no-documentation
+1 APPROVED & I'll sponsor you if no one else has yet.
http://fedoraproject.org/wiki/PackageMaintainers/Join#head-0dbf12f9c493a3f20...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
------- Additional Comments From walters@redhat.com 2007-05-07 17:35 EST ------- Awesome Brian, thanks for the review. As I understand the process the next step is to make an account, which I have done. My username is 'walters'.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
------- Additional Comments From bdpepple@ameritech.net 2007-05-07 17:58 EST ------- Colin, I've approved you for the cvsextras group, which should leave your at step 6 of here: http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a8956...
If you run into any problems, drop me a line.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
walters@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| | Flag| |fedora-cvs?
------- Additional Comments From walters@redhat.com 2007-05-09 11:58 EST ------- New Package CVS Request ======================= Package Name: hippo-canvas Short Description: Crossplatform canvas using cairo Owners: walters@redhat.com Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
------- Additional Comments From bdpepple@ameritech.net 2007-06-02 09:41 EST ------- Colin, has this been built yet? If so, this bug can be closed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
walters@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From walters@redhat.com 2007-06-04 18:02 EST ------- Package Change Request ====================== Package Name: hippo-canvas New Branches: F7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From tibbs@math.uh.edu 2007-06-05 19:20 EST ------- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora
walters@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |johnp@redhat.com, | |mpg@redhat.com
------- Additional Comments From walters@redhat.com 2007-06-27 16:27 EST ------- Package Change Request ====================== Package Name: hippo-canvas New Owners: walters@redhat.com,johnp@redhat.com,mpg@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
walters@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-06-28 16:11 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
mpg@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From mpg@redhat.com 2007-07-11 07:40 EST ------- Package Change Request ====================== Package Name: hippo-canvas New Branches: OLPC-2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-07-11 22:12 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235741
Tomeu Vizoso tomeu@tomeuvizoso.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tomeu@tomeuvizoso.net
--- Comment #18 from Tomeu Vizoso tomeu@tomeuvizoso.net 2008-11-13 05:36:53 EDT --- Package Change Request ====================== Package Name: hippo-canvas New Branches: OLPC-4 Owners: mpg erikos tomeu
We need to fork this package because Sugar 0.83 (which should ship in the F10-based 9.1 OLPC release) depends on the three commits referenced below, which introduces API changes and thus cannot be applied in the F10 branch.
http://svn.gnome.org/viewvc/hippo-canvas?view=revision&revision=7297 http://svn.gnome.org/viewvc/hippo-canvas?view=revision&revision=7296 http://svn.gnome.org/viewvc/hippo-canvas?view=revision&revision=7295
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235741
Tomeu Vizoso tomeu@tomeuvizoso.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235741
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #19 from Kevin Fenzi kevin@tummy.com 2008-11-14 00:48:30 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235741
Sebastian Dziallas sebastian@when.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@when.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #20 from Sebastian Dziallas sebastian@when.com 2010-07-21 09:46:16 EDT --- Package Change Request ====================== Package Name: hippo-canvas New Branches: EL-6 Owners: sdz pbrobinson
I'm the new owner of hippo-canvas after talking to Colin. This package is another dependency for Sugar in our effort to bring it to EPEL.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=235741
--- Comment #21 from Kevin Fenzi kevin@tummy.com 2010-07-23 17:24:35 EDT --- CVS done (by process-cvs-requests.py).
package-review@lists.fedoraproject.org