Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247984
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: bert@freudenbergs.de QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://etoys.laptop.org/srpm/etoys-2.0.1434-1.spec SRPM URL: http://etoys.laptop.org/srpm/etoys-2.0.1434-1.src.rpm Description: System-installed part of the Etoys activity for OLPC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247984
------- Additional Comments From jochen@herr-schmitt.de 2007-07-12 14:50 EST ------- Some quick comments about your package:
- You don't used the %{_smp_mflags} macro in the make step - you don't cleaned the buildroot in the %clean section
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247984
------- Additional Comments From bert@freudenbergs.de 2007-07-13 17:41 EST ------- Fixed _smp_mpflags and cleaning New Spec URL: http://etoys.laptop.org/srpm/etoys-2.0.1451-1.spec New SRPM URL: http://etoys.laptop.org/srpm/etoys-2.0.1451-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247984
bert@freudenbergs.de changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |247983
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247984
------- Additional Comments From tibbs@math.uh.edu 2007-07-29 14:47 EST ------- Just a few comments; I can't build this because the dependency isn't in, but I slanced over the spec file.
Don't use Prefix: or Vendor:.
http://www.squeakland.org/ looks to be a better URL.
There's no need for the [ -n "%{buildroot}" -a "%{buildroot}" != "/" ] && rm -rf "%{buildroot}" magic. You set the buildroot in the spec; it won't be '/'.
It's not really necessary to include the full upstream changelog as your changelog, although it's OK if that's what you want to do.
The unversioned doc directory is odd. Most packages use %doc to mark documentation in the source directory; rpm will copy it into a versioned directory under /usr/share/doc. I'm honestly not sure if an unversioned documentation directory is OK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247984
------- Additional Comments From bert@freudenbergs.de 2007-07-29 16:17 EST ------- Thanks for your suggestions. I'll be on vacation in August, but will get back to this afterwards.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@till.name
------- Additional Comments From opensource@till.name 2007-09-08 08:30 EST ------- Another issues:
- provide a full URL in Source0 to get the tarball or include a comment how to generate the tarball - do not use /usr but %{_prefix} - %files needs a defattr line - use %{_libdir} and %{_datadir} in %files - is ROOT=%{buildroot} in %build really needed? - consider using disttag
Please read: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/RPMMacros (it's about %{_libdir} and other macros) http://fedoraproject.org/wiki/Packaging/ReviewGuidelines (defattr) http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-beca3bf84972f1... (disttag) http://fedoraproject.org/wiki/Packaging/SourceURL (about the URL in Source0)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |177841
------- Additional Comments From opensource@till.name 2007-09-08 08:38 EST ------- Bert, you are not yet sponsored according to the Fedora Account System, please read: http://fedoraproject.org/wiki/PackageMaintainers/Join http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
In case that OLPC packge maintainers do not need to be sponsored, please tell me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Flag| |needinfo?(bert@freudenbergs. | |de)
------- Additional Comments From tibbs@math.uh.edu 2007-10-11 23:19 EST ------- Anything happening here?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
bert@freudenbergs.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Flag|needinfo?(bert@freudenbergs.| |de) |
------- Additional Comments From bert@freudenbergs.de 2007-10-12 04:24 EST ------- I've just been busy with Real Coding so not much time for house keeping here. Will get back to this ASAP.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
johnp@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |182235 nThis| |
------- Additional Comments From johnp@redhat.com 2007-10-15 14:00 EST ------- Bert says in an e-mail:
This doesn't work because I cannot sign the CLA on behalf of Viewpoints. I'm only a consultant for them, not a legal representative.
I have explained the reasoning for the CLA but have also heard whole companies can sign a CLA which may alleviate Bert's burden. Kicking to FE-Legal so that they can explain more and give Bert options. This is also an issue with bug #247983
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
johnp@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |182235 OtherBugsDependingO|182235 | nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn|177841, 182235 | OtherBugsDependingO| |177841, 182235 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
------- Additional Comments From tibbs@math.uh.edu 2008-01-20 17:05 EST ------- Any movement over the past three months?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
------- Additional Comments From bert@freudenbergs.de 2008-01-20 17:45 EST ------- Not that I know of - although of course we have been busy hacking (see http://etoys.laptop.org/srpm/ for newer versions). Actually, maybe the simpler way is for someone else to become Fedora maintainer for Squeak and Etoys (I'm not even a regular Fedora user).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
Bug 247984 depends on bug 247983, which changed state.
Bug 247983 Summary: Review Request: squeak-vm - Squeak virtual machine for OLPC https://bugzilla.redhat.com/show_bug.cgi?id=247983
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |CANTFIX
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Etoys - Squeak-based learning environment for OLPC
https://bugzilla.redhat.com/show_bug.cgi?id=247984
tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |CANTFIX Flag| |fedora-review-
------- Additional Comments From tcallawa@redhat.com 2008-05-12 14:36 EST ------- I don't think this is possible to move forward, given the fact that squeak-vm is not acceptable for Fedora in its current state. Closing as CANTFIX.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=247984
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
package-review@lists.fedoraproject.org