https://bugzilla.redhat.com/show_bug.cgi?id=2230085
Bug ID: 2230085 Summary: Review Request: golang-github-brunoscheufler-aws-ecs-metadata - Retrieve AWS ECS Task metadata Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-brunoscheufler-aw... SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-brunoscheufler-aw...
Description: Retrieve AWS ECS Task metadata.
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=104543608
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #2 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-brunoscheufler-aw... New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-brunoscheufler-aw...
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1986879 --> https://bugzilla.redhat.com/attachment.cgi?id=1986879&action=edit The .spec file difference from Copr build 6258162 to 6368458
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
Pavel Solovev daron439@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Status|NEW |POST Assignee|nobody@fedoraproject.org |daron439@gmail.com Flags| |fedora-review+ CC| |daron439@gmail.com
--- Comment #4 from Pavel Solovev daron439@gmail.com --- Golang Package Review ==============
This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The specfile is sane. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #5 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Thank you so much Pavel!
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #6 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Thank you for the review, Pavel
https://pagure.io/releng/fedora-scm-requests/issue/56085
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-brunoscheufler-aws-ecs-meta...
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e3b35e9ca6 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e3b35e9ca6
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-89259e6c19 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-89259e6c19
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-825ad2f16f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-825ad2f16f
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-89259e6c19 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-89259e6c19 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-89259e6c19
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e3b35e9ca6 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e3b35e9ca6 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e3b35e9ca6
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-825ad2f16f has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-825ad2f16f *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-825ad2f16f
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2023-09-14 00:43:38
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-825ad2f16f has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-89259e6c19 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2230085
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e3b35e9ca6 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org