[Bug 2369997] New: Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

Bug ID: 2369997
           Summary: Review Request: gherkin - A parser and compiler for
                    the Gherkin language
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
            Blocks: 2326360
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://music.fedorapeople.org/gherkin.spec
SRPM URL: https://music.fedorapeople.org/gherkin-32.1.2-1.fc42.src.rpm
Description: Gherkin is a parser and compiler for the Gherkin language.
Fedora Account System Username: music

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2326360
[Bug 2326360] python-pytest-bdd-8.1.0 is available

[Bug 2369997] Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9125979
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2369997] Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

--- Comment #3 from Ben Beasley  ---
Thank you for the review.

(In reply to Benson Muite from comment #2)
> Comments:
> a) Makefiles have acceptance tests, though they do not seem to be used in
> the current
> CI setup upstream
> https://github.com/cucumber/gherkin/blob/main/cpp/Makefile
> https://github.com/cucumber/gherkin/blob/main/c/Makefile
> can these be used?  The acceptance tests compare outputs using a diff,
> so they seem to fail when there are small changes:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=134073780

I reported the failures upstream in
https://github.com/cucumber/gherkin/issues/412. This has resulted in some fixes
for C++: https://github.com/cucumber/gherkin/pull/414,
https://github.com/cucumber/gherkin/pull/415, and
https://github.com/cucumber/gherkin/pull/416. After those get reviewed and
merged, and hopefully we can fix C as well, I’ll see if I can get the
acceptance tests running in the RPM build and offer an updated submission.

[Bug 2369997] Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

--- Comment #4 from Ben Beasley  ---
With the patches mentioned in the previous comment, plus
https://github.com/cucumber/gherkin/pull/417 and
https://github.com/cucumber/gherkin/pull/418, I’m able to run all of the
acceptance tests, including the C acceptance tests if I do "fedpkg mockbuild
--with c". Since I am quite happy with that, I am uploading a new submission
without waiting for any of the PR’s to be merged upstream.

Spec URL: https://music.fedorapeople.org/20250617/gherkin.spec
SRPM URL: https://music.fedorapeople.org/20250617/gherkin-32.1.2-1.fc42.src.rpm

[Bug 2369997] Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

--- Comment #5 from Fedora Review Service  ---
Created attachment 2094230
  --> https://bugzilla.redhat.com/attachment.cgi?id=2094230&action=edit
The .spec file difference from Copr build 9125979 to 9178973

[Bug 2369997] Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

--- Comment #6 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9178973
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2369997] Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

Benson Muite  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST

--- Comment #7 from Benson Muite  ---
Thanks. Approved.

Review of one of:
https://bugzilla.redhat.com/show_bug.cgi?id=2373132
https://bugzilla.redhat.com/show_bug.cgi?id=2372327
would be appreciated if time allows.

[Bug 2369997] Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

--- Comment #8 from Ben Beasley  ---
Thank you for the review! I reviewed bug 2373132.

https://release-monitoring.org/project/62372/

[Bug 2369997] Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |RELEASE_PENDING

--- Comment #9 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at https://src.fedoraproject.org/rpms/gherkin

[Bug 2369997] Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #10 from Fedora Update System  ---
FEDORA-2025-f4bfd6b0d2 (gherkin-32.1.2-1.fc43) has been submitted as an update
to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f4bfd6b0d2

[Bug 2369997] Review Request: gherkin - A parser and compiler for the Gherkin language

https://bugzilla.redhat.com/show_bug.cgi?id=2369997

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2025-06-20 13:47:00

--- Comment #11 from Fedora Update System  ---
FEDORA-2025-f4bfd6b0d2 (gherkin-32.1.2-1.fc43) has been pushed to the Fedora 43
stable repository.
If problem still persists, please make note of it in this bug report.