https://bugzilla.redhat.com/show_bug.cgi?id=2161164
Bug ID: 2161164 Summary: Review Request: importlib-resources - <dependency of flask-pyoidc> Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: pkwarcraft@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/pkking/oidc-in-fedora/blob/main/importlib-resources/impor... SRPM URL: https://github.com/pkking/oidc-in-fedora/blob/main/importlib-resources/pytho... Description: used to supported oidc in copr Fedora Account System Username: lcrpkking
built successfully on copr : https://copr.fedorainfracloud.org/coprs/lcrpkking/waaagh/build/5236181/
https://bugzilla.redhat.com/show_bug.cgi?id=2161164
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5238040 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2161164
lichaoran pkwarcraft@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://github.com/pkking/oidc-in-fedora/raw/main/importlib-resources/import... SRPM URL: https://github.com/pkking/oidc-in-fedora/raw/main/importlib-resources/python... Description: used to supported oidc in copr Fedora Account System Username: lcrpkking
built successfully on copr : https://copr.fedorainfracloud.org/coprs/lcrpkking/waaagh/build/5236181/
https://bugzilla.redhat.com/show_bug.cgi?id=2161164
Neil Hanlon neil@shrug.pw changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2161163
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2161163 [Bug 2161163] Review Request: flask-pyoidc - <oidc supported in flask>
https://bugzilla.redhat.com/show_bug.cgi?id=2161164
--- Comment #2 from lichaoran pkwarcraft@gmail.com --- Spec URL: https://raw.githubusercontent.com/pkking/oidc-in-fedora/main/importlib-resou... SRPM URL: https://github.com/pkking/oidc-in-fedora/raw/main/importlib-resources/python...
https://bugzilla.redhat.com/show_bug.cgi?id=2161164
--- Comment #3 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5404530 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2161164
Mattia Verga mattia.verga@proton.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |mattia.verga@proton.me
--- Comment #4 from Mattia Verga mattia.verga@proton.me --- This package is completely useless in Fedora: "importlib_resources is a backport of Python standard library importlib.resources module for older Pythons."
And for EPEL is already packaged: https://koji.fedoraproject.org/koji/packageinfo?packageID=30226
Any package requiring importlib.resources should use conditionals in their import like https://github.com/p1c2u/openapi-spec-validator/commit/c4746e3aeea4c76229203... so that standard library is used when available.
https://bugzilla.redhat.com/show_bug.cgi?id=2161164
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |importlib-resources - |python-importlib-resources |<dependency of |- Read resources from |flask-pyoidc> |Python packages
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com