[Bug 1690185] New: Review Request: golang-github-macaron - Productive and modular web framework in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
Bug ID: 1690185 Summary: Review Request: golang-github-macaron - Productive and modular web framework in Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nathans@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://nathans.fedorapeople.org/macaron/golang-github-macaron.spec SRPM URL: https://nathans.fedorapeople.org/macaron/golang-github-macaron-1.3.2-1.fc29....
Description: Productive and modular web framework in Go Fedora Account System Username: nathans
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
Nathan Scott nathans@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mgoodwin@redhat.com, | |quantum.analyst@gmail.com, | |zebob.m@gmail.com Blocks| |1670656
--- Comment #1 from Nathan Scott nathans@redhat.com --- Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33624211
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1670656 [Bug 1670656] Review Request: grafana - an open source, feature rich metrics dashboard and graph editor
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1377262, 1376389, 1376719, | |201449 (FE-DEADREVIEW) CC| |mrunge@redhat.com
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- *** Bug 1376691 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. https://bugzilla.redhat.com/show_bug.cgi?id=1376389 [Bug 1376389] Tracker for grafana dependencies https://bugzilla.redhat.com/show_bug.cgi?id=1376719 [Bug 1376719] Review Request: golang-github-go-macaron-binding - Provides request data binding and validation for Macaron https://bugzilla.redhat.com/show_bug.cgi?id=1377262 [Bug 1377262] Review Request: golang-github-go-macaron-gzip - Provides Gzip compress to responses for Macaron
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- - Do not require Go deps like this:
BuildRequires: golang-gopkg-ini-1-devel BuildRequires: golang-golangorg-crypto-devel BuildRequires: golang-github-unknwon-com-devel BuildRequires: golang-github-go-macaron-inject-devel BuildRequires: golang-github-smartystreets-goconvey-devel
Use golang(importpath)
You should use the Gofed tool to create draft of the SPEC not do them manually.
BuildRequires: golang(github.com/Unknwon/com) BuildRequires: golang(github.com/go-macaron/inject) BuildRequires: golang(golang.org/x/crypto/pbkdf2) BuildRequires: golang(gopkg.in/ini.v1) BuildRequires: golang(github.com/smartystreets/goconvey/convey)
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
--- Comment #4 from Nathan Scott nathans@redhat.com --- (In reply to Robert-André Mauchin from comment #3)
- Do not require Go deps like this:
OK - will do. (for my education, what's the reason for one way over the other? or is there somewhere I can read about it? taa)
BuildRequires: golang-gopkg-ini-1-devel
Also - should these golang packages with the versioned gopkg.in variants have spec file names containing an explicit version number? (in case someone packages a different version later?) i.e. for this review, should I have named the file 'golang-github-macaron-1.spec' or perhaps 'golang-github-macaron-v1.spec'? (or something else entirely?)
You should use the Gofed tool to create draft of the SPEC not do them manually.
Thanks - I'll take another look. I didn't have alot of success with gofed initially (based on steps in the fedora wiki docs) and got the impression it was out of favour.
cheers.
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
--- Comment #5 from Nathan Scott nathans@redhat.com --- BTW, I have updated the spec and SRPM to fix the builddeps (same place as before).
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
Nathan Scott nathans@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |golang-github-macaron - |golang-github-macaron-v1 - |Productive and modular web |Productive and modular web |framework in Go |framework in Go
--- Comment #6 from Nathan Scott nathans@redhat.com --- Updated to include explicit stable API version in the spec, as in #c4 -
Spec URL: https://nathans.fedorapeople.org/macaron-v1/golang-github-macaron-v1.spec SRPM URL: https://nathans.fedorapeople.org/macaron-v1/golang-github-macaron-v1-1.3.2-1...
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
Mark Goodwin mgoodwin@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |mgoodwin@redhat.com Flags| |fedora-review+
--- Comment #7 from Mark Goodwin mgoodwin@redhat.com --- Looks good to me - approved.
Comments: golang-github-macaron-v1.src: E: changelog-time-in-future 2019-03-22 -- changelog is fine (Australia TZ is currently in the future!)
golang-github-macaron-v1.src: W: no-%build-section -- can optionally be resolved with %build true
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License (v2.0)", "Unknown or generated", "Apache License (v2.0)". 15 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode/src/gopkg.in, /usr/share/gocode [x]: Package does not own files or directories owned by other packages. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-macaron-v1-devel , golang-gopkg-1-macaron-devel , golang-gopkg- macaron-1-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-macaron-v1-devel-1.3.2-1.fc31.noarch.rpm golang-gopkg-1-macaron-devel-1.3.2-1.fc31.noarch.rpm golang-gopkg-macaron-1-devel-1.3.2-1.fc31.noarch.rpm golang-github-macaron-v1-1.3.2-1.fc31.src.rpm golang-github-macaron-v1-devel.noarch: E: changelog-time-in-future 2019-03-22 golang-github-macaron-v1-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/go-macaron/macaron/.goipath golang-gopkg-1-macaron-devel.noarch: E: changelog-time-in-future 2019-03-22 golang-gopkg-1-macaron-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/gopkg.in/v1/macaron/.goipath golang-gopkg-macaron-1-devel.noarch: E: changelog-time-in-future 2019-03-22 golang-gopkg-macaron-1-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/gopkg.in/macaron.v1/.goipath golang-github-macaron-v1.src: E: changelog-time-in-future 2019-03-22 golang-github-macaron-v1.src: W: no-%build-section 4 packages and 0 specfiles checked; 4 errors, 4 warnings.
Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_AU.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_AU.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_AU.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sh: /usr/bin/python: No such file or directory golang-gopkg-1-macaron-devel.noarch: E: changelog-time-in-future 2019-03-22 golang-gopkg-1-macaron-devel.noarch: W: invalid-url URL: https://github.com/go-macaron/macaron <urlopen error [Errno -2] Name or service not known> golang-gopkg-1-macaron-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/gopkg.in/v1/macaron/.goipath golang-gopkg-macaron-1-devel.noarch: E: changelog-time-in-future 2019-03-22 golang-gopkg-macaron-1-devel.noarch: W: invalid-url URL: https://github.com/go-macaron/macaron <urlopen error [Errno -2] Name or service not known> golang-gopkg-macaron-1-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/gopkg.in/macaron.v1/.goipath golang-github-macaron-v1-devel.noarch: E: changelog-time-in-future 2019-03-22 golang-github-macaron-v1-devel.noarch: W: invalid-url URL: https://github.com/go-macaron/macaron <urlopen error [Errno -2] Name or service not known> golang-github-macaron-v1-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/go-macaron/macaron/.goipath 3 packages and 0 specfiles checked; 3 errors, 6 warnings.
Requires -------- golang-gopkg-1-macaron-devel (rpmlib, GLIBC filtered): golang(github.com/Unknwon/com) golang(github.com/go-macaron/inject) golang(golang.org/x/crypto/pbkdf2) golang(gopkg.in/ini.v1)
golang-gopkg-macaron-1-devel (rpmlib, GLIBC filtered): golang(github.com/Unknwon/com) golang(github.com/go-macaron/inject) golang(golang.org/x/crypto/pbkdf2) golang(gopkg.in/ini.v1)
golang-github-macaron-v1-devel (rpmlib, GLIBC filtered): golang(github.com/Unknwon/com) golang(github.com/go-macaron/inject) golang(golang.org/x/crypto/pbkdf2) golang(gopkg.in/ini.v1)
Provides -------- golang-gopkg-1-macaron-devel: golang(gopkg.in/v1/macaron) golang-gopkg-1-macaron-devel golang-ipath(gopkg.in/v1/macaron)
golang-gopkg-macaron-1-devel: golang(gopkg.in/macaron.v1) golang-gopkg-macaron-1-devel golang-ipath(gopkg.in/macaron.v1)
golang-github-macaron-v1-devel: golang(github.com/go-macaron/macaron) golang-github-macaron-v1-devel golang-ipath(github.com/go-macaron/macaron)
Source checksums ---------------- https://github.com/go-macaron/macaron/archive/v1.3.2.tar.gz#/macaron-1.3.2.t... : CHECKSUM(SHA256) this package : 5d8f8428d7ce97d73b25730e0bfbbde750750346aa9449bc01b5f2b859d39efe CHECKSUM(SHA256) upstream package : 1fc9c2686251013ff63849912386e48ffc95f41033d595024ef17dc44c10cef9 However, diff -r shows no differences
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1690185 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
--- Comment #8 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-macaron-v1
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
Nathan Scott nathans@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2019-03-22 21:05:31
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-macaron-v1-1.3.2-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2ad77fa549
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-macaron-v1-1.3.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2ad77fa549
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-macaron-v1-1.3.2-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2ee9a37927
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- golang-github-macaron-v1-1.3.2-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2ee9a37927
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- golang-github-macaron-v1-1.3.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1690185
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- golang-github-macaron-v1-1.3.2-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com