https://bugzilla.redhat.com/show_bug.cgi?id=1264660
Bug ID: 1264660 Summary: Review Request: rubygem-mini_magick - Manipulate images Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: ilya.gradina@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-mini_m... SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-mini_m... Description: Manipulate images with minimal use of memory via ImageMagick / GraphicsMagick Fedora Account System Username: ilgrad
https://bugzilla.redhat.com/show_bug.cgi?id=1264660
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #1 from Vít Ondruch vondruch@redhat.com --- Hi Ilya,
is the BR: rubygem(rake) required? We usually try to avoid dependency on Rake, since it tends to pull in more then necessary for build. Moreover, you don't execute any Rake command ...
https://bugzilla.redhat.com/show_bug.cgi?id=1264660
--- Comment #2 from Ilya Gradina ilya.gradina@gmail.com --- Hi Vit,
Spec URL: http://repo.clanwars.org/gitlab/rubygem-mini_magick.spec SRPM URL: http://repo.clanwars.org/gitlab/rubygem-mini_magick-4.3.3-2.fc24.src.rpm
- remove BR: rubygem(rake) and rubygem(rspec) - add test
https://bugzilla.redhat.com/show_bug.cgi?id=1264660
--- Comment #3 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- ilgrad's scratch build of rubygem-mini_magick-4.3.3-2.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11266884
https://bugzilla.redhat.com/show_bug.cgi?id=1264660
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1267323
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1267323 [Bug 1267323] Review Request: rubygem-carrierwave - Ruby file upload library
https://bugzilla.redhat.com/show_bug.cgi?id=1264660
--- Comment #4 from Ilya Gradina ilya.gradina@gmail.com --- New Spec: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-mini_m... New SRPM: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-mini_m...
https://bugzilla.redhat.com/show_bug.cgi?id=1264660
--- Comment #5 from Vít Ondruch vondruch@redhat.com --- You don't specify runtime dependency on any of GraphicsMagick or ImageMagick. Shouldn't you choose one? Which is preferred? Shouldn't you use "Recommends" to make this working out of the box?
https://bugzilla.redhat.com/show_bug.cgi?id=1264660
Pavel Valena pvalena@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |pvalena@redhat.com Resolution|--- |DUPLICATE Last Closed| |2018-06-28 05:39:52
--- Comment #6 from Pavel Valena pvalena@redhat.com ---
*** This bug has been marked as a duplicate of bug 1586199 ***
package-review@lists.fedoraproject.org