https://bugzilla.redhat.com/show_bug.cgi?id=1293043
Bug ID: 1293043 Summary: Review Request: python-epac - EPAC is a machine learning workflow builder. Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ilya.gradina@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/neurofedora/python-epac/raw/master/python-epac.spec SRPM URL: https://github.com/neurofedora/python-epac/raw/master/python-epac-0.0.1-1.gi... Description: Embarrassingly Parallel Array Computing: EPAC is a machine learning workflow builder. Fedora Account System Username: ilgrad
https://bugzilla.redhat.com/show_bug.cgi?id=1293043
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1276941 (fedora-neuro) Alias| |python-epac
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=1293043
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i.gnatenko.brain@gmail.com Assignee|nobody@fedoraproject.org |i.gnatenko.brain@gmail.com Flags| |fedora-review-
--- Comment #1 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Missing requires, missing buildrequires, no python3 package. Binary should point to py3 version.
https://bugzilla.redhat.com/show_bug.cgi?id=1293043
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl Summary|Review Request: python-epac |Review Request: python-epac |- EPAC is a machine |- Machine learning workflow |learning workflow builder. |builder Flags|fedora-review- |
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- fedora-review- is for packages which can't be fixed, while the review is in progress it's customary not to set anything, or to set fedora-review?.
Do not repeat the package name in the summary (it should be short to display properly in various listings). Maybe Summary: Machine learning workflow builder
The license tag for bsd 3-clause is just "BSD". See https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses.
You should create a python2 subpackage, and add support for python3 if possible. See https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file for the new python packaging.
https://bugzilla.redhat.com/show_bug.cgi?id=1293043
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? | |needinfo?(ilya.gradina@gmai | |l.com)
--- Comment #3 from Igor Gnatenko ignatenko@redhat.com --- ping?
https://bugzilla.redhat.com/show_bug.cgi?id=1293043
--- Comment #4 from Igor Gnatenko ignatenko@redhat.com --- ping once more?
https://bugzilla.redhat.com/show_bug.cgi?id=1293043
Paul W. Frields pfrields@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|ignatenko@redhat.com |i.gnatenko.brain@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1293043
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sanjay.ankur@gmail.com
--- Comment #5 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Hi Ilya,
Would you like to continue the review so that the package can be included in NeuroFedora?
Cheers! Ankur
https://bugzilla.redhat.com/show_bug.cgi?id=1293043
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ilya.gradina@gmai | |l.com) |
--- Comment #6 from Ilya Gradina ilya.gradina@gmail.com --- (In reply to Ankur Sinha (FranciscoD) from comment #5)
Hi Ilya,
Would you like to continue the review so that the package can be included in NeuroFedora?
Cheers! Ankur
Hi Ankur, yes, I will continue the review.
package-review@lists.fedoraproject.org