Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-session - Session drives external progams
https://bugzilla.redhat.com/show_bug.cgi?id=783771
Summary: Review Request: rubygem-session - Session drives external progams Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: guillermo.gomez@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://gomix.fedorapeople.org/rubygem-session/rubygem-session.spec SRPM URL: http://gomix.fedorapeople.org/rubygem-session/rubygem-session-3.1.0-1.fc16.s...
Description: Session drives external progams
Session offers a set of classes built upon Open3::popen3 for driving external progams via pipes. It offers a significant abstraction over Open3::popen in that the stdout/stderr of each command sent can be deliniated
$ rpmlint -v SPECS/rubygem-session.spec SPECS/rubygem-session.spec: I: checking-url http://rubygems.org/gems/session-3.1.0.gem (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint -v /var/lib/mock/fedora-16-x86_64/result/rubygem-session-3.1.0-1.fc16.noarch.rpm rubygem-session.noarch: I: checking rubygem-session.noarch: W: spelling-error Summary(en_US) progams -> programs, program rubygem-session.noarch: W: spelling-error %description -l en_US progams -> programs, program rubygem-session.noarch: W: spelling-error %description -l en_US popen -> pope, open, popes rubygem-session.noarch: W: spelling-error %description -l en_US stdout -> stout, std out, std-out rubygem-session.noarch: W: spelling-error %description -l en_US stderr -> std err, std-err, stander rubygem-session.noarch: W: spelling-error %description -l en_US deliniated -> delineated, delineate, desalinated rubygem-session.noarch: I: checking-url http://github.com/ahoward/session/tree/master (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 6 warnings.
$ rpmlint -v /var/lib/mock/fedora-16-x86_64/result/rubygem-session-doc-3.1.0-1.fc16.noarch.rpm rubygem-session-doc.noarch: I: checking rubygem-session-doc.noarch: I: checking-url http://github.com/ahoward/session/tree/master (timeout 10 seconds) rubygem-session-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/session-3.1.0/ri/Session/AbstractSession/ready%3f-i.yaml %3f rubygem-session-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/session-3.1.0/ri/Session/AbstractSession/close%21-i.yaml %21 rubygem-session-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/session-3.1.0/ri/Session/Command/cmdno%3d-c.yaml %3d rubygem-session-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/session-3.1.0/ri/Session/AbstractSession/path%3d-i.yaml %3d rubygem-session-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/session-3.1.0/ri/Session/AbstractSession/default_prog%3d-c.yaml %3d rubygem-session-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/session-3.1.0/ri/Session/Sh/path%3d-i.yaml %3d rubygem-session-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/session-3.1.0/ri/Session/AbstractSession/track_history%3d-i.yaml %3d rubygem-session-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/session-3.1.0/ri/Session/IDL/path%3d-i.yaml %3d rubygem-session-doc.noarch: W: doc-file-dependency /usr/lib/ruby/gems/1.8/gems/session-3.1.0/sample/bash.rb /usr/bin/env 1 packages and 0 specfiles checked; 0 errors, 9 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=783771
Alejandro_Perez alejandro.perez.torres@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alejandro.perez.torres@gmai | |l.com AssignedTo|nobody@fedoraproject.org |alejandro.perez.torres@gmai | |l.com
--- Comment #1 from Alejandro_Perez alejandro.perez.torres@gmail.com 2012-01-22 15:02:14 EST --- [!]: MUST Package successfully compiles and builds into binary rpms on at least one supported architecture. [!]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: The package did not built BR could therefore not be checked or the package failed to build because of missing BR [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=783771
--- Comment #2 from Guillermo Gómez guillermo.gomez@gmail.com 2012-01-22 18:55:10 EST ---
1. Package builds correctly for F16 (both archs): http://koji.fedoraproject.org/koji/taskinfo?taskID=3723632
2. There's no missing BR for F16, rawhide fails to build for unknown reason (it should work, i need to investigate further). mock builds ok too in my workstation (f16 x86_64).
3. No plan yet to support EPEL5
Thanks for reviewing
- Guillermo -
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=783771
Alejandro_Perez alejandro.perez.torres@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #3 from Alejandro_Perez alejandro.perez.torres@gmail.com 2012-01-22 19:56:17 EST --- Change spelling on Summary Session drives external progams -> Session drives external programs
Correct spelling on %description
Session offers a set of classes built upon Open3::popen3 for driving external progams via pipes. It offers a significant abstraction over Open3::popen in that the stdout/stderr of each command sent can be deliniated
Session offers a set of classes built upon Open3::popen3 for driving external programs via pipes. It offers a significant abstraction over Open3::popen in that the stdout/stderr of each command sent can be delineated
Please address the issues above before import to git. This package has been
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=783771
Guillermo Gómez guillermo.gomez@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Guillermo Gómez guillermo.gomez@gmail.com 2012-01-22 20:44:28 EST --- New Package SCM Request ======================= Package Name: rubygem-session Short Description:Session drives external progams Owners: gomix Branches: f16 f15 el6 el5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=783771
--- Comment #5 from Jon Ciesla limburgher@gmail.com 2012-01-23 08:14:17 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=783771
Guillermo Gómez guillermo.gomez@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |CURRENTRELEASE Last Closed| |2012-02-07 07:10:50
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla