[Bug 1786732] New: Review Request: python-pyhocon - module and utilitiy to read hocon and convert between yaml, json and properties

https://bugzilla.redhat.com/show_bug.cgi?id=1786732

Bug ID: 1786732
           Summary: Review Request: python-pyhocon - module and utilitiy
                    to read hocon and convert between yaml, json and
                    properties
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://copr.fedorainfracloud.org/coprs/mhjacks/mhjacks_proposed_pkgs/build/...
SRPM URL:
https://copr.fedorainfracloud.org/coprs/mhjacks/mhjacks_proposed_pkgs/build/...
Description: module and utilitiy to read hocon and convert between yaml, json
and properties
Fedora Account mhjacks

[Bug 1786732] Review Request: python-pyhocon - module and utilitiy to read hocon and convert between yaml, json and properties

https://bugzilla.redhat.com/show_bug.cgi?id=1786732

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |177841 (FE-NEEDSPONSOR)
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Robert-André Mauchin  ---
 - Fix this:

Summary:        Example python module

- Source is 404:

Getting
https://files.pythonhosted.org/packages/source/p/pyhocon/pyhocon-0.3.53.tar....
to ./pyhocon-0.3.53.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404

Use the Source from Github, Pypi seems unreliable on this.

Source0:       
https://github.com/chimpler/pyhocon/archive/%%7Bversion%7D/%%7Bname%7D-%%7Bv...

- Same as before, just name the main package pyhocon since it's a binary

- Generate the docs:

BuildRequires:  python3-devel
BuildRequires:  python3dist(pyparsing)
BuildRequires:  python3dist(python-dateutil)
BuildRequires:  python3dist(mock)
BuildRequires:  python3dist(pytest)
BuildRequires:  python3dist(sphinx)

[…]

# generate html docs
PYTHONPATH=${PWD} sphinx-build-3 docs/source html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}

- Tests fail on Python 3.8 (Rawhide): report the errors upstream and wait for
them to release a version compatible with Python 3.8

%global srcname pyhocon

Name:           %{srcname}
Version:        0.3.53
Release:        2%{?dist}
Summary:        Example python module

License:        ASL 2.0
URL:            https://pypi.python.org/pypi/pyhocon
Source0:       
https://github.com/chimpler/pyhocon/archive/%%7Bversion%7D/%%7Bname%7D-%%7Bv...

BuildArch:      noarch
BuildRequires:  python3-devel
BuildRequires:  python3dist(pyparsing)
BuildRequires:  python3dist(python-dateutil)
BuildRequires:  python3dist(mock)
BuildRequires:  python3dist(pytest)
BuildRequires:  python3dist(sphinx)

%global _description %{expand:
pyhocon is a HOCON parser for Python. Additionally we provide a tool
(pyhocon) to convert any HOCON content into json, yaml and properties
format.}

%description %_description

%prep
%autosetup -n %{srcname}-%{version}

%build
%py3_build
# generate html docs
PYTHONPATH=${PWD} sphinx-build-3 docs/source html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}

%install
%py3_install

%check
%{__python3} setup.py test

%files
%license LICENSE
%doc CHANGELOG.md README.md html/
%{python3_sitelib}/%{srcname}-*.egg-info/
%{python3_sitelib}/%{srcname}/
%{_bindir}/pyhocon

%changelog
* Sun Dec 22 2019 Martin Jackson  - 0.3.53-2
- Fixed license designation
- Specified module deps as BuildRequires
- Re-enabled %check

* Fri Dec 20 2019 Martin Jackson  - 0.3.53-1
- First build.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1786732] Review Request: python-pyhocon - module and utilitiy to read hocon and convert between yaml, json and properties

https://bugzilla.redhat.com/show_bug.cgi?id=1786732

--- Comment #2 from Martin Jackson  ---
The upstream situation seems a bit more complicated than I anticipated at
first.  (My introduction to this module was by installing it via pipx on a Mac
at work; I find it useful and wanted to package it.  At the time of packaging I
was unaware of the tests failing on 3.8).

So the 0.3.53 is not the version that pipx installs; the one I've used is
actually 0.3.51.

I've opened an upstream issue on the test failures:
https://github.com/chimpler/pyhocon/issues/220.  I'll keep an eye on that; but
I'm not as sure as I was when I started that this is suitable for distro
inclusion.

I have a number of other python utilities I would like to package; is there a
protocol for leaving this open for a few weeks while we see what upstream
wants?

[Bug 1786732] Review Request: python-pyhocon - module and utilitiy to read hocon and convert between yaml, json and properties

https://bugzilla.redhat.com/show_bug.cgi?id=1786732

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |

--- Comment #3 from Robert-André Mauchin  ---
You can keep this open as long as you want.

NEEDINFO me if there is any update from upstream.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1786732] Review Request: python-pyhocon - module and utilitiy to read hocon and convert between yaml, json and properties

https://bugzilla.redhat.com/show_bug.cgi?id=1786732

Martin Jackson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |WONTFIX
        Last Closed|                            |2021-02-02 03:04:58

needinfo canceled: [Bug 1786732] Review Request: python-pyhocon - module and utilitiy to read hocon and convert between yaml, json and properties

Product: Fedora
Version: rawhide
Component: Package Review

Martin Jackson  has canceled Package Review
's request for Martin Jackson
's needinfo:
Bug 1786732: Review Request: python-pyhocon - module and utilitiy to read hocon
and convert between yaml, json and properties
https://bugzilla.redhat.com/show_bug.cgi?id=1786732

[Bug 1786732] Review Request: python-pyhocon - module and utilitiy to read hocon and convert between yaml, json and properties

https://bugzilla.redhat.com/show_bug.cgi?id=1786732

Martin Jackson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |t)                          |