[Bug 464051] New: Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package Review Request for projectM-jack
Alias: projectM-jack

https://bugzilla.redhat.com/show_bug.cgi?id=464051

Summary: Package Review Request for projectM-jack
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

SPEC URL:  http://www.vtscrew.com/projectM-jack.spec
SRPM URL:  http://www.vtscrew.com/projectM-jack-1.2.0-1.fc9.src.rpm

Description:
This package allows the use of the projectM visualization plugin through any
JACK compatible applications.

No errors or warnings from rpmlint.

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

Jameson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |464049

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

Jameson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #1 from Jameson   2008-11-06 01:49:02 EDT ---
I have a new SPEC in original location, and a new SRPM:  
http://www.vtscrew.com/projectM-jack-1.2.0-2.fc9.src.rpm

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

Jameson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

--- Comment #2 from Jameson   2008-11-06 23:48:51 EDT ---
I have a new SPEC in original location, and a new SRPM:  
http://www.vtscrew.com/projectM-jack-1.2.0-3.fc9.src.rpm

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

Orcan 'oget' Ogetbil  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #3 from Orcan 'oget' Ogetbil   2008-11-07 23:20:44 EDT ---
This one is almost perfect. There are few little things to go through.

* URL has a typo

* Same subtleties apply for the license of this package as for the
projectM-pulseaudio. "GPLv2+ and MIT" is fine but it would be good if we get a
confirmation from upstream.

* I don't see any .la files built. You should remove that line.

* For the desktop file, please add
   Encoding=UTF-8
   Terminal=false
You use the same icon in the desktop file that you use for projectM-pulseaudio.
You can require projectM-pulseaudio on this package, but that's not a nice
solution. I think the best solution is renaming the icon file for this package.

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

--- Comment #4 from Jameson   2008-11-11 20:29:24 EDT ---
I have a new SPEC in original location, and a new SRPM:  
http://www.vtscrew.com/projectM-jack-1.2.0-4.fc9.src.rpm

I double checked the URL, and it worked for me.  Am I still missing something
in it?

I'm still waiting to hear from upstream about the license issues.  I'm afraid
I've scared them off with it, though.

Sorry, I forgot that la files line.  I thought I got rid of all of them.

The desktop file is updated.  I didn't think I would need to require the
pulseaudio package since the icon is actually installed with libprojectM-qt.

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

--- Comment #5 from Jameson   2008-11-11 20:39:48 EDT ---
Oh URL, not SOURCE.  Gotcha

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

Bug 464051 depends on bug 464049, which changed state.

Bug 464049 Summary: Package Review Request for libprojectM-qt
https://bugzilla.redhat.com/show_bug.cgi?id=464049

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #6 from Orcan 'oget' Ogetbil   2008-11-11 22:23:02 EDT ---
My bad, I thought the icon belongs to projectM-pulseaudio. Then there is no
problem with the icon.

I will check this package probably tomorrow morning (EST).

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

Orcan 'oget' Ogetbil  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Orcan 'oget' Ogetbil   2008-11-12 11:16:48 EDT ---
All good!

------------------------------------------------
This package (projectM-jack) is APPROVED by oget
------------------------------------------------

Jameson, if you have time, could you review my package (Bug# 468765)?

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

Jameson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #8 from Jameson   2008-11-12 19:25:40 EDT ---
New Package CVS Request
=======================
Package Name: projectM-jack
Short Description: projectM visualizations for JACK audio
Owners: imntreal
Branches: F-9 F-10
InitialCC: imntreal

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

--- Comment #9 from Jameson   2008-11-12 19:26:16 EDT ---
> Jameson, if you have time, could you review my package (Bug# 468765)?

I'll start looking at it this week if no one else picks it up.  That's actually
one that I've been interested in.

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #10 from Kevin Fenzi   2008-11-14 00:44:02 EDT ---
cvs done.

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

--- Comment #11 from Fedora Update System   2008-11-15 15:37:36 EDT ---
projectM-jack-1.2.0-4.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/projectM-jack-1.2.0-4.fc9

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

--- Comment #12 from Fedora Update System   2008-11-19 09:51:37 EDT ---
projectM-jack-1.2.0-4.fc9 has been pushed to the Fedora 9 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

--- Comment #13 from Fedora Update System   2008-11-30 00:52:35 EDT ---
projectM-jack-1.2.0-4.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/projectM-jack-1.2.0-4.fc10

[Bug 464051] Package Review Request for projectM-jack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=464051

--- Comment #14 from Fedora Update System   2008-12-02 20:10:26 EDT ---
projectM-jack-1.2.0-4.fc10 has been pushed to the Fedora 10 stable repository. 
If problems still persist, please make note of it in this bug report.