https://bugzilla.redhat.com/show_bug.cgi?id=1960195
Bug ID: 1960195 Summary: Review Request: python-markdown-it-py - Python port of markdown-it Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ksurma@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/ksurma/python-markdown-it... SRPM URL: https://download.copr.fedorainfracloud.org/results/ksurma/python-markdown-it... Description: Markdown parser done right. Its features: Follows the CommonMark spec for baseline parsing. Has configurable syntax: you can add new rules and even replace existing ones. Pluggable: Adds syntax extensions to extend the parser. High speed & safe by default Fedora Account System Username: ksurma
This package is a dependency of myst_parser Sphinx extension which is necessary to build documentation of the newest python-pip package.
https://bugzilla.redhat.com/show_bug.cgi?id=1960195
Karolina Surma ksurma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://download.copr.fedorainfracloud.org/results/ksurma/python-markdown-it... SRPM URL: https://download.copr.fedorainfracloud.org/results/ksurma/python-markdown-it... Description: Markdown parser done right. Its features: Follows the CommonMark spec for baseline parsing. Has configurable syntax: you can add new rules and even replace existing ones. Pluggable: Adds syntax extensions to extend the parser. High speed & safe by default Fedora Account System Username: ksurma
This package is a dependency of myst_parser Sphinx extension which is necessary to build documentation of the newest python-pip package.
Copr build: https://copr.fedorainfracloud.org/coprs/ksurma/python-markdown-it-py/build/2...
https://bugzilla.redhat.com/show_bug.cgi?id=1960195
--- Comment #1 from Karolina Surma ksurma@redhat.com --- Updated version with fixed shebang.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/ksurma/python-markdown-it-py... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ksurma/python-markdown-it-py...
https://bugzilla.redhat.com/show_bug.cgi?id=1960195
Lumír Balhar lbalhar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lbalhar@redhat.com Assignee|nobody@fedoraproject.org |lbalhar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1960195
Lumír Balhar lbalhar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Lumír Balhar lbalhar@redhat.com --- Good job!
Package APPROVED
Do not hesitate to add my as an admin and python-sig as well and also do not forget to enable release-monitoring.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 145 files have unknown license. Detailed output of licensecheck in /home/lbalhar/temp/reviews/copr-build-2184177/review- python-markdown-it-py/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-markdown-it-py-1.1.0-1.fc35.noarch.rpm python-markdown-it-py-1.1.0-1.fc35.src.rpm python3-markdown-it-py.noarch: W: spelling-error %description -l en_US Pluggable -> Plug gable, Plug-gable, Plugged python3-markdown-it-py.noarch: W: no-manual-page-for-binary markdown-it python-markdown-it-py.src: W: spelling-error %description -l en_US Pluggable -> Plug gable, Plug-gable, Plugged 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- python3-markdown-it-py.noarch: W: spelling-error %description -l en_US Pluggable -> Plug gable, Plug-gable, Plugged python3-markdown-it-py.noarch: W: no-manual-page-for-binary markdown-it 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Source checksums ---------------- https://github.com/executablebooks/markdown-it-py/archive/v1.1.0/markdown-it... : CHECKSUM(SHA256) this package : 24d63b5009c224a1df816556f810c4a4042b7f31b77620d855f8b2e7adcbd915 CHECKSUM(SHA256) upstream package : 24d63b5009c224a1df816556f810c4a4042b7f31b77620d855f8b2e7adcbd915
Requires -------- python3-markdown-it-py (rpmlib, GLIBC filtered): (python3.9dist(attrs) < 22 with python3.9dist(attrs) >= 19) /usr/bin/python3 python(abi)
Provides -------- python3-markdown-it-py: python-markdown-it-py python3-markdown-it-py python3.9-markdown-it-py python3.9dist(markdown-it-py) python3dist(markdown-it-py)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --copr-build 2184177 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: PHP, R, Ocaml, fonts, Haskell, C/C++, Java, SugarActivity, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1960195
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-markdown-it-py
https://bugzilla.redhat.com/show_bug.cgi?id=1960195
Karolina Surma ksurma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST
https://bugzilla.redhat.com/show_bug.cgi?id=1960195
Karolina Surma ksurma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2021-06-03 08:18:38
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com