Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: git-annex - Manage files with git, without checking their contents in
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Summary: Review Request: git-annex - Manage files with git, without checking their contents in Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mathstuf@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://benboeckel.net/packaging/git-annex/git-annex.spec SRPM URL: http://benboeckel.net/packaging/git-annex/git-annex-0.11-1.fc14.src.rpm Description: git-annex allows managing files with git, without checking the file contents into git. While that may seem paradoxical, it is useful when dealing with files larger than git can currently easily handle, whether due to limitations in memory, checksumming time, or disk space.
Even without file content tracking, being able to manage files with git, move files around and delete files with versioned directory trees, and use branches and distributed clones, are all very handy reasons to use git. And annexed files can co-exist in the same git repository with regularly versioned files, which is convenient for maintaining documents, Makefiles, etc that are associated with annexed files but that benefit from full revision control.
When a file is annexed, its content is moved into a key-value store, and a symlink is made that points to the content. These symlinks are checked into git and versioned like regular files. You can move them around, delete them, and so on. Pushing to another git repository will make git-annex there aware of the annexed file, and it can be used to retrieve its content from the key-value store.
% lintmock fedora-14-x86_64 git-annex.src: W: spelling-error %description -l en_US checksumming -> check summing, check-summing, checkmating git-annex.src: W: spelling-error %description -l en_US versioned -> version ed, version-ed, version git-annex.src: W: spelling-error %description -l en_US symlink -> sym link, sym-link, symbolic git-annex.src: W: spelling-error %description -l en_US symlinks -> sym links, sym-links, slinks git-annex.src: W: invalid-url Source0: git-annex-0.11.tar.bz2 git-annex.x86_64: W: spelling-error %description -l en_US checksumming -> check summing, check-summing, checkmating git-annex.x86_64: W: spelling-error %description -l en_US versioned -> version ed, version-ed, version git-annex.x86_64: W: spelling-error %description -l en_US symlink -> sym link, sym-link, symbolic git-annex.x86_64: W: spelling-error %description -l en_US symlinks -> sym links, sym-links, slinks git-annex.x86_64: W: spurious-executable-perm /usr/share/man/man1/git-annex.1.gz git-annex-debuginfo.x86_64: E: debuginfo-without-sources 3 packages and 0 specfiles checked; 1 errors, 10 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Ben Boeckel mathstuf@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora-haskell-list@redhat. | |com Depends on| |634037(ghc-MissingH), | |662258(ghc-pcre-light) Alias| |git-annex
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Ben Boeckel mathstuf@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |634048(Haskell-pkg-reviews)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Andrew McNabb amcnabb@mcnabbs.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |amcnabb@mcnabbs.org
Bug 662259 depends on bug 634037, which changed state.
Bug 634037 Summary: Review Request: ghc-MissingH - Large utility library https://bugzilla.redhat.com/show_bug.cgi?id=634037
What |Old Value |New Value ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA Status|ON_QA |CLOSED Resolution| |ERRATA
--- Comment #1 from Andrew McNabb amcnabb@mcnabbs.org 2011-01-26 13:40:46 EST --- Here are a few issues from the rpmlint output:
git-annex.src: W: invalid-url Source0: git-annex-0.11.tar.bz2
The Source0 needs to be a full URL, not just a filename. I can't seem to find a tarball on the git-annex website. Can you work with upstream to get them to publish a tarball for each new version?
git-annex.x86_64: W: spurious-executable-perm /usr/share/man/man1/git-annex.1.gz
This should be fixed.
git-annex-debuginfo.x86_64: E: debuginfo-without-sources
Have you tried to fix this error?
A few other issues:
1) The %description seems a little long. Most packages seem to have one or maybe two brief paragraphs.
2) This is a dumb preference, but I would slightly change the summary to "Manage files with git, without checking in their contents".
3) It looks like there have been a few version updates since the last time the spec file was updated.
4) Have you sent the patches to the Makefile upstream? By the way, it looks like the documentation is correctly installed by the Makefile in a newer version of git-annex.
5) Two of the dependencies are unavailable on Fedora 14. I can't really do anything more on this review until the ghc-pcre-light package is in.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Andrew McNabb amcnabb@mcnabbs.org changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |amcnabb@mcnabbs.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Andrew McNabb amcnabb@mcnabbs.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Ben Boeckel mathstuf@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #2 from Ben Boeckel mathstuf@gmail.com 2011-01-26 18:27:00 EST --- (In reply to comment #1)
Here are a few issues from the rpmlint output:
git-annex.src: W: invalid-url Source0: git-annex-0.11.tar.bz2
The Source0 needs to be a full URL, not just a filename. I can't seem to find a tarball on the git-annex website. Can you work with upstream to get them to publish a tarball for each new version?
I'll contact him about it. It was generated from a tag in the repository (see instructions above the URL: tag).
git-annex.x86_64: W: spurious-executable-perm /usr/share/man/man1/git-annex.1.gz
Oops.
This should be fixed.
git-annex-debuginfo.x86_64: E: debuginfo-without-sources
Have you tried to fix this error?
The -debuginfo package actually needs disabled since Haskell doesn't support it.
A few other issues:
- The %description seems a little long. Most packages seem to have one or
maybe two brief paragraphs.
Taken from the website for the most part. I'll look at trimming it down.
- This is a dumb preference, but I would slightly change the summary to
"Manage files with git, without checking in their contents".
Yeah, also taken from the website. Your wording is better. Will appear in the next version.
- It looks like there have been a few version updates since the last time the
spec file was updated.
Will appear in the next update. (I don't keep all the RR's I have 100% up-to-date, just the ones that have attention since there are sometimes a dozen updates between be initially submitting and getting a reviewer).
- Have you sent the patches to the Makefile upstream? By the way, it looks
like the documentation is correctly installed by the Makefile in a newer version of git-annex.
They've been sent and applied in some way. I think the author changed around some of them. I'll look at it more closely when I update it.
- Two of the dependencies are unavailable on Fedora 14. I can't really do
anything more on this review until the ghc-pcre-light package is in.
Hence the Blocks: field above :) . I have a local repository which I build against and has pretty much every package in the review list in it. My server has had issues since a power outage 2 or 3 weeks ago and I still haven't had a chance to look into it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|634048(Haskell-pkg-reviews) |
--- Comment #3 from Jens Petersen petersen@redhat.com 2011-01-28 06:07:24 EST --- As earlier discussed on Fedora haskell-devel list, dropping libraries for now from the toplevel of Haskell-pkg-reviews, so we, the Haskell SIG, can focus more on getting Haskell apps into Fedora.
To get you library back under the tracker please submit a bin or binlib package that depends on this library and make this bug block that package review. It is a good idea to submit full stacks of packages and then to add the toplevel program to the tracker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Ben Boeckel mathstuf@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |634048(Haskell-pkg-reviews)
--- Comment #4 from Ben Boeckel mathstuf@gmail.com 2011-01-28 10:39:59 EST --- This is a top-level package. Doesn't use cabal, but it is Haskell and a binary.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #5 from Jens Petersen petersen@redhat.com 2011-01-31 21:59:57 EST --- Sorry thanks for catching that, Ben.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Bug 662259 depends on bug 662258, which changed state.
Bug 662258 Summary: Review Request: ghc-pcre-light - A regex library for Perl 5 compatible regular expressions https://bugzilla.redhat.com/show_bug.cgi?id=662258
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |DUPLICATE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |713361
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on|662258(ghc-pcre-light) |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Bug 662259 depends on bug 713361, which changed state.
Bug 713361 Summary: Review Request: ghc-pcre-light - Haskell binding to pcre https://bugzilla.redhat.com/show_bug.cgi?id=713361
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |MODIFIED Status|MODIFIED |ON_QA Resolution| |ERRATA Status|ON_QA |CLOSED
--- Comment #6 from Jens Petersen petersen@redhat.com 2011-08-17 03:23:26 EDT --- I assume Andrew is not intending to review this?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #7 from Andrew McNabb amcnabb@mcnabbs.org 2011-08-17 10:47:22 EDT --- I originally started to, but as I got into it, all of the Haskell-specific stuff creeped me out.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #8 from Ben Boeckel mathstuf@gmail.com 2011-08-17 11:29:37 EDT --- git-annex is on Hackage now with a cabal build system, so I'll update to use it rather than the Makefile stuff sometime this week hopefully.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #9 from Jens Petersen petersen@redhat.com 2011-08-19 03:04:17 EDT --- (In reply to comment #7)
I originally started to, but as I got into it, all of the Haskell-specific stuff creeped me out.
That's ok - I was just asking yes/no? :)
Anyway not as many weird macros in non-library Cabal packages. :)
I just note in passing that the Fonts packaging macros also generate %files sections automagically for example. I haven't received any comments so far from the packaging list on the revised Haskell Guidelines.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |notready
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Wes Hardaker wjhns174@hardakers.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wjhns174@hardakers.net
--- Comment #10 from Wes Hardaker wjhns174@hardakers.net 2011-10-10 10:57:05 EDT --- FYI, thanks for working on this. I just build the package from the src.rpm and it was much easier than using cabal. I tried for a few hours to get cabal to build it like the source asks you to do, but it just wouldn't work. The src.rpm, however, worked nicely.
I think there may be a package missing in the build-requirements list as I think I had to install something to get it to work, but I lost track of what I did time-wise so couldn't tell you which package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #11 from Jens Petersen petersen@redhat.com 2011-10-16 21:39:37 EDT --- As Wes mentioned, git-annex is now in hackage with more deps...
I may try package it all unless someone else can help to do it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #12 from Wes Hardaker wjhns174@hardakers.net 2011-10-17 15:32:10 EDT --- I'd certainly like it if someone would package and maintain it (I'm swamped and am not a haskell expert myself). I would like to use it, but am not really motivated to put trust in it when it's so painful to build from scratch.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #13 from Jens Petersen petersen@redhat.com 2012-01-16 05:16:56 EST --- I'd like to see this packaged too.
Currently a good version to start with might be 3.20111211. But it still needs hS3 (-> Crypto, hxt (->...)), monad-control (-> base-unicode-symbols), and SHA.
Latest releases have further deps on lifted-base and transformers-base.
Anyway there is some work to be done to get this all ready.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |784799
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |784802
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on|784799(ghc-monad-control) |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|amcnabb@mcnabbs.org |nobody@fedoraproject.org Flag|fedora-review? |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Joey Hess joey@kitenet.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |joey@kitenet.net
Bug 662259 depends on bug 784802, which changed state.
Bug 784802 Summary: Review Request: ghc-lifted-base - Lifted IO operations from the base library https://bugzilla.redhat.com/show_bug.cgi?id=784802
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |MODIFIED Status|MODIFIED |ON_QA Resolution| |ERRATA Status|ON_QA |CLOSED
--- Comment #14 from Joey Hess joey@kitenet.net 2012-04-13 12:38:39 EDT --- Hi, I'm the author of git-annex, and appreciate your work on getting it into Fedora, since based on user feedback, this is currently one of the harder Linux distributions for users to install it to.
I'd really like to make this happen. It seems that the main issue is build dependencies. But there are some ways to work around that. git-annex's git repository has several branches that avoid most of the newer build dependencies. For building with ghc older than 7.4, there is the ghc-7.0 branch. For building without S3 (and its long chain of dependencies noted above), there is a no-s3 branch. It's also possible to avoid monad-control (which also avoids lifted-base), although currently the only branch I have that does do is the debian-stable branch. There's also a no-bloom branch omitting another recent build dependency. These all remove some features (and dropping monal-control removes some robustness in one case), but still leave a quite capable program.
I would be quite willing to put together a branch that omits any build dependencies necessary for Fedora, and maintain it for the lifetime of the Fedora release. (Not sure if I can commit to the lifetime of a Red Hat release :) Just get in touch with me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #15 from Ben Boeckel mathstuf@gmail.com 2012-04-13 12:55:55 EDT --- Fewer dependency versions sound good just for getting it into Fedora. I'll see if I can find the time to update to a snapshot with existing deps. We can tack more deps in once they're packaged.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #16 from Jens Petersen petersen@redhat.com 2012-04-14 00:09:10 EDT --- Thank you, Joe, for reaching out to us. :-)
We now have lifted-base (and monad-control) in Fedora at least. :)
I think we are gradually getting closer to being able to package the main hackage. Seems now we are still missing packages:
- bloomfilter - hS3 -> Crypto, hxt* - IfElse - SHA
So yes it is probably a good idea initially to package merging the no-S3 branch, since hxt is quite a few packages. Of course it would be nice to have S3 support in Fedora later.
Ben: do you have time to try for that?
Joe: I assume adding an S3 flag to git-annex.cabal is not practical?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #17 from Ben Boeckel mathstuf@gmail.com 2012-04-14 00:24:39 EDT --- SHA is needed in the yesod and gitit stacks anyways (though yesod has *lots* to get through yet until SHA is an issue, gitit less so), so that could be bumped up my list. IfElse and bloomfilter look easy. Sunday is probably the earliest I'll get to this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lakshminaras2002@gmail.com
--- Comment #18 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2012-04-14 05:50:11 EDT --- Bloomfilter package. https://bugzilla.redhat.com/show_bug.cgi?id=670007
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |670007(ghc-bloomfilter)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #19 from Joey Hess joey@kitenet.net 2012-04-14 14:33:47 EDT --- An S3 flag in git-annex.cabal was a good idea. That is done in git, so without the S3 library it will auto-disable S3 support now.
Glad to see bloomfilter is getting packaged. Nice thing to have available in general. :)
SHA is fairly core, I could make a branch without it, but it would lose support for encrypting content. If packaging SHA turns out to be a problem, let me know and I'll work something out. IIRC it's a fairly simple library to build.
I could easily spin a branch without IfElse (about a 4 line patch), or it should be trivial to package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|medium |high
--- Comment #20 from Jens Petersen petersen@redhat.com 2012-04-15 21:45:48 EDT --- Various people have been asking for this for a while so setting priority to High.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |812702(ghc-SHA)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #21 from Jens Petersen petersen@redhat.com 2012-04-15 22:31:45 EDT --- OK I submitted a package for SHA, so only IfElse (or patch for it) needed now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #22 from Joey Hess joey@kitenet.net 2012-04-16 16:37:37 EDT --- I have added a no-ifelse branch to git. You might find it easiest to pull it out into a srpm patch. I will be releasing the next git-annex version in 2 days (blocked on the Debian side!) with the automatic S3 disabling or you can use git.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662259
--- Comment #23 from Jens Petersen petersen@redhat.com 2012-04-17 06:07:16 EDT --- Thanks! The no-ifelse patch looks pretty simple. :)
https://github.com/joeyh/git-annex/commits/no-ifelse
package-review@lists.fedoraproject.org