[Bug 1829883] New: Review Request: legendary - Free and open-source replacement for the Epic Games Launcher
https://bugzilla.redhat.com/show_bug.cgi?id=1829883
Bug ID: 1829883 Summary: Review Request: legendary - Free and open-source replacement for the Epic Games Launcher Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: ego.cordatus@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://atim.fedorapeople.org//legendary.spec SRPM URL: https://atim.fedorapeople.org//legendary-0.0.6-1.fc32.src.rpm
Description: Legendary is an open-source game launcher that can download and install games from the Epic Games Store on Linux and Windows. It's name as a tongue-in-cheek play on tiers of item rarity in many MMORPGs.
https://bugzilla.redhat.com/show_bug.cgi?id=1829883
--- Comment #1 from Artem ego.cordatus@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43941366
https://bugzilla.redhat.com/show_bug.cgi?id=1829883
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vitaly@easycoding.org Assignee|nobody@fedoraproject.org |vitaly@easycoding.org Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #2 from Vitaly Zaitsev vitaly@easycoding.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: legendary-0.0.6-1.fc33.noarch.rpm legendary-0.0.6-1.fc33.src.rpm legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/cli.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/core.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/downloader/manager.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/downloader/workers.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/lfs/egl.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/lfs/lgndry.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/lfs/utils.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/chunk.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/downloading.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/exceptions.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/game.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/json_manifest.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/manifest.py 644 /usr/bin/env python legendary.noarch: E: zero-length /usr/lib/python3.8/site-packages/legendary/models/settings.py legendary.noarch: W: no-manual-page-for-binary legendary 2 packages and 0 specfiles checked; 14 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- legendary.noarch: W: invalid-url URL: https://github.com/derrod/legendary <urlopen error [Errno -2] Name or service not known> legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/cli.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/core.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/downloader/manager.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/downloader/workers.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/lfs/egl.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/lfs/lgndry.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/lfs/utils.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/chunk.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/downloading.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/exceptions.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/game.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/json_manifest.py 644 /usr/bin/env python legendary.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/legendary/models/manifest.py 644 /usr/bin/env python legendary.noarch: E: zero-length /usr/lib/python3.8/site-packages/legendary/models/settings.py legendary.noarch: W: no-manual-page-for-binary legendary 1 packages and 0 specfiles checked; 14 errors, 2 warnings.
Source checksums ---------------- https://github.com/derrod/legendary/archive/0.0.6/legendary-0.0.6.tar.gz : CHECKSUM(SHA256) this package : 4c612cfe85193754b6105a6d3cd4a2f733bb5bb03eb026fe77e20a7edc519e0e CHECKSUM(SHA256) upstream package : 4c612cfe85193754b6105a6d3cd4a2f733bb5bb03eb026fe77e20a7edc519e0e
Requires -------- legendary (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-requests python3.8dist(requests) python3.8dist(setuptools)
Provides -------- legendary: legendary python3.8dist(legendary-gl) python3dist(legendary-gl)
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1829883 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Ocaml, Perl, C/C++, Haskell, fonts, PHP, Java, SugarActivity, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1829883
--- Comment #3 from Vitaly Zaitsev vitaly@easycoding.org --- Please remove shebangs from Python scripts.
https://bugzilla.redhat.com/show_bug.cgi?id=1829883
--- Comment #4 from Artem ego.cordatus@gmail.com --- ☑️ rpmlint legendary-0.0.6-2.fc32.noarch.rpm legendary.noarch: W: no-manual-page-for-binary legendary 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-32...
https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-32...
https://bugzilla.redhat.com/show_bug.cgi?id=1829883
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Vitaly Zaitsev vitaly@easycoding.org --- LGTM now. Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1829883
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/legendary
https://bugzilla.redhat.com/show_bug.cgi?id=1829883
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-b7d78c82d6 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b7d78c82d6
https://bugzilla.redhat.com/show_bug.cgi?id=1829883
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2020-05-02 04:03:22
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-b7d78c82d6 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com