[Bug 1878206] New: Review Request: rust-aead - Traits for Authenticated Encryption with Associated Data (AEAD) algorithms
https://bugzilla.redhat.com/show_bug.cgi?id=1878206
Bug ID: 1878206 Summary: Review Request: rust-aead - Traits for Authenticated Encryption with Associated Data (AEAD) algorithms Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: pbrobinson@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
SPEC: https://pbrobinson.fedorapeople.org/rust-aead.spec SRPM: https://pbrobinson.fedorapeople.org/rust-aead-0.3.2-1.fc32.src.rpm
Description: Traits for Authenticated Encryption with Associated Data (AEAD) algorithms
FAS: pbrobinson koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=51225207
https://bugzilla.redhat.com/show_bug.cgi?id=1878206
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1859994 (PARSEC) Alias| |rust-aead Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1859994 [Bug 1859994] Support PARSEC
https://bugzilla.redhat.com/show_bug.cgi?id=1878206
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jsmith.fedora@gmail.com Assignee|nobody@fedoraproject.org |jsmith.fedora@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1878206
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #1 from Jared Smith jsmith.fedora@gmail.com --- Package is approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Expat License". 7 files have unknown license. Detailed output of licensecheck in /tmp/1878206-rust-aead/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- aead-devel , rust-aead+default-devel , rust-aead+alloc-devel , rust- aead+blobby-devel , rust-aead+dev-devel , rust-aead+heapless-devel , rust-aead+std-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Spec file according to URL is the same as in SRPM.
Installation errors ------------------- INFO: mock.py version 2.5 starting (python version = 3.9.0)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.5 INFO: Mock Version: 2.5 Finish: chroot init INFO: installing package(s): /tmp/1878206-rust-aead/results/rust-aead+heapless-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead+default-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead+dev-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead+alloc-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead+blobby-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead+std-devel-0.3.2-1.fc34.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /tmp/1878206-rust-aead/results/rust-aead+heapless-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead+default-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead+dev-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead+alloc-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead+blobby-devel-0.3.2-1.fc34.noarch.rpm /tmp/1878206-rust-aead/results/rust-aead+std-devel-0.3.2-1.fc34.noarch.rpm --setopt=tsflags=nocontexts
Rpmlint ------- Checking: rust-aead-devel-0.3.2-1.fc34.noarch.rpm rust-aead+default-devel-0.3.2-1.fc34.noarch.rpm rust-aead+alloc-devel-0.3.2-1.fc34.noarch.rpm rust-aead+blobby-devel-0.3.2-1.fc34.noarch.rpm rust-aead+dev-devel-0.3.2-1.fc34.noarch.rpm rust-aead+heapless-devel-0.3.2-1.fc34.noarch.rpm rust-aead+std-devel-0.3.2-1.fc34.noarch.rpm rust-aead-0.3.2-1.fc34.src.rpm rust-aead-devel.noarch: W: invalid-url URL: https://crates.io/crates/aead HTTP Error 404: Not Found rust-aead-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/aead-0.3.2/.cargo-checksum.json rust-aead+default-devel.noarch: W: spelling-error %description -l en_US aead -> ahead, read, lead rust-aead+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/aead HTTP Error 404: Not Found rust-aead+default-devel.noarch: W: no-documentation rust-aead+alloc-devel.noarch: W: spelling-error %description -l en_US alloc -> allot, alloy, allow rust-aead+alloc-devel.noarch: W: spelling-error %description -l en_US aead -> ahead, read, lead rust-aead+alloc-devel.noarch: W: invalid-url URL: https://crates.io/crates/aead HTTP Error 404: Not Found rust-aead+alloc-devel.noarch: W: no-documentation rust-aead+blobby-devel.noarch: W: spelling-error %description -l en_US blobby -> bobby, lobby, b lobby rust-aead+blobby-devel.noarch: W: spelling-error %description -l en_US aead -> ahead, read, lead rust-aead+blobby-devel.noarch: W: invalid-url URL: https://crates.io/crates/aead HTTP Error 404: Not Found rust-aead+blobby-devel.noarch: W: no-documentation rust-aead+dev-devel.noarch: W: spelling-error %description -l en_US dev -> deb, derv, div rust-aead+dev-devel.noarch: W: spelling-error %description -l en_US aead -> ahead, read, lead rust-aead+dev-devel.noarch: W: invalid-url URL: https://crates.io/crates/aead HTTP Error 404: Not Found rust-aead+dev-devel.noarch: W: no-documentation rust-aead+heapless-devel.noarch: W: spelling-error %description -l en_US heapless -> hapless, helpless, headless rust-aead+heapless-devel.noarch: W: spelling-error %description -l en_US aead -> ahead, read, lead rust-aead+heapless-devel.noarch: W: invalid-url URL: https://crates.io/crates/aead HTTP Error 404: Not Found rust-aead+heapless-devel.noarch: W: no-documentation rust-aead+std-devel.noarch: W: spelling-error %description -l en_US aead -> ahead, read, lead rust-aead+std-devel.noarch: W: invalid-url URL: https://crates.io/crates/aead HTTP Error 404: Not Found rust-aead+std-devel.noarch: W: no-documentation rust-aead.src: W: invalid-url URL: https://crates.io/crates/aead HTTP Error 404: Not Found 8 packages and 0 specfiles checked; 0 errors, 25 warnings.
Source checksums ---------------- https://crates.io/api/v1/crates/aead/0.3.2/download#/aead-0.3.2.crate : CHECKSUM(SHA256) this package : 7fc95d1bdb8e6666b2b217308eeeb09f2d6728d104be3e31916cc74d15420331 CHECKSUM(SHA256) upstream package : 7fc95d1bdb8e6666b2b217308eeeb09f2d6728d104be3e31916cc74d15420331
Requires -------- rust-aead-devel (rpmlib, GLIBC filtered): (crate(generic-array) >= 0.14.0 with crate(generic-array) < 0.15.0) cargo
rust-aead+default-devel (rpmlib, GLIBC filtered): cargo crate(aead) crate(aead/alloc)
rust-aead+alloc-devel (rpmlib, GLIBC filtered): cargo crate(aead)
rust-aead+blobby-devel (rpmlib, GLIBC filtered): (crate(blobby/default) >= 0.3.0 with crate(blobby/default) < 0.4.0) cargo crate(aead)
rust-aead+dev-devel (rpmlib, GLIBC filtered): (crate(blobby/default) >= 0.3.0 with crate(blobby/default) < 0.4.0) cargo crate(aead)
rust-aead+heapless-devel (rpmlib, GLIBC filtered): (crate(heapless/default) >= 0.5.0 with crate(heapless/default) < 0.6.0) cargo crate(aead)
rust-aead+std-devel (rpmlib, GLIBC filtered): cargo crate(aead) crate(aead/alloc)
Provides -------- rust-aead-devel: crate(aead) rust-aead-devel
rust-aead+default-devel: crate(aead/default) rust-aead+default-devel
rust-aead+alloc-devel: crate(aead/alloc) rust-aead+alloc-devel
rust-aead+blobby-devel: crate(aead/blobby) rust-aead+blobby-devel
rust-aead+dev-devel: crate(aead/dev) rust-aead+dev-devel
rust-aead+heapless-devel: crate(aead/heapless) rust-aead+heapless-devel
rust-aead+std-devel: crate(aead/std) rust-aead+std-devel
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1878206 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: fonts, C/C++, R, Python, Java, Haskell, PHP, SugarActivity, Perl, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1878206
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-aead
https://bugzilla.redhat.com/show_bug.cgi?id=1878206
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2020-09-11 16:35:01
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com