https://bugzilla.redhat.com/show_bug.cgi?id=2342678
Bug ID: 2342678 Summary: Review Request: rust-gix-merge - Git merge algorithms Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: h-k-81@hotmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://blinxen.fedorapeople.org/rust-gix-merge/rust-gix-merge.spec SRPM URL: https://blinxen.fedorapeople.org/rust-gix-merge/rust-gix-merge-0.3.0-1.fc42....
Description: A crate of the gitoxide project implementing merge algorithms.
Fedora Account System Username: blinxen
https://bugzilla.redhat.com/show_bug.cgi?id=2342678
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- There seems to be some problem with the following file. SRPM URL: https://blinxen.fedorapeople.org/rust-gix-merge/rust-gix-merge-0.3.0-1.fc42.... Fetching it results in a 403 Forbidden error. Please make sure the URL is correct and publicly available.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2342678
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |code@musicinmybrain.net Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |code@musicinmybrain.net Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2342678
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #2 from Ben Beasley code@musicinmybrain.net --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
The package is almost exactly as generated by rust2rpm; I noted two manual changes:
- Tests are disabled, with adequate justification - The heuristically-generated Summary, which was incoherent, is replaced with a proper one
Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/gix- merge-0.3.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files
This is not a serious issue and is due to reasonable design decisions in rust2rpm.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* MIT License". 36 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2342678-rust-gix- merge/licensecheck.txt [x]: License file installed when any subpackage combination is installed.
$ rpm -qL -p results/rust-gix-merge-devel-0.3.0-1.fc42.noarch.rpm /usr/share/cargo/registry/gix-merge-0.3.0/LICENSE-APACHE /usr/share/cargo/registry/gix-merge-0.3.0/LICENSE-MIT
[-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- gix-merge-devel , rust-gix-merge+default-devel , rust-gix- merge+document-features-devel , rust-gix-merge+serde-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures.
https://koji.fedoraproject.org/koji/taskinfo?taskID=128666901
[!]: %check is present and all tests pass.
Tests are disabled, with adequate justification.
[x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: rust-gix-merge-devel-0.3.0-1.fc42.noarch.rpm rust-gix-merge+default-devel-0.3.0-1.fc42.noarch.rpm rust-gix-merge+document-features-devel-0.3.0-1.fc42.noarch.rpm rust-gix-merge+serde-devel-0.3.0-1.fc42.noarch.rpm rust-gix-merge-0.3.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9lokpxbi')] checks: 32, packages: 5
rust-gix-merge+default-devel.noarch: E: spelling-error ('gitoxide', '%description -l en_US gitoxide -> git oxide, git-oxide, dioxide') rust-gix-merge+document-features-devel.noarch: E: spelling-error ('gitoxide', '%description -l en_US gitoxide -> git oxide, git-oxide, dioxide') rust-gix-merge+serde-devel.noarch: E: spelling-error ('gitoxide', '%description -l en_US gitoxide -> git oxide, git-oxide, dioxide') rust-gix-merge.src: E: spelling-error ('gitoxide', '%description -l en_US gitoxide -> git oxide, git-oxide, dioxide') rust-gix-merge-devel.noarch: E: spelling-error ('gitoxide', '%description -l en_US gitoxide -> git oxide, git-oxide, dioxide') rust-gix-merge+default-devel.noarch: W: no-documentation rust-gix-merge+document-features-devel.noarch: W: no-documentation rust-gix-merge+serde-devel.noarch: W: no-documentation 5 packages and 0 specfiles checked; 5 errors, 3 warnings, 22 filtered, 5 badness; has taken 0.3 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4
rust-gix-merge-devel.noarch: E: spelling-error ('gitoxide', '%description -l en_US gitoxide -> git oxide, git-oxide, dioxide') rust-gix-merge+default-devel.noarch: E: spelling-error ('gitoxide', '%description -l en_US gitoxide -> git oxide, git-oxide, dioxide') rust-gix-merge+serde-devel.noarch: E: spelling-error ('gitoxide', '%description -l en_US gitoxide -> git oxide, git-oxide, dioxide') rust-gix-merge+document-features-devel.noarch: E: spelling-error ('gitoxide', '%description -l en_US gitoxide -> git oxide, git-oxide, dioxide') rust-gix-merge+default-devel.noarch: W: no-documentation rust-gix-merge+serde-devel.noarch: W: no-documentation rust-gix-merge+document-features-devel.noarch: W: no-documentation 4 packages and 0 specfiles checked; 4 errors, 3 warnings, 18 filtered, 4 badness; has taken 0.1 s
Source checksums ---------------- https://crates.io/api/v1/crates/gix-merge/0.3.0/download#/gix-merge-0.3.0.cr... : CHECKSUM(SHA256) this package : 5e1aa81d68c862956ca01cf2e96d366022e2f1419253e6f64eef6a291b63ab95 CHECKSUM(SHA256) upstream package : 5e1aa81d68c862956ca01cf2e96d366022e2f1419253e6f64eef6a291b63ab95
Requires -------- rust-gix-merge-devel (rpmlib, GLIBC filtered): (crate(bstr) >= 1.5.0 with crate(bstr) < 2.0.0~) (crate(gix-command/default) >= 0.4.1 with crate(gix-command/default) < 0.5.0~) (crate(gix-diff) >= 0.50.0 with crate(gix-diff) < 0.51.0~) (crate(gix-diff/blob) >= 0.50.0 with crate(gix-diff/blob) < 0.51.0~) (crate(gix-filter/default) >= 0.17.0 with crate(gix-filter/default) < 0.18.0~) (crate(gix-fs/default) >= 0.13.0 with crate(gix-fs/default) < 0.14.0~) (crate(gix-hash/default) >= 0.16.0 with crate(gix-hash/default) < 0.17.0~) (crate(gix-index/default) >= 0.38.0 with crate(gix-index/default) < 0.39.0~) (crate(gix-object/default) >= 0.47.0 with crate(gix-object/default) < 0.48.0~) (crate(gix-path/default) >= 0.10.14 with crate(gix-path/default) < 0.11.0~) (crate(gix-quote/default) >= 0.4.15 with crate(gix-quote/default) < 0.5.0~) (crate(gix-revision) >= 0.32.0 with crate(gix-revision) < 0.33.0~) (crate(gix-revision/merge_base) >= 0.32.0 with crate(gix-revision/merge_base) < 0.33.0~) (crate(gix-revwalk/default) >= 0.18.0 with crate(gix-revwalk/default) < 0.19.0~) (crate(gix-tempfile/default) >= 16.0.0 with crate(gix-tempfile/default) < 17.0.0~) (crate(gix-trace/default) >= 0.1.12 with crate(gix-trace/default) < 0.2.0~) (crate(gix-worktree) >= 0.39.0 with crate(gix-worktree) < 0.40.0~) (crate(gix-worktree/attributes) >= 0.39.0 with crate(gix-worktree/attributes) < 0.40.0~) (crate(imara-diff/default) >= 0.1.7 with crate(imara-diff/default) < 0.2.0~) (crate(thiserror/default) >= 2.0.0 with crate(thiserror/default) < 3.0.0~) /usr/bin/bash cargo rust
rust-gix-merge+default-devel (rpmlib, GLIBC filtered): cargo crate(gix-merge)
rust-gix-merge+document-features-devel (rpmlib, GLIBC filtered): (crate(document-features/default) >= 0.2.0 with crate(document-features/default) < 0.3.0~) cargo crate(gix-merge)
rust-gix-merge+serde-devel (rpmlib, GLIBC filtered): (crate(gix-hash/serde) >= 0.16.0 with crate(gix-hash/serde) < 0.17.0~) (crate(gix-object/serde) >= 0.47.0 with crate(gix-object/serde) < 0.48.0~) (crate(serde) >= 1.0.114 with crate(serde) < 2.0.0~) (crate(serde/derive) >= 1.0.114 with crate(serde/derive) < 2.0.0~) cargo crate(gix-merge)
Provides -------- rust-gix-merge-devel: crate(gix-merge) rust-gix-merge-devel
rust-gix-merge+default-devel: crate(gix-merge/default) rust-gix-merge+default-devel
rust-gix-merge+document-features-devel: crate(gix-merge/document-features) rust-gix-merge+document-features-devel
rust-gix-merge+serde-devel: crate(gix-merge/serde) rust-gix-merge+serde-devel
Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2342678-rust-gix-merge/srpm/rust-gix-merge.spec 2025-01-30 19:14:14.117016067 -0500 +++ /home/ben/fedora/review/2342678-rust-gix-merge/srpm-unpacked/rust-gix-merge.spec 2025-01-27 19:00:00.000000000 -0500 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.7.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 27 # * Deactivate tests because of a missing dev-dependency (gix-testtools) @@ -93,3 +103,6 @@
%changelog -%autochangelog +## START: Generated by rpmautospec +* Tue Jan 28 2025 John Doe packager@example.com - 0.3.0-1 +- Uncommitted changes +## END: Generated by rpmautospec
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2342678 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Ocaml, PHP, Python, Perl, R, fonts, Haskell, SugarActivity, C/C++, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2342678
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-merge
https://bugzilla.redhat.com/show_bug.cgi?id=2342678
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-e4198f2b31 (rust-gix-merge-0.3.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-e4198f2b31
https://bugzilla.redhat.com/show_bug.cgi?id=2342678
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2025-01-31 12:22:52
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-e4198f2b31 (rust-gix-merge-0.3.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com