[Bug 823054] New: Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Summary: Review Request: php-symfony2-HttpFoundation - Symfony2
                    HttpFoundation Component
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: unspecified
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---
        Regression: ---
        Mount Type: ---
     Documentation: ---

Spec URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpFoundation...

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpFoundation...

Description:
The HttpFoundation Component defines an object-oriented layer for the HTTP
specification.

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |814994(php-channel-symfony2
                   |                            |)

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |823073

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |823075

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #1 from Shawn Iwinski  ---
Updates per comments in bug 823043

- Removed BuildRoot
- Changed php require to php-common
- Added the following requires based on phpci results:
  php-date, php-fileinfo, php-hash, php-pcre, php-session, php-sockets,
  php-spl
- Removed %defattr from %files section

SPEC URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpFoundation...

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpFoundation...

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #2 from Shawn Iwinski  ---
Update per https://bugzilla.redhat.com/show_bug.cgi?id=823041#c5

- Moved documentation to correct location

SPEC URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpFoundation...

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpFoundation...

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #3 from Shawn Iwinski  ---
Updated to upstream version 2.0.15 & updates per bug #817303

- Removed "BuildRequires: php-pear >= 1:1.4.9-1.2"
- Updated %prep section
- Removed cleaning buildroot from %install section
- Removed documentation move from %install section (fixed upstream)
- Removed %clean section
- Updated %doc in %files section

SPEC URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpFoundation...

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpFoundation...

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

--- Comment #4 from Remi Collet  ---
Created attachment 590698
  --> https://bugzilla.redhat.com/attachment.cgi?id=590698&action=edit
php-symfony2-HttpFoundation-review.txt

Generated by fedora-review 0.1.3

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

--- Comment #5 from Remi Collet  ---
In Symfony\Component\HttpFoundation\SessionStorage\PdoSessionStorage

public function __construct(\PDO $db, array $options = array(), array
$dbOptions = array())

You, you need to add "php-do" in dependency list

(this is not detected by phpci, I will report a bug upstream)

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #6 from Shawn Iwinski  ---
(In reply to comment #5)
> You, you need to add "php-do" in dependency list

Thanks Remi. I will add the "php-pdo" require after the approved import.

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #7 from Shawn Iwinski  ---
(In reply to comment #6)
> (In reply to comment #5)
> > You, you need to add "php-do" in dependency list
>
> Thanks Remi. I will add the "php-pdo" require after the approved import.

Never mind! This package is not approved yet.  I will make the change and post
the new spec and SRPM.

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #8 from Remi Collet  ---
Small note:

Extension dependencies should be described in the package.xml 
You can report this to upstream with the result of your analysis.

ex :
 <dependencies>
  <required>
   <extension>
    <name>spl</name>
   </extension>
  </required>
  <optional>
   <extension>
    <name>tokenizer</name>
   </extension>
  </optional>
 </dependencies>

pear make-rpm-spec doesn't handle this for now... one more think in my TODO
list...

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #9 from Shawn Iwinski  ---
(In reply to comment #8)
> Extension dependencies should be described in the package.xml 
> You can report this to upstream with the result of your analysis.

Thanks Remi.  I will work with upstream on this.

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #10 from Shawn Iwinski  ---
Updated per comment #5

- Added php-pdo require

SPEC URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpFoundation...

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpFoundation...

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |823066

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |823071

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #11 from Remi Collet  ---
$ diff  php-symfony2-HttpFoundation.spec.1 php-symfony2-HttpFoundation.spec
7c7
< Release:          1%{?dist}
---
> Release:          2%{?dist}

23a24
> Requires:         php-pdo

88a90,92
> Mon Jun 11 2012 Shawn Iwinski  2.0.15-2
> Added php-pdo require

Blocker fixed

== Approved ==

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #12 from Shawn Iwinski  ---
New Package SCM Request
=======================
Package Name: php-symfony2-HttpFoundation
Short Description: Symfony2 HttpFoundation Component
Owners: siwinski
Branches: f16 f17 el6
InitialCC:

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #13 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #14 from Fedora Update System  ---
php-symfony2-HttpFoundation-2.0.15-2.fc17 has been submitted as an update for
Fedora 17.
https://admin.fedoraproject.org/updates/php-symfony2-HttpFoundation-2.0.15-2...

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #15 from Fedora Update System  ---
php-symfony2-HttpFoundation-2.0.15-2.fc16 has been submitted as an update for
Fedora 16.
https://admin.fedoraproject.org/updates/php-symfony2-HttpFoundation-2.0.15-2...

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #16 from Fedora Update System  ---
php-symfony2-HttpFoundation-2.0.15-2.el6 has been submitted as an update for
Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-symfony2-HttpFoundation-2.0.15-2...

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #17 from Fedora Update System  ---
php-symfony2-HttpFoundation-2.0.15-2.fc16 has been pushed to the Fedora 16
testing repository.

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2012-06-26 17:31:12

--- Comment #18 from Fedora Update System  ---
php-symfony2-HttpFoundation-2.0.15-2.fc17 has been pushed to the Fedora 17
stable repository.

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #19 from Fedora Update System  ---
php-symfony2-HttpFoundation-2.0.15-2.fc16 has been pushed to the Fedora 16
stable repository.

[Bug 823054] Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823054

--- Comment #20 from Fedora Update System  ---
php-symfony2-HttpFoundation-2.0.15-2.el6 has been pushed to the Fedora EPEL 6
stable repository.