[Bug 1460189] New: Review Request: template-glib - A templating library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460189

Bug ID: 1460189
           Summary: Review Request: template-glib - A templating library
                    for GLib
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://declera.com/~yaneti/template-glib/template-glib.spec
SRPM URL:
http://declera.com/~yaneti/template-glib/template-glib-3.25.2-1.fc27.src.rpm
Description: Template-GLib is a templating library for GLib. It includes a
simple template format 
along with integration into GObject-Introspection for properties and methods. 
It separates the parsing of templates and the expansion of templates for faster
expansion. You can also define scope, custom functions, and more with the
embedded expression language.

Fedora Account System Username: yaneti

[Bug 1460189] Review Request: template-glib - A templating library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460189

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

--- Comment #1 from Kalev Lember  ---
Taking for review.

[Bug 1460189] Review Request: template-glib - A templating library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460189

--- Comment #2 from Kalev Lember  ---
Fedora review template-glib-3.25.2-1.fc27.src.rpm 2017-06-09

$ rpmlint template-glib-3.25.2-1.fc27.src.rpm \
          template-glib \
          template-glib-devel \
          template-glib-debuginfo
template-glib.src: W: spelling-error Summary(en_US) templating ->
contemplating, template, tempting
template-glib.src: W: spelling-error %description -l en_US templating ->
contemplating, template, tempting
template-glib.src: E: description-line-too-long C Template-GLib is a templating
library for GLib. It includes a simple template format
template-glib.src: E: description-line-too-long C It separates the parsing of
templates and the expansion of templates for faster expansion.
template-glib.src: E: description-line-too-long C You can also define scope,
custom functions, and more with the embedded expression language.
template-glib.x86_64: W: spelling-error Summary(en_US) templating ->
contemplating, template, tempting
template-glib.x86_64: W: spelling-error %description -l en_US templating ->
contemplating, template, tempting
template-glib.x86_64: E: description-line-too-long C Template-GLib is a
templating library for GLib. It includes a simple template format
template-glib.x86_64: E: description-line-too-long C It separates the parsing
of templates and the expansion of templates for faster expansion.
template-glib.x86_64: E: description-line-too-long C You can also define scope,
custom functions, and more with the embedded expression language.
template-glib.x86_64: W: shared-lib-calls-exit
/usr/lib64/libtemplate_glib-1.0.so.0.2502.0 exit@GLIBC_2.2.5
template-glib-devel.x86_64: W: only-non-binary-in-usr-lib
template-glib-devel.x86_64: E: wrong-script-interpreter
/usr/share/doc/template-glib-devel/examples/simple.py /usr/bin/env python3
template-glib-devel.x86_64: W: doc-file-dependency
/usr/share/doc/template-glib-devel/examples/simple.py /usr/bin/env
4 packages and 0 specfiles checked; 7 errors, 7 warnings.

+ OK
! needs attention

! rpmlint warns about too long description lines. Might be nice to fix that up;
the rest seems like noise and should be fine to ignore.
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (COPYING) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm

aca745c779f80a1dc9691181768aa4f77b9374646f4b37743c1c9622d266ae09a169edcf757864c435ab428319195d30e033292b81c664e04c767e5e3fe37729
 template-glib-3.25.2.tar.xz

aca745c779f80a1dc9691181768aa4f77b9374646f4b37743c1c9622d266ae09a169edcf757864c435ab428319195d30e033292b81c664e04c767e5e3fe37729
 Download/template-glib-3.25.2.tar.xz
+ The package builds in koji
(https://koji.fedoraproject.org/koji/taskinfo?taskID=19933441)
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ locale handling
+ ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
! Several directories created by the package are unowned -- I'll list them at
the end
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
+ -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8

Just two minor issues I discovered when going through the checklist above:

1) rpmlint warns about too long description lines
2) a number of directories created by the package aren't listed in %files.
should co-own those so that they correctly get removed when uninstalling the
package:

%{_libdir}/girepository-1.0
%{_datadir}/gir-1.0
%{_datadir}/gtk-doc
%{_datadir}/gtk-doc/html
%{_datadir}/vala

Beyond that looks fine to me!

[Bug 1460189] Review Request: template-glib - A templating library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460189

--- Comment #3 from Yanko Kaneti  ---
- 3.25.2-2
- Address package review issues (#1460189) - -2

Spec URL: http://declera.com/~yaneti/template-glib/template-glib.spec
SRPM URL:
http://declera.com/~yaneti/template-glib/template-glib-3.25.2-2.fc27.src.rpm

Thanks

[Bug 1460189] Review Request: template-glib - A templating library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460189

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #4 from Kalev Lember  ---
Thanks, looks good to me!

APPROVED

[Bug 1460189] Review Request: template-glib - A templating library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460189

--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/template-glib

[Bug 1460189] Review Request: template-glib - A templating library for GLib

https://bugzilla.redhat.com/show_bug.cgi?id=1460189

Yanko Kaneti  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2017-06-10 02:52:14

--- Comment #6 from Yanko Kaneti  ---
Built in rawhide

Thanks