[Bug 627223] New: Review Request: perl-File-FnMatch - Simple filename and pathname matching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-File-FnMatch - Simple filename and pathname matching
https://bugzilla.redhat.com/show_bug.cgi?id=627223
Summary: Review Request: perl-File-FnMatch - Simple filename and pathname matching Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: colin.coe@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... SRPM URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... Description: This module provides simple, shell-like pattern matching
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
--- Comment #1 from Colin Coe colin.coe@gmail.com 2010-08-26 10:22:36 EDT --- Spec URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... SRPM URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil...
[coec@bob rpmbuild]$ rpmlint SPECS/perl-File-FnMatch.spec SRPMS/perl-File-FnMatch-0.02-2.fc13.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. [coec@bob rpmbuild]
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sgallagh@redhat.com AssignedTo|nobody@fedoraproject.org |sgallagh@redhat.com Flag| |fedora-review?, | |needinfo?(colin.coe@gmail.c | |om)
--- Comment #2 from Stephen Gallagher sgallagh@redhat.com 2010-08-31 10:15:20 EDT --- Review does not pass: see below.
# MUST: rpmlint must be run on every package. The output should be posted in the review.[1] FAIL
perl-File-FnMatch.x86_64: W: private-shared-object-provides /usr/lib64/perl5/auto/File/FnMatch/FnMatch.so FnMatch.so()(64bit) 3 packages and 0 specfiles checked; 0 errors, 1 warnings. [sgallagh@sgallagh rpms]$ rpmlint -i * perl-File-FnMatch.x86_64: W: private-shared-object-provides /usr/lib64/perl5/auto/File/FnMatch/FnMatch.so FnMatch.so()(64bit) A shared object soname provides is provided by a file in a path from which other packages should not directly load shared objects from. Such shared objects should thus not be depended on and they should not result in provides in the containing package. Get rid of the provides if appropriate, for example by filtering it out during build. Note that in some cases this may require disabling rpmbuild's internal dependency generator.
3 packages and 1 specfiles checked; 0 errors, 1 warnings.
# MUST: The package must be named according to the Package Naming Guidelines . PASS
# MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . PASS
# MUST: The package must meet the Packaging Guidelines . FAIL (see rpmlint output)
# MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . PASS
# MUST: The License field in the package spec file must match the actual license. [3] PASS
# MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] N/A
# MUST: The spec file must be written in American English. [5] PASS
# MUST: The spec file for the package MUST be legible. [6] PASS
# MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. PASS
# MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7] PASS (scratch-build in Koji for Fedora 13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2437290 )
# MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [8] N/A
# MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. PASS
# MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] N/A
# MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] N/A
# MUST: Packages must NOT bundle copies of system libraries.[11] PASS
# MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [12] N/A
# MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] PASS
# MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)[14] PASS
# MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [15] PASS
# MUST: Each package must consistently use macros. [16] PASS
# MUST: The package must contain code, or permissable content. [17] PASS
# MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18] N/A
# MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [18] PASS
# MUST: Header files must be in a -devel package. [19] N/A
# MUST: Static libraries must be in a -static package. [20] N/A
# MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19] N/A
# MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [21] N/A
# MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[20] N/A
# MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [22] N/A
# MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23] PASS
# MUST: All filenames in rpm packages must be valid UTF-8. [24] PASS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
Colin Coe colin.coe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(colin.coe@gmail.c | |om) |
--- Comment #3 from Colin Coe colin.coe@gmail.com 2010-09-02 07:39:19 EDT --- [coec@bob SPECS]$ cat /etc/fedora-release Fedora release 13 (Goddard) [coec@bob SPECS]$ rpmlint perl-File-FnMatch.spec /home/coec/rpmbuild/SRPMS/perl-File-FnMatch-0.02-4.fc13.src.rpm ~/Downloads/perl-File-FnMatch-0.02-4.fc13.x86_64.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. [coec@bob SPECS]$ rpm -qp --provides ~/Downloads/perl-File-FnMatch-0.02-4.fc13.x86_64.rpm FnMatch.so()(64bit) perl(File::FnMatch) = 0.02 perl-File-FnMatch = 0.02-4.fc13 perl-File-FnMatch(x86-64) = 0.02-4.fc13 [coec@bob SPECS]$
I've updated the spec file with --- %global _use_internal_dependency_generator 0 %global __find_provides %{_rpmconfigdir}/find-provides | grep -v %{srcname} %global __find_requires %{_rpmconfigdir}/find-requires | grep -v %{srcname} --- at the beginning. rpmlint is clean but rpm -qp --provides stills shows to .so file.
Unsure how to remove this....
Spec URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... SRPM URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... RPM URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
--- Comment #4 from Colin Coe colin.coe@gmail.com 2010-09-03 11:47:39 EDT --- [coec@bob SPECS]$ rpmlint -i perl-File-FnMatch.spec ~/Downloads/perl-File-FnMatch-0.02-5.fc13.*.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings. [coec@bob SPECS]$
Spec URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... SRPM URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... RPM URLs: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil...
[coec@bob SPECS]$ rpm -qp --provides ~/Downloads/perl-File-FnMatch-0.02-5.fc13.x86_64.rpm perl(File::FnMatch) = 0.02 perl-File-FnMatch = 0.02-5.fc13 perl-File-FnMatch(x86-64) = 0.02-5.fc13 [coec@bob SPECS]$ rpm -qp --provides ~/Downloads/perl-File-FnMatch-0.02-5.fc13.i686.rpm perl(File::FnMatch) = 0.02 perl-File-FnMatch = 0.02-5.fc13 perl-File-FnMatch(x86-32) = 0.02-5.fc13 [coec@bob SPECS]$
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Stephen Gallagher sgallagh@redhat.com 2010-09-03 13:06:22 EDT --- Review passes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iarnell@gmail.com Flag|fedora-review+ |
--- Comment #6 from Iain Arnell iarnell@gmail.com 2010-09-03 13:50:43 EDT --- Clearing the review flag. Simply disabling autoprov is NOT acceptable.
Please read the perl packaging guidelines[1] (or better, the draft of the new guidelines[2]) to see how requires/provides can be selectively filtered.
[1] https://fedoraproject.org/wiki/Packaging:Perl#Filtering_Requires:_and_Provid... [2] https://fedoraproject.org/wiki/PackagingDraft:Perl#Filtering_Errant_Provides
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
--- Comment #7 from Iain Arnell iarnell@gmail.com 2010-09-03 13:53:34 EDT --- Gah! I mis-copied that second link. You really want to look at
https://fedoraproject.org/wiki/PackagingDraft:Perl#General_Case
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
--- Comment #8 from Colin Coe colin.coe@gmail.com 2010-09-06 08:27:28 EDT --- [coec@bob SPECS]$ rpm -qp --provides ~/Downloads/perl-File-FnMatch-0.02-6.fc13.x86_64.rpm perl(File::FnMatch) = 0.02 perl-File-FnMatch = 0.02-6.fc13 perl-File-FnMatch(x86-64) = 0.02-6.fc13 [coec@bob SPECS]$ rpm -qp --provides ~/Downloads/perl-File-FnMatch-0.02-6.fc13.i686.rpm perl(File::FnMatch) = 0.02 perl-File-FnMatch = 0.02-6.fc13 perl-File-FnMatch(x86-32) = 0.02-6.fc13 [coec@bob SPECS]$ rpmlint -i perl-File-FnMatch.spec \ ../SRPMS/perl-File-FnMatch-0.02-6.fc13.src.rpm \ ~/Downloads/perl-File-FnMatch-0.02-6.fc13.x86_64.rpm \ ~/Downloads/perl-File-FnMatch-0.02-6.fc13.i686.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Spec URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... SRPM URL: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... RPM URLs: http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil... http://members.iinet.net.au/~coec/RPMS_for_review/perl-File-FnMatch/perl-Fil...
Hopefully its all good now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #9 from Iain Arnell iarnell@gmail.com 2010-09-06 09:30:27 EDT --- Thank you - that's better. Restoring the approval.
But you've revealed a slight gap in our documentation (which I'm about to fix). The %{?perl_default_filter} already filters out private libs - there's no need to add your own %filter_from_provides (but it certainly doesn't hurt).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
Colin Coe colin.coe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #10 from Colin Coe colin.coe@gmail.com 2010-09-06 09:50:18 EDT --- New Package CVS Request ======================= Package Name: perl-File-FnMatch Short Description: Simple file-name and pathname matching Owners: coec Branches: F-12 F-13 F-14 EL-5 EL-6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
--- Comment #11 from Kevin Fenzi kevin@tummy.com 2010-09-06 19:44:43 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627223
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2011-02-04 11:34:15
--- Comment #12 from Iain Arnell iarnell@gmail.com 2011-02-04 11:34:15 EST --- Closing. Package has been imported and built a while back.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla