https://bugzilla.redhat.com/show_bug.cgi?id=2257063
Bug ID: 2257063 Summary: Review Request: rust-sm3 - (OSCCA GM/T 0004-2012) hash function Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/rust-sm3.spec SRPM URL: https://salimma.fedorapeople.org/rust-sm3-0.4.2-1.fc38.src.rpm
Description: SM3 (OSCCA GM/T 0004-2012) hash function.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/sm | |3 Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6868288 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |davide@cavalca.name Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |davide@cavalca.name Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #2 from Davide Cavalca davide@cavalca.name --- Taking this review
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- The rust2rpm-generated Summary is a bit weird, it drops SM3 from the start which is not really good here.
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #4 from Davide Cavalca davide@cavalca.name --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
I agree with Fabio, please fix the summary on import. Besides that, it's APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sm3
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
--- Comment #6 from Michel Lind michel@michel-slm.name --- (In reply to Fabio Valentini from comment #3)
The rust2rpm-generated Summary is a bit weird, it drops SM3 from the start which is not really good here.
Huh, yeah. Will fix. Is this a rust2rpm issue?
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-28835fd54d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-28835fd54d
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-16a9ae4035 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-16a9ae4035
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-28835fd54d has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-28835fd54d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-28835fd54d
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-16a9ae4035 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-16a9ae4035` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-16a9ae4035
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2024-01-09 01:45:59
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-28835fd54d has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2257063
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-16a9ae4035 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com