[Bug 204164] New: Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204164

Summary: Review Request: perl-LWP-Authen-Wsse - Library for
                    enabling X-WSSE authentication in LWP
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-LWP-Authen-Wsse.sp...
SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-LWP-Authen-Wsse-0....
Description:

LWP::Authen::Wsse allows LWP to authenticate against servers that are 
using the X-WSSE authentication scheme, as required by the Atom 
Authentication API.

[Bug 204164] Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204164

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-09-02 00:42 EST -------
This fails to build for me due to failing tests; I added a BR:
perl(Digest::SHA1) and things are fine.  I'll work up a review.

[Bug 204164] Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204164

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-09-02 15:32 EST -------
I'll assume that the BuildRequires: perl(Digest::SHA1) is added to the spec for
the purposes of this review.

* source files match upstream:
   d611b72884406ed92b7920be76bb3a94  LWP-Authen-Wsse-0.05.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
O BuildRequires are proper (BR: perl is not necessary; assuming BR:
perl(Digest::SHA1) is there).
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(LWP::Authen::Wsse)
   perl-LWP-Authen-Wsse = 0.05-1.fc6
  =
   perl >= 0:5.004
   perl(:MODULE_COMPAT_5.8.8)
   perl(Digest::SHA1)
   perl(English)
   perl(MIME::Base64)
   perl(constant)
   perl(strict)
   perl(warnings)
* %check is present and the single test passes:
   All tests successful.
   Files=1, Tests=1,  0 wallclock secs ( 0.01 cusr +  0.02 csys =  0.03 CPU)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.

APPROVED, assuming you add that missing BR.

[Bug 204164] Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204164

------- Additional Comments From [e-mail]  2006-09-05 17:32 EST -------
I have
- Add BuildRequires perl(Digest::SHA1) perl(MIME::Base64) 
in the package I have just imported.

Thanks for the review. I'll build it and close the bug when the
buildsys becomes more responsive...

[Bug 204164] Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204164

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 204164] Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-LWP-Authen-Wsse - Library for enabling X-WSSE authentication in LWP

https://bugzilla.redhat.com/show_bug.cgi?id=204164

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide