https://bugzilla.redhat.com/show_bug.cgi?id=1119158
Bug ID: 1119158 Summary: Review Request: perl-URL-Encode - Encoding and decoding of application/x-www-form-urlencoded encoding Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: i@cicku.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://us-la.cicku.me/perl-URL-Encode.spec SRPM URL: http://us-la.cicku.me/perl-URL-Encode-0.03-1.fc22.src.rpm Description: This module provides functions to encode and decode strings into and from the application/x-www-form-urlencoded encoding. Fedora Account System Username: cicku
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1119118
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1119118 [Bug 1119118] Review Request: perl-App-Netdisco - Web-based network management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1119164
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1119164 [Bug 1119164] Review Request: perl-URL-Encode-XS - XS implementation of URL::Encode
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
--- Comment #1 from Petr Šabata psabata@redhat.com --- TODO: Raise the minimum EE::MM version requirement to 6.76
TODO: Remove the extra Carp runtime dependency. This is always autodetected.
FIX: Missing a builddep for t/* - utf8
FIX: Missing lots of builddeps for the bundled Module::Install -- base, Config, Cwd, ExtUtils::MM_Unix, Fcntl, File::Find, File::Path, Pod::Text, vars
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
--- Comment #2 from Christopher Meng i@cicku.me --- (In reply to Petr Šabata from comment #1)
FIX: Missing lots of builddeps for the bundled Module::Install -- base, Config, Cwd, ExtUtils::MM_Unix, Fcntl, File::Find, File::Path, Pod::Text, vars
Question, will this be absorbed by guideline? IMO these are not important or should the building environment auto detect these? Since Module::Install is often bundled.
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
--- Comment #3 from Petr Šabata psabata@redhat.com --- (In reply to Christopher Meng from comment #2)
(In reply to Petr Šabata from comment #1)
FIX: Missing lots of builddeps for the bundled Module::Install -- base, Config, Cwd, ExtUtils::MM_Unix, Fcntl, File::Find, File::Path, Pod::Text, vars
Question, will this be absorbed by guideline? IMO these are not important or should the building environment auto detect these? Since Module::Install is often bundled.
The reason for listing those is exactly the same as listing any other. The module is used at build time and it has these dependencies. Bundled modules (if used for build only) are no special case.
If you don't feel like going through the inc/ directory, one way to deal with this is removing it, dropping it from MANIFEST and BR'ing inc::Module::Install. However, given this may change how your package gets built, you may want to stick with just checking inc for dependencies, too. It's not that much work, really.
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
David Dick ddick@cpan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|1119164 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1119164 [Bug 1119164] Review Request: perl-URL-Encode-XS - XS implementation of URL::Encode
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
David Dick ddick@cpan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1181321
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1181321 [Bug 1181321] Review Request: URL-Encode-XS - XS implementation of URL::Encode
https://bugzilla.redhat.com/show_bug.cgi?id=1119158 Bug 1119158 depends on bug 1181321, which changed state.
Bug 1181321 Summary: Review Request: perl-URL-Encode-XS - XS implementation of URL::Encode https://bugzilla.redhat.com/show_bug.cgi?id=1181321
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i@cicku.me Flags| |needinfo?(i@cicku.me)
--- Comment #4 from Petr Šabata psabata@redhat.com --- Ping. Any updates, Christopher?
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
--- Comment #5 from Petr Šabata psabata@redhat.com --- Another ping. Are you still interested in packaging this?
https://bugzilla.redhat.com/show_bug.cgi?id=1119158
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed| |2015-07-02 11:40:36
--- Comment #6 from Petr Šabata psabata@redhat.com --- Dead review. Closing.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org