[Bug 1495293] New: Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Bug ID: 1495293
           Summary: Review Request: python-Naked - A command line
                    application framework
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://fedorapeople.org/~greghellings/python-Naked/python-Naked.spec
SRPM URL:
https://fedorapeople.org/~greghellings/python-Naked/python-Naked-0.1.31-1.fc...
Description: Naked is a new Python command line application framework that
makes creating command line options and sub-commands simpler.
Fedora Account System Username: greghellings

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Clint Savage  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Clint Savage  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

--- Comment #1 from Clint Savage  ---
Created attachment 1331164
  --> https://bugzilla.redhat.com/attachment.cgi?id=1331164&action=edit
rpmlint.txt from fedora-review

rpmlint errors

rpmlint gives a really long list of errors. I reviewed them, and even built the
package against mock.

- The description is definitely too long, could be trimmed.
- Maybe the non-executable-script errors should be give execution permissions?
- not sure about the wrong-script-interpreter error, maybe other wsgi apps
could help?

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

--- Comment #2 from [e-mail] ---
The description was fine, but the line length was obscene. I've added line
breaks and now it's recording OK.

The non-executable scripts should have their spurious shebang lines removed,
which I've done. It also addresses the wrong-script-interpreter issue as well.
I've simply deleted the line from the top of the offending files.

New spec file:
https://fedorapeople.org/~greghellings/python-Naked/python-Naked.spec
New SRPM:
https://fedorapeople.org/~greghellings/python-Naked/python-Naked-0.1.31-2.fc...

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Clint Savage  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Attachment|                            |review+
     #1383081 Flags|                            |

--- Comment #3 from Clint Savage  ---
Created attachment 1383081
  --> https://bugzilla.redhat.com/attachment.cgi?id=1383081&action=edit
fedora-review results (review.txt) 20180118

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

--- Comment #4 from Clint Savage  ---
I think all of my concerns from above were met. I noted a few nits in the
attached review.txt, but nothing preventing approval.

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review+              |

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

--- Comment #5 from [e-mail] ---
@Clint - You need to set the fedora-review flag to "+". I tried to update it
myself, but the repo creation tool checks that, and won't allow me to set it on
my own request (I should have realized that...). If you can set that, I can
move forward with closing this one out.

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Clint Savage  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]            |[e-mail]

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-Naked. You may commit to the branch
"f27" in about 10 minutes.

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

--- Comment #7 from Fedora Update System  ---
python-Naked-0.1.31-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-472ea01f77

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #8 from Fedora Update System  ---
python-Naked-0.1.31-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-472ea01f77

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

--- Comment #9 from Fedora Update System  ---
python-Naked-0.1.31-3.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-91d06f2add

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |MODIFIED

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #10 from Fedora Update System  ---
python-Naked-0.1.31-3.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-91d06f2add

[Bug 1495293] Review Request: python-Naked - A command line application framework

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2018-03-06 12:19:27

--- Comment #11 from Fedora Update System  ---
python-Naked-0.1.31-3.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.