Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189609
Summary: Review Request: galago-daemon Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: bdpepple@ameritech.net QAContact: fedora-package-review@redhat.com
Spec URL: http://piedmont.homelinux.org/fedora/galago/galago-daemon.spec SRPM URL: http://piedmont.homelinux.org/fedora/galago/galago-daemon-0.5.0-1.src.rpm Description: The Galago presence daemon, which is the center of all presence transactions for Galago. This service is automatically launched by D-BUS when needed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: galago-daemon
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189609
bdpepple@ameritech.net changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |189603
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: galago-daemon
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189609
Bug 189609 depends on bug 189603, which changed state.
Bug 189603 Summary: Review Request: libgalago https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189603
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: galago-daemon
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189609
------- Additional Comments From jpmahowald@gmail.com 2006-05-17 16:11 EST ------- - rpmlint checks return: W: galago-daemon non-conffile-in-etc /etc/dbus-1/system.d/galago-daemon.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.
W: galago-daemon non-standard-dir-in-usr libexec Non standard but not without precedent. I'm inclined to ignore.
- package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC5 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: galago-daemon
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189609
jpmahowald@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |jpmahowald@gmail.com OtherBugsDependingO|163776 |163779 nThis| |
------- Additional Comments From jpmahowald@gmail.com 2006-05-17 16:13 EST ------- - rpmlint checks return: W: galago-daemon non-conffile-in-etc /etc/dbus-1/system.d/galago-daemon.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.
W: galago-daemon non-standard-dir-in-usr libexec Non standard but not without precedent. I'm inclined to ignore.
- package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC5 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
Mark the config file as %config
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: galago-daemon
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189609
bdpepple@ameritech.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From bdpepple@ameritech.net 2006-05-19 12:20 EST ------- Packages built for FC5 & Devel. Thanks for the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: galago-daemon
https://bugzilla.redhat.com/show_bug.cgi?id=189609
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org