[Bug 2059386] New: Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

Bug ID: 2059386
           Summary: Review Request: vsomeip3 - COVESA implementation of
                    SOME/IP protocol
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://smooge.fedorapeople.org/automotive_sig_packages/vsomeip3/SPECS/vsome...
SRPM URL:
https://smooge.fedorapeople.org/automotive_sig_packages/vsomeip3/RPMS/vsomei...
Description: The vsomeip stack implements the http://some-ip.com/ (Scalable
service-Oriented MiddlewarE over IP (SOME/IP)) protocol. 
Fedora Account System Username: smooge

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

Alexander Larsson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

Alexander Larsson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

--- Comment #1 from Alexander Larsson  ---
Is there a particular reason why the %doc:s are duplicated for each subpackage?

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

--- Comment #2 from Alexander Larsson  ---
Review:

It seems part of the source is under the "Boost" license (see LICENSE_boost)
file, so this should be added to %license.

We're missing a "%license LICENSE LICENSE_boost" line

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

--- Comment #3 from Alexander Larsson  ---
Eh, i meant added to "License:", not "%license"

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

--- Comment #4 from Alexander Larsson  ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text
- systemd_post is invoked in %post, systemd_preun in %preun, and
  systemd_postun in %postun for Systemd service files.
  Note: Systemd service file(s) in vsomeip3-routingmanager
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Scriptlets/#_scriptlets

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Mozilla Public License 2.0", "*No
     copyright* Mozilla Public License 2.0", "*No copyright* Boost Software
     License 1.0", "Boost Software License 1.0". 171 files have unknown
     license. Detailed output of licensecheck in
     /home/alex/rpmbuild/SPECS/2059386-vsomeip3/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/systemd/syste,m
     /usr/lib/systemd
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 501760 bytes in 35 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     vsomeip3-devel , vsomeip3-routingmanager , vsomeip3-examples ,
     vsomeip3-tools , vsomeip3-compat , vsomeip3-compat-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Scriptlets must be sane, if used.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Cannot parse rpmlint output:

Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:

Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:

Source checksums
----------------
https://github.com/COVESA/vsomeip/archive/3.1.20.3/vsomeip-3.1.20.3.tar.gz :
  CHECKSUM(SHA256) this package     :
56ba4103e7e92ab2f5597d4fee9827f26698c30618faa5e74793a812a76f3c2c
  CHECKSUM(SHA256) upstream package :
56ba4103e7e92ab2f5597d4fee9827f26698c30618faa5e74793a812a76f3c2c

Requires
--------
vsomeip3 (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libboost_filesystem.so.1.76.0()(64bit)
    libboost_thread.so.1.76.0()(64bit)
    libc.so.6()(64bit)
    libdlt.so.2()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgcc_s.so.1(GCC_3.4)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.13)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libsystemd.so.0()(64bit)
    libsystemd.so.0(LIBSYSTEMD_209)(64bit)
    libvsomeip3.so.3()(64bit)
    rtld(GNU_HASH)

vsomeip3-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    cmake-filesystem(x86-64)
    libvsomeip3-cfg.so.3()(64bit)
    libvsomeip3-e2e.so.3()(64bit)
    libvsomeip3-sd.so.3()(64bit)
    libvsomeip3.so.3()(64bit)
    vsomeip3(x86-64)

vsomeip3-routingmanager (rpmlib, GLIBC filtered):
    /bin/sh
    libc.so.6()(64bit)
    libdlt.so.2()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libvsomeip3.so.3()(64bit)
    rtld(GNU_HASH)
    shadow-utils
    vsomeip3(x86-64)

vsomeip3-examples (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libvsomeip3.so.3()(64bit)
    rtld(GNU_HASH)
    vsomeip3(x86-64)

vsomeip3-tools (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libvsomeip3.so.3()(64bit)
    rtld(GNU_HASH)
    vsomeip3(x86-64)

vsomeip3-compat (rpmlib, GLIBC filtered):
    libboost_thread.so.1.76.0()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libvsomeip3.so.3()(64bit)
    rtld(GNU_HASH)
    vsomeip3(x86-64)

vsomeip3-compat-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    cmake-filesystem(x86-64)
    libvsomeip.so.2()(64bit)
    vsomeip3-compat(x86-64)

vsomeip3-debuginfo (rpmlib, GLIBC filtered):

vsomeip3-debugsource (rpmlib, GLIBC filtered):

Provides
--------
vsomeip3:
    libvsomeip3-cfg.so.3()(64bit)
    libvsomeip3-e2e.so.3()(64bit)
    libvsomeip3-sd.so.3()(64bit)
    libvsomeip3.so.3()(64bit)
    vsomeip3
    vsomeip3(x86-64)

vsomeip3-devel:
    cmake(vsomeip3)
    pkgconfig(vsomeip3)
    vsomeip3-devel
    vsomeip3-devel(x86-64)

vsomeip3-routingmanager:
    vsomeip3-routingmanager
    vsomeip3-routingmanager(x86-64)

vsomeip3-examples:
    vsomeip3-examples
    vsomeip3-examples(x86-64)

vsomeip3-tools:
    vsomeip3-tools
    vsomeip3-tools(x86-64)

vsomeip3-compat:
    libvsomeip.so.2()(64bit)
    vsomeip3-compat
    vsomeip3-compat(x86-64)

vsomeip3-compat-devel:
    cmake(vsomeip)
    pkgconfig(vsomeip)
    vsomeip3-compat-devel
    vsomeip3-compat-devel(x86-64)

vsomeip3-debuginfo:
    debuginfo(build-id)
    libvsomeip3-cfg.so.3.1.20-3.1.20.3-1.fc37.x86_64.debug()(64bit)
    libvsomeip3-e2e.so.3.1.20-3.1.20.3-1.fc37.x86_64.debug()(64bit)
    libvsomeip3-sd.so.3.1.20-3.1.20.3-1.fc37.x86_64.debug()(64bit)
    libvsomeip3.so.3.1.20-3.1.20.3-1.fc37.x86_64.debug()(64bit)
    vsomeip3-debuginfo
    vsomeip3-debuginfo(x86-64)

vsomeip3-debugsource:
    vsomeip3-debugsource
    vsomeip3-debugsource(x86-64)

Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 2059386
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: PHP, Haskell, fonts, R, Ocaml, Python, Java, Perl,
SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

--- Comment #5 from Alexander Larsson  ---
For the failures, other than what I mentioned already:

%{unitdir} etc ownership. This could be fixed by adding a dependency on systemd
from the routingmanager subpackage. But that feels weird. One could conceivably
want to use the routing manager without systemd. I dunno what the status is
here? Do we just add the %dir?

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

--- Comment #6 from Alexander Larsson  ---
I also noticed some docs that said:

Please note that in order for the %{_unitdir} macro to exist, your package
must have:
 BuildRequires: systemd

So, maybe we should have this (as we use %{_unitdir}).

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

Stephen John Smoogen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #7 from Stephen John Smoogen  ---
I have updated items to
https://smooge.fedorapeople.org/automotive_sig_packages/vsomeip3/RPMS/ and
https://smooge.fedorapeople.org/automotive_sig_packages/vsomeip3/SPECS/vsome...

vsomeip3-3.1.20.3-2.fc35.src.rpm

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

--- Comment #8 from Alexander Larsson  ---
Oh, I see  we already build-require systemd-devel, so maybe we don't need
systemd explicitly then.

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

Alexander Larsson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

--- Comment #9 from Alexander Larsson  ---
Still, looks good enough to me.

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

--- Comment #10 from Stephen John Smoogen  ---
It was because of 'License file installed when any subpackage combination is
installed.' which is now fixed with %license in every file. Will clean up and
then make a fedpkg request-repo.

[Bug 2059386] Review Request: vsomeip3 - COVESA implementation of SOME/IP protocol

https://bugzilla.redhat.com/show_bug.cgi?id=2059386

--- Comment #11 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/vsomeip3