[Bug 436777] New: Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=436777

Summary: Review Request: python-tgcaptcha - A TurboGears CAPTCHA
                    widget for forms
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://lmacken.fedorapeople.org/rpms/python-tgcaptcha.spec
SRPM URL: http://lmacken.fedorapeople.org/rpms/python-tgcaptcha-0.11-1.fc8.src.rpm
Description:
TGCaptcha is a TurboGears widget that provides an easy way to incorporate a captcha as part a form in an attempt to reduce spam or malicious activity.

[Bug 436777] Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

https://bugzilla.redhat.com/show_bug.cgi?id=436777

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2008-03-11 00:59 EST -------
got build error
ImportError: No module named cherrypy
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=510156

also rpmlint complained =>
python-tgcaptcha.src: E: description-line-too-long TGCaptcha is a TurboGears
widget that provides an easy way to incorporate a captcha as part a form in an
attempt to reduce spam or malicious activity.

python-tgcaptcha.i386: E: script-without-shebang
/usr/lib/python2.5/site-packages/tgcaptcha/static/fonts/tuffy/LICENSE.txt

python-tgcaptcha.i386: E: no-binary

[Bug 436777] Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

https://bugzilla.redhat.com/show_bug.cgi?id=436777

------- Additional Comments From [e-mail]  2008-03-11 17:34 EST -------
The build issue should be fixed thanks to the following patch that I just
applied to TurboGears in devel:
http://cvs.fedoraproject.org/viewcvs/devel/TurboGears/TurboGears-1.0.4.4-che...

* Tue Mar 11 2008 Luke Macken  0.11-2
- Make package noarch
- Fix lengthy description
- Remove the executable bit from the fonts

http://lmacken.fedorapeople.org/rpms/python-tgcaptcha-0.11-2.fc8.src.rpm
http://lmacken.fedorapeople.org/rpms/python-tgcaptcha.spec

[Bug 436777] Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

https://bugzilla.redhat.com/show_bug.cgi?id=436777

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-03-12 03:14 EST -------
Review:
+ package builds in mock.
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=512432 
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
08e52f7055d2f1084d225d910f637420  TGCaptcha-0.11.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI App.

Also,
1)remove BR:python as python-devel anyway pulls it.

APPROVED.

[Bug 436777] Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

https://bugzilla.redhat.com/show_bug.cgi?id=436777

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-03-12 10:34 EST -------
New Package CVS Request
=======================
Package Name: python-tgcaptcha
Short Description: A TurboGears CAPTCHA widget for forms
Owners: lmacken
Branches: EL-5 F-7 F-8
Cvsextras Commits: Yes

[Bug 436777] Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

https://bugzilla.redhat.com/show_bug.cgi?id=436777

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-03-12 13:22 EST -------
cvs done.

[Bug 436777] Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

https://bugzilla.redhat.com/show_bug.cgi?id=436777

------- Additional Comments From [e-mail]  2008-03-31 02:00 EST -------
almost more than 15 days passed. Is this built for requested branches so that we
can CLOSE this review?

[Bug 436777] Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

https://bugzilla.redhat.com/show_bug.cgi?id=436777

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-03-31 07:12 EST -------
Ah, yes.  This has been built and releases as updates for F-7 and F-8.  Thanks!