[Bug 285551] New: Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=285551

Summary: Review Request: idw-gpl - Java Swing based docking
                    windows framework
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://jjames.fedorapeople.org/idw-gpl/idw-gpl.spec
SRPM URL: http://jjames.fedorapeople.org/idw-gpl/idw-gpl-1.5.0-1.src.rpm
Description: InfoNode Docking Windows is a Java Swing based docking windows framework.  It also includes a highly flexible tabbed panel component and a slim Swing look and feel.

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

------- Additional Comments From [e-mail]  2007-11-14 19:06 EST -------
My approach to fixing the use of an internal Sun class doesn't work for IcedTea.
 Here is a version that works with both gcj and IcedTea, and also fixes a few
other minor issues that turned up on F8.

Spec: http://jjames.fedorapeople.org/idw-gpl/idw-gpl.spec
SRPM: http://jjames.fedorapeople.org/idw-gpl/idw-gpl-1.5.0-2.src.rpm

This package is a precursor to getting findbugs into Fedora.

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

------- Additional Comments From [e-mail]  2008-04-18 17:34 EST -------
Here are new versions that reflect the recently released Java packaging guidelines.

Spec: http://jjames.fedorapeople.org/idw-gpl/idw-gpl.spec
SRPM: http://jjames.fedorapeople.org/idw-gpl/idw-gpl-1.5.0-3.src.rpm

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED

------- Additional Comments From [e-mail]  2008-05-01 12:17 EST -------
I'll take this.

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

------- Additional Comments From [e-mail]  2008-05-01 14:50 EST -------
Hi Jerry.  Things look great.  I only have a few questions.

? = maybe or a question I have
OK = okay (surprisingly)
X = please fix

? license field matches the actual license.
  - it looks like they don't specify a version of the GPL.  Is "v2+"
    what we should assume here?
? Can you copy or move the comments about the patches to above the Patch
  lines?  Have you considered offering them to upstream?
? Have you compared the JAR we get with the upstream one?
? (pedantic) in Summary:  "Java Swing based" -> "Java Swing-based"
OK rpmlint on srpm
  idw-gpl.src: W: non-standard-group Development/Libraries/Java
  Don't worry about this.
? consider using cp -p to preserve timestamps
X in %files, change %{_javadir}/*.jar to %{_javadir}/%{name}* (or %{name}*.jar)
X in %files javadoc, change %{_javadocdir}/* to
  %{_javadocdir}/%{name}*
OK - the final provides and requires of the binary RPMs look fine
OK - run rpmlint on the binary RPMs
   idw-gpl.i386: W: non-standard-group Development/Libraries/Java
   idw-gpl-javadoc.i386: W: non-standard-group Development/Libraries/Java
  Don't worry about these.

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

------- Additional Comments From [e-mail]  2008-05-01 19:11 EST -------
Andrew, thanks for taking a look.  Here are my answers to the questions.
- License field: the actual Java source files all contain the "or (at your
option) any later version" clause in the headers, so that's why I went with GPLv2+.
- I sent the patches upstream months ago.  They told me they would like to apply
them all to their code base, and asked me to assign copyright to them.  I did. 
Time has passed, and they have not released a new version or communicated with
me again.  I moved the comments as requested.
- I have not compared this jar with upstream, good point.  It's a good thing you
asked me to do that, as I failed to package up some .png files.  The jar
produced by this spec file is still not identical to upstream, but the
differences are now cosmetic only.
- I changed "Swing based" to "Swing-based" in the Summary and description.
- The spec file now uses cp -p.
- I changed the two %files patterns.

Also, the conditional GCJ parts weren't in the guidelines when I made this
package.  I have added those.  Here's the latest version:

Spec: http://jjames.fedorapeople.org/idw-gpl/idw-gpl.spec
SRPM: http://jjames.fedorapeople.org/idw-gpl/idw-gpl-1.5.0-4.src.rpm

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

------- Additional Comments From [e-mail]  2008-05-02 10:33 EST -------
Thanks, Jerry.  Everything looks good.

I'm sorry I didn't think of this yesterday, but do you think we should add
Provides statements for ilf-gpl and itp-gpl?  Since we're packaging the LAF and
the tabbed panel all in this one RPM, I think virtual Provides are in order. 
What do you think?

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

------- Additional Comments From [e-mail]  2008-05-05 18:04 EST -------
Good point.  I wondered whether I should package all 3 up separately, in fact,
but then decided that since the upstream idw-gpl source package contained
everything, I should just make one package.  Here are new versions with the
virtual provides:

Spec: http://jjames.fedorapeople.org/idw-gpl/idw-gpl.spec
SRPM: http://jjames.fedorapeople.org/idw-gpl/idw-gpl-1.5.0-5.src.rpm

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2008-05-06 09:20 EST -------
That looks good to me.  Thanks for all your hard work.

APPROVED.

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-05-06 12:14 EST -------
New Package CVS Request
=======================
Package Name: idw-gpl
Short Description: A Java Swing-based docking windows framework
Owners: jjames
Branches: F-8 F-9
InitialCC: 
Cvsextras Commits: yes

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-05-06 16:53 EST -------
cvs done.

[Bug 285551] Review Request: idw-gpl - Java Swing based docking windows framework

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: idw-gpl - Java Swing based docking windows framework

https://bugzilla.redhat.com/show_bug.cgi?id=285551

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE