Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-amqplib - Client library for AMQP
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Summary: Review Request: python-amqplib - Client library for AMQP Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fabian@bernewireless.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-amqplib.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-amqplib-0.6.1-1.fc13.src.r...
Project URL: http://pypi.python.org/pypi/amqplib
Description: Client library for AMQP (Advanced Message Queuing Protocol)
Supports the 0-8 AMQP spec, and has been tested with RabbitMQ and Python's 2.4, 2.5, and 2.6
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2291864
rpmlint output: [fab@laptop011 SRPMS]$ rpmlint python-amqplib-0.6.1-1.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[fab@laptop011 noarch]$ rpmlint python-amqplib-0.6.1-1.fc13.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |611277
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |611054
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Tavis Aitken tavisto@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tavisto@gmail.com
--- Comment #1 from Tavis Aitken tavisto@gmail.com 2010-08-21 16:25:57 EDT --- Is anyone still paying attention to this? I would by happy to help. I was about to submit this myself if no one had already done so.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
--- Comment #2 from Fabian Affolter fabian@bernewireless.net 2010-08-30 14:56:26 EDT --- The review flag is not set. I guess that at the moment nobody is doing a review for this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Silas Sewell silas@sewell.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |silas@sewell.ch
--- Comment #3 from Silas Sewell silas@sewell.ch 2010-09-01 11:55:52 EDT --- Just an fyi, it looks like you need to add "python-nose" to the buildrequires.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Ruediger Landmann r.landmann@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |r.landmann@redhat.com AssignedTo|nobody@fedoraproject.org |r.landmann@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Ruediger Landmann r.landmann@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |needinfo?(fabian@bernewirel | |ess.net)
--- Comment #4 from Ruediger Landmann r.landmann@redhat.com 2010-10-29 17:42:07 EDT --- Hi Fabian --
As Silas said in comment #3, you need to include python-nose as a build dependency; other than that, the package looks good to me. Fix that, and we're good to go.
- = N/A / = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [/] Rpmlint output is clean: $ rpmlint SPECS/python-amqplib.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/python-amqplib-0.6.1-1.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/noarch/python-amqplib-0.6.1-1.fc13.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [/] Package is named according to the Package Naming Guidelines. python-$NAME [/] Spec file name must match the base package %{name}, in the format %{name}.spec. [/] Package meets the Packaging Guidelines including the Language specific items [/] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [/] License field in the package spec file matches the actual license. License type: LGPLv2+ [/] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. LICENSE [/] Spec file is legible and written in American English. [/] Sources used to build the package matches the upstream source, as provided in the spec URL. (md5sum b2f6679b27eaae97c50a9c3504154fae) [/] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2563289 ***works with build dep corrected*** [/] Package is not known to require ExcludeArch [!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. python-nose missing [-] The spec file handles locales properly (with the %find_lang macro) [-] ldconfig called in %post and %postun if required. [/] Package does not bundle copies of system libraries [/] Package is not relocatable. [/] Package must own all directories that it creates. [/] Package does not contain duplicates in %files. [/] Permissions on files are set properly [/] %files section includes a %defattr(...) line [/] Package consistently uses macros. [-] Large documentation files are in a -doc subpackage, if required. [/] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [-] Development .so files in -devel subpackage, if present. [-] -devel packages require base package with full versioning. [/] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [/] Package does not own files or directories owned by other packages. [/] Filenames are valid UTF-8
=== SUGGESTED ITEMS ===
[/] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [/] Reviewer should test that the package builds in mock. Tested through koji [/] Package should compile and build into binary rpms on all supported architectures. Tested on: f13 [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] Subpackages other than -devel require the base package as a fully versioned dependency [-] The placement of pkgconfig(.pc) files is correct (normally in -devel) [-] File based requires are sane. [-] Package contains man pages for binaries and scripts.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(fabian@bernewirel | |ess.net) |
--- Comment #5 from Fabian Affolter fabian@bernewireless.net 2010-11-01 19:31:48 EDT --- Thanks for the review.
Here are the updated file: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-amqplib.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-amqplib-0.6.1-2.fc14.src.r...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Ruediger Landmann r.landmann@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Ruediger Landmann r.landmann@redhat.com 2010-11-02 02:14:16 EDT --- Thanks Fabian: ACCEPT
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Fabian Affolter fabian@bernewireless.net 2010-11-05 07:31:01 EDT --- New Package SCM Request ======================= Package Name: python-amqplib Short Description: Client library for AMQP Owners: fab Branches: F-14 F-13 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
--- Comment #8 from Jason Tibbitts tibbs@math.uh.edu 2010-11-05 13:18:19 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-11-06 13:16:08 EDT --- python-amqplib-0.6.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/python-amqplib-0.6.1-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-11-06 13:16:15 EDT --- python-amqplib-0.6.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/python-amqplib-0.6.1-2.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-11-06 19:43:45 EDT --- python-amqplib-0.6.1-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-amqplib'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-amqplib-0.6.1-2.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |python-amqplib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-11-17 18:22:27 EST --- python-amqplib-0.6.1-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-amqplib-0.6.1-2.fc14 Resolution| |ERRATA Last Closed| |2010-11-17 18:22:32
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-11-17 18:28:59 EST --- python-amqplib-0.6.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-amqplib-0.6.1-2.fc14 |python-amqplib-0.6.1-2.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Brian Pepple bdpepple@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bdpepple@gmail.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #14 from Brian Pepple bdpepple@gmail.com 2011-02-02 20:51:39 EST --- Package Change Request ====================== Package Name: python-amqplib New Branches: el6 Owners: bar bpepple
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
--- Comment #15 from Kevin Fenzi kevin@tummy.com 2011-02-03 15:14:26 EST --- Is user 'bar' really one you want here?
Also, does the fedora maintainer not wish to maintain in epel?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
--- Comment #16 from Brian Pepple bdpepple@gmail.com 2011-02-03 15:36:17 EST --- (In reply to comment #15)
Is user 'bar' really one you want here?
Also, does the fedora maintainer not wish to maintain in epel?
oops, bar was copy/paste error.
This is a dep for python-carrot, and the maintainer has no interest/time for the epel branch.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
Brian Pepple bdpepple@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611048
--- Comment #17 from Kevin Fenzi kevin@tummy.com 2011-02-06 17:45:06 EST --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla