https://bugzilla.redhat.com/show_bug.cgi?id=1131825
Bug ID: 1131825 Summary: Review Request: qtile - Small, flexible, scriptable tiling window manager Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: i@cicku.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://us-la.cicku.me/qtile.spec SRPM URL: http://us-la.cicku.me/qtile-0.8.0-1.fc22.src.rpm Description: Qtile is a full-featured, pure-Python tiling window manager.
Features: --------- * Simple, small and extensible. It's easy to write your own layouts, widgets and commands. * Configured in Python. * Command shell that allows all aspects of Qtile to be managed and inspected. * Complete remote scriptability - write scripts to set up workspaces, manipulate windows, update status bar widgets and more. * Qtile's remote scriptability makes it one of the most thoroughly unit-tested window managers around. Fedora Account System Username: cicku
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
Athmane Madjoudj athmanem@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |athmanem@gmail.com
--- Comment #1 from Athmane Madjoudj athmanem@gmail.com --- Created attachment 937123 --> https://bugzilla.redhat.com/attachment.cgi?id=937123&action=edit qtile startup
Thanks for packaging qtile, here's couple of notes that might help future reviewer:
1) Either remove shebang line (!#) or make .py files executable:
qtile.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/libqtile/confreader.py 0644L /usr/bin/env qtile.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/libqtile/widget/bitcoin_ticker.py 0644L /usr/bin/env qtile.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/libqtile/widget/yahoo_weather.py 0644L /usr/bin/env qtile.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/libqtile/widget/sensors.py 0644L /usr/bin/env
2) You need to file a bug against pycairo since it was compiled without xpyd (python xcb binding) which makes qtile unable to starts, attached the output.
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
--- Comment #2 from Athmane Madjoudj athmanem@gmail.com --- Regarding note 2, xcb and xpyb support has been enabled in 1.8.10-8
%changelog +* Sat Sep 07 2013 Tomas Dabasinskas tdabasin@fedoraproject.org - 1.8.10-8 +- Enabling xcb and xpyb +
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1005447
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
Tomas Dabašinskas tdabasin@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tdabasin@redhat.com
--- Comment #3 from Tomas Dabašinskas tdabasin@redhat.com --- Many thanks Christopher!
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
Tomas Dabašinskas tdabasin@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #4 from Tomas Dabašinskas tdabasin@redhat.com --- Taking up review
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
Tomas Dabašinskas tdabasin@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i@cicku.me Depends On| |1140886 Flags| |needinfo?(i@cicku.me)
--- Comment #5 from Tomas Dabašinskas tdabasin@redhat.com --- Scratch build ok: [packager@33b32ae1ef19 ~]$ koji build --scratch rawhide qtile-0.8.0-1.fc22.src.rpm Uploading srpm: qtile-0.8.0-1.fc22.src.rpm [====================================] 100% 00:00:03 276.85 KiB 73.45 KiB/sec Created task: 7752110 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7752110 Watching tasks (this may be safely interrupted)... 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm): open (buildvm-19.phx2.fedoraproject.org) 7752111 buildArch (qtile-0.8.0-1.fc22.src.rpm, noarch): open (buildvm-03.phx2.fedoraproject.org) 7752111 buildArch (qtile-0.8.0-1.fc22.src.rpm, noarch): open (buildvm-03.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm): open (buildvm-19.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed
7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm) completed successfully
/bin/qtile has import pkg_resources which is in python-setuptools, should it be included as Requires?
Having trouble with mock, unable to run fedora-review
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1140886 [Bug 1140886] mock fails with OSError: [Errno 0] Success when it run with wrong privs
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(i@cicku.me) |
--- Comment #6 from Christopher Meng i@cicku.me --- (In reply to Tomas Dabašinskas from comment #5)
Scratch build ok: [packager@33b32ae1ef19 ~]$ koji build --scratch rawhide qtile-0.8.0-1.fc22.src.rpm Uploading srpm: qtile-0.8.0-1.fc22.src.rpm [====================================] 100% 00:00:03 276.85 KiB 73.45 KiB/sec Created task: 7752110 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7752110 Watching tasks (this may be safely interrupted)... 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm): open (buildvm-19.phx2.fedoraproject.org) 7752111 buildArch (qtile-0.8.0-1.fc22.src.rpm, noarch): open (buildvm-03.phx2.fedoraproject.org) 7752111 buildArch (qtile-0.8.0-1.fc22.src.rpm, noarch): open (buildvm-03.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm): open (buildvm-19.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed
7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm) completed successfully
/bin/qtile has import pkg_resources which is in python-setuptools, should it be included as Requires?
Having trouble with mock, unable to run fedora-review
I will ask upstream about that.
Will you take this review? If so you can assign and change the bug status.
Thanks, I'm busy...
https://bugzilla.redhat.com/show_bug.cgi?id=1131825 Bug 1131825 depends on bug 1140886, which changed state.
Bug 1140886 Summary: mock fails with OSError: [Errno 0] Success when it run with wrong privs https://bugzilla.redhat.com/show_bug.cgi?id=1140886
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
Tomas Dabašinskas tdabasin@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |tdabasin@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
--- Comment #7 from Raphael Groner projects.rg@smart.ms --- As upstream seems to be very active, I would like to see a qtile package in Fedora. So I could be (co-)maintainer or take the review if you are lacking out of time or may like to give away ownership.
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
--- Comment #8 from Tomas Dabašinskas tdabasin@redhat.com --- Thanks for the offer Raphael, that would be great, please go ahead with the review. Please note python-setuptools must be included as a dependency for qtile
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jdulaney@fedoraproject.org
--- Comment #9 from Raphael Groner projects.rg@smart.ms --- Proposed F22 Self Contained Change: https://fedoraproject.org/wiki/Changes/qtile
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
--- Comment #10 from John Dulaney jdulaney@fedoraproject.org --- 0.9.0 is the latest release of qtile; I have packaged the dependencies in Fedora and was planning on packaging 0.9.0. I would suggest packaging the latest version; I'll gladly help.
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
--- Comment #11 from Raphael Groner projects.rg@smart.ms --- Who is the packager here? I can help with the review, mostly.
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
--- Comment #12 from John Dulaney jdulaney@fedoraproject.org --- No reply from Christopher Meng in quite some time; as the deadline for getting things into F22 is coming fast, something needs to be done. I have qtile 0.9 ready to go for a review request. I would also like to point out that I had started pacaging deps for qtile prior to this review request.
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |INSUFFICIENT_DATA Last Closed| |2015-01-30 19:47:19
--- Comment #13 from Raphael Groner projects.rg@smart.ms --- So I'll close as dead review cause it is quite obvious now. Feel free to duplicate (reopen) to start a new review process.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1131825
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|INSUFFICIENT_DATA |DUPLICATE
--- Comment #14 from Raphael Groner projects.rg@smart.ms ---
*** This bug has been marked as a duplicate of bug 1188093 ***
package-review@lists.fedoraproject.org