[Bug 242311] New: Review Request: perl-Time-Duration - rounded or exact English expression of durations
2:44 a.m.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
Summary: Review Request: perl-Time-Duration - rounded or exact
English expression of durations
Product: Fedora Extras
Version: devel
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: low
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: fedora(a)marcbradshaw.co.uk
QAContact: fedora-package-review(a)redhat.com
First package, sponsor required.
Spec URL: http://marcbradshaw.co.uk/packages/SPECS/perl-Time-Duration.spec
SRPM URL: http://marcbradshaw.co.uk/packages/SRPMS/perl-Time-Duration-1.04-2.fc6.sr...
Description:
This module provides functions for expressing durations in rounded or exact
terms.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
2:46 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
fedora(a)marcbradshaw.co.uk changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |242310
nThis| |
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
2:47 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
fedora(a)marcbradshaw.co.uk changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |177841
nThis| |
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
6:06 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
cweyl(a)alumni.drew.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cweyl(a)alumni.drew.edu
------- Additional Comments From cweyl(a)alumni.drew.edu 2007-06-04 19:06 EST -------
Heya -- a couple initial comments, not a review.
Overall the spec looks fairly clean, especially for a first submission :) There
are some tweaks that could be made -- and some perl-specific bits. Note you can
find the (draft!) perl packaging best practices at:
http://fedoraproject.org/wiki/PackagingDrafts/Perl
For perl buildrequires, it's preferable to specify the module needed rather than
the package containing the module (e.g. perl(Test::Pod) rather than perl-Test-Pod).
There's a perl-split which may be coming down the pike. It's recommended to
buildrequire Test::More or ExtUtils::MakeMaker if either are required (and it
looks like the latter is).
As it's a noarch package, this line can be nixed safely:
find %{buildroot} -type f -name '*.bs' -size 0 -exec rm -f {} \;
"chmod -R u+rwX,go+rX,go-w" works, but %{_fixperms} is so much easier on the
eyes :)
%doc in %files is (by convention) placed at the top of the files list.
%{?dist} is usually left out of the changelog version-release.
%{perl_vendorlib}/Time/Duration.pm is redundant; the first line will include
%{perl_vendorlib}/Time and everything below it, as it's a directory:
%{perl_vendorlib}/Time
%{perl_vendorlib}/Time/Duration.pm
The spec is missing a %check section; I haven't checked Time-Duration itself but
if the distribution includes any tests it's important to run them. e.g.
%check
make test
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
8:42 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
------- Additional Comments From fedora(a)marcbradshaw.co.uk 2007-06-04 21:42 EST -------
Chris, thanks for the comments and the link.
Spec file updated.
New SRPM URL:
http://marcbradshaw.co.uk/packages/SRPMS/perl-Time-Duration-1.04-3.fc6.sr...
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
10:41 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
bugzilla(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Product|Fedora Extras |Fedora
------- Additional Comments From fedora(a)marcbradshaw.co.uk 2007-06-25 23:41 EST -------
New SRPM:
http://marcbradshaw.co.uk/packages/SRPMS/perl-Time-Duration-1.04-3.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
3:44 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
jeff(a)ocjtech.us changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeff(a)ocjtech.us
------- Additional Comments From jeff(a)ocjtech.us 2007-07-01 16:44 EST -------
*** Bug 243733 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
3:52 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
------- Additional Comments From jeff(a)ocjtech.us 2007-07-01 16:52 EST -------
Marc, I'm willing to comaintain once you get this package approved and get
sponsored (unfortunately I can't sponsor).
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
4:02 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
ruben(a)rubenkerkhof.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ruben(a)rubenkerkhof.com
------- Additional Comments From ruben(a)rubenkerkhof.com 2007-07-01 17:02 EST -------
I can't sponsor either, but I had a look, and it looks good to me:
Review for release 3:
* RPM name is OK
* Source Time-Duration-1.04.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* package contains tests and they run OK
* package has sane Requires and Provides
Just a suggestion, it may be nice to include the ChangeLog file in %doc
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
1:54 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
------- Additional Comments From fedora(a)marcbradshaw.co.uk 2007-07-02 02:54 EST -------
Ruben: Good point, ChangeLog should indeed be in %doc, it has been added.
SRPM: http://marcbradshaw.co.uk/packages/SRPMS/perl-Time-Duration-1.04-4.src.rpm
Jeffrey: I would be happy to have a co-maintainer. Thanks.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
10:02 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
------- Additional Comments From jeff(a)ocjtech.us 2007-07-12 11:02 EST -------
Marc, have you done any pre-reviews of other packages? Basically you do
everything that you would normally do for a review except that you can't
actually approve the package. Doing pre-reviews will show potential sponsors
that you have a good grasp of the packaging guidelines.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
7:35 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311
------- Additional Comments From fedora(a)marcbradshaw.co.uk 2007-07-30 20:35 EST -------
I do try and contribute where possible.
Updated URLs
http://marcbradshaw.co.uk/packages/perl-Time-Duration-1.04-4.src.rpm
http://marcbradshaw.co.uk/packages/perl-Time-Duration.spec
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
2:39 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/show_bug.cgi?id=242311
j.w.r.degoede(a)hhs.nl changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841 |
nThis| |
AssignedTo|nobody(a)fedoraproject.org |j.w.r.degoede(a)hhs.nl
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2007-09-18 15:39 EST -------
I've done a full review, here is the result:
Must Fix:
---------
* Change license field to: "GPLv2+ or Artistic 2.0"
Should Fix:
-----------
* Fedora's default %defattr is: "%defattr(-,root,root,-)
* There is a new upstream 1.06 release, this is a should Fix, as the changes
seem pretty much uninteresting
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
6:01 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/show_bug.cgi?id=242311
------- Additional Comments From fedora(a)marcbradshaw.co.uk 2007-09-18 19:01 EST -------
All fixed.
http://marcbradshaw.co.uk/packages/perl-Time-Duration-1.06-1.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
10:22 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/show_bug.cgi?id=242311
------- Additional Comments From rc040203(a)freenet.de 2007-09-18 23:21 EST -------
Remove the OPTIMIZE from %build.
This is a noarch package, so passing CFLAGS doesn't make sense.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
7:28 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/show_bug.cgi?id=242311
j.w.r.degoede(a)hhs.nl changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2007-09-19 08:28 EST -------
Approved, about the OPTIMIZE this is indeed unneeded, but not harmfull, you
could consider removing this before import.
Again, please wait with posting a CVS admin request until we're done with the
other 2 and I've sponsored you.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
6:39 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/show_bug.cgi?id=242311
------- Additional Comments From fedora(a)marcbradshaw.co.uk 2007-09-19 19:39 EST -------
Thanks.
I will remove the optimize before cvs.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
6:37 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/show_bug.cgi?id=242311
fedora(a)marcbradshaw.co.uk changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
------- Additional Comments From fedora(a)marcbradshaw.co.uk 2007-09-23 07:37 EST -------
New Package CVS Request
=======================
Package Name: perl-Time-Duration
Short Description: rounded or exact English expression of durations
Owners: deebs
Branches: F-7
InitialCC:
Cvsextras Commits: yes
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
11:12 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/show_bug.cgi?id=242311
kevin(a)tummy.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin(a)tummy.com 2007-09-24 12:12 EST -------
cvs done.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
6:30 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Time-Duration - rounded or exact English expression of
durations
https://bugzilla.redhat.com/show_bug.cgi?id=242311
fedora(a)marcbradshaw.co.uk changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution| |NEXTRELEASE
------- Additional Comments From fedora(a)marcbradshaw.co.uk 2007-09-24 19:30 EST -------
Thanks to all for the review and thanks to Hans for the sponsorship.
Jeffrey, if you would still like to co-maintain this package let me know.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
7:51 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=242311
--- Comment #18 from Marc Bradshaw <fedora(a)marcbradshaw.co.uk> 2008-08-18 20:51:14
EDT ---
Package Change Request
======================
Package Name: perl-Time-Duration
New Branches: EL-4 EL-5
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
2:09 p.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=242311
Toshio Kuratomi <tkuratom(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tkuratom(a)redhat.com
--- Comment #19 from Toshio Kuratomi <tkuratom(a)redhat.com> 2008-08-23 15:09:07 EDT
---
cvs done.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
1:07 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=242311
Marcela Mašláňová <mmaslano(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-cvs+ |fedora-cvs?
--- Comment #20 from Marcela Mašláňová <mmaslano(a)redhat.com> 2012-01-11 02:07:30 EST
---
Package Change Request
======================
Package Name: perl-Time-Duration
InitialCC: perl-sig
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
7:09 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=242311
--- Comment #21 from Jon Ciesla <limburgher(a)gmail.com> 2012-01-11 08:09:42 EST ---
I think I've done what you need, if not, let me know.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
10:14 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=242311
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ppisar(a)redhat.com
Flag| |fedora-cvs?
--- Comment #22 from Petr Pisar <ppisar(a)redhat.com> 2012-01-11 11:14:34 EST ---
No, You have replaced the owner instead of adding perl-sig into CC role. Please
revert ownership to mmaslano and add perl-sig with watch* rights only.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
10:36 a.m.
New subject: [Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=242311
--- Comment #23 from Jon Ciesla <limburgher(a)gmail.com> 2012-01-11 11:36:26 EST ---
Fixed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
4545
days inactive
6228
days old
package-review@lists.fedoraproject.org
25 comments
1 participants
participants (1)
-
Red Hat Bugzilla