[Bug 2139183] New: Review Request: coffeescript - A programming language that transcompiles to JavaScript - core compiler
https://bugzilla.redhat.com/show_bug.cgi?id=2139183
Bug ID: 2139183 Summary: Review Request: coffeescript - A programming language that transcompiles to JavaScript - core compiler Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: sgallagh@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/sgallagh/coffeescript/fed...
SRPM URL: https://download.copr.fedorainfracloud.org/results/sgallagh/coffeescript/fed...
Description: <description here> CoffeeScript is a little language that compiles into JavaScript. Underneath all of those embarrassing braces and semicolons, JavaScript has always had a gorgeous object model at its heart. CoffeeScript is an attempt to expose the good parts of JavaScript in a simple way.
The golden rule of CoffeeScript is: "It's just JavaScript". The code compiles one-to-one into the equivalent JS, and there is no interpretation at runtime. You can use any existing JavaScript library seamlessly (and vice-versa). The compiled output is readable and pretty-printed, passes through JavaScript Lint without warnings, will work in every JavaScript implementation, and tends to run as fast or faster than the equivalent handwritten JavaScript.
COPR: https://copr.fedorainfracloud.org/coprs/sgallagh/coffeescript/
Fedora Account System Username: sgallagh
Additional information:
This is a rename to match upstream's rename from coffee-script to coffeescript.
https://bugzilla.redhat.com/show_bug.cgi?id=2139183
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #1 from Stephen Gallagher sgallagh@redhat.com --- CCing Vit Ondruch: Vit, since you maintain the current (FTBFS) package, would you mind taking a look at this rename request?
https://bugzilla.redhat.com/show_bug.cgi?id=2139183
--- Comment #2 from Vít Ondruch vondruch@redhat.com --- I'd be more then happy if this replaced the coffee-script package (and me not being maintainer of CoffeeScript). Unfortunately, there is rubygem-coffee-script-source which still depends on coffee-script 1.x and in turn, there is the following dependency tree:
~~~ $ sudo dnf repoquery --disablerepo=* --enablerepo=rawhide --enablerepo=rawhide-source --whatrequires "rubygem-coffee-script-source" Poslední kontrola metadat: před 0:06:25, St 2. listopadu 2022, 17:22:45. rubygem-coffee-script-0:2.4.1-15.fc37.noarch rubygem-coffee-script-0:2.4.1-15.fc37.src rubygem-coffee-script-source-doc-0:1.10.0-14.fc37.noarch
$ sudo dnf repoquery --disablerepo=* --enablerepo=rawhide --enablerepo=rawhide-source --whatrequires "rubygem-coffee-script" Poslední kontrola metadat: před 0:06:34, St 2. listopadu 2022, 17:22:45. rubygem-actioncable-0:7.0.4-1.fc38.src rubygem-coffee-script-doc-0:2.4.1-15.fc37.noarch rubygem-sinatra-1:2.2.0-3.fc37.src rubygem-sprockets-0:4.0.2-5.fc37.src rubygem-tilt-0:2.0.10-8.fc37.src ~~~
In theory, these are just build (in this case probably test) dependencies.
And several notes about the .spec (although I don't think I am the right person to review):
1) Why is the dependency direction between coffeescript and js-coffeescript packages reversed? I believe that the main package is superset to the js- subpackage. 2) Does `%autosetup` support `-a 2` option to replace the `tar xf %{SOURCE2}`
https://bugzilla.redhat.com/show_bug.cgi?id=2139183
--- Comment #3 from Stephen Gallagher sgallagh@redhat.com --- (In reply to Vít Ondruch from comment #2)
I'd be more then happy if this replaced the coffee-script package (and me not being maintainer of CoffeeScript). Unfortunately, there is rubygem-coffee-script-source which still depends on coffee-script 1.x and in turn, there is the following dependency tree:
Good point, I should probably prep patches for those as well in a COPR before I land this in F38.
...
And several notes about the .spec (although I don't think I am the right person to review):
- Why is the dependency direction between coffeescript and js-coffeescript
packages reversed? I believe that the main package is superset to the js- subpackage.
Mostly it just required less post-processing in %install, but I can put it back the other direction if preferred.
- Does `%autosetup` support `-a 2` option to replace the `tar xf %{SOURCE2}`
Thanks, I was unaware of that option. I'll change it.
https://bugzilla.redhat.com/show_bug.cgi?id=2139183
--- Comment #4 from Stephen Gallagher sgallagh@redhat.com --- Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/sgallagh/coffeescript/coffee... SRPM URL: https://download.copr.fedorainfracloud.org/results/sgallagh/coffeescript/srp...
https://bugzilla.redhat.com/show_bug.cgi?id=2139183
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DEFERRED Status|NEW |CLOSED Last Closed| |2022-11-03 15:26:03
--- Comment #5 from Stephen Gallagher sgallagh@redhat.com --- Withdrawing this review request for now. The fallout it would introduce is too big and needs to be resolved first.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com