[Bug 1645294] New: Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

Bug ID: 1645294
           Summary: Review Request: delve - Debugger for Go programming
                    language
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://github.com/derekparker/delve-fedpkg/blob/v1.1.0-1/delve.spec
SRPM URL:
https://github.com/derekparker/delve-fedpkg/releases/download/v1.1.0-1/delve...
Description: Package for the Delve debugger for the Go programming language.
Fedora Account System Username: deparker

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

--- Comment #1 from Derek Parker  ---
Spec URL:
https://raw.githubusercontent.com/derekparker/delve-fedpkg/v1.1.0-1/delve.sp...
SRPM URL:
https://github.com/derekparker/delve-fedpkg/releases/download/v1.1.0-1/delve...
Description: Package for the Del

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

Tom Stellard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
             Blocks|                            |177841 (FE-NEEDSPONSOR)
           Assignee|[e-mail]    |[e-mail]

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

--- Comment #2 from Tom Stellard  ---
The BuildRoot tag has been deprecated, so you should remove that.  Also it
looks like the spec file you posted is newer than the spec file in the srpm. 
Can you rebuild the srpm with the latest spec file.

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

Jakub Čajka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Jakub Čajka  ---
The spec file doesn't contain the bundled provides for all the vendored stuff
https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication....
Have you considered de-bundling?

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

--- Comment #4 from Jakub Čajka  ---
For the record we have issue for packaging delve in the Go-SIG
https://pagure.io/GoSIG/go-sig/issue/9 .

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Robert-André Mauchin  ---
Could this be unbundled and use the new Go packaging?

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

--- Comment #6 from Robert-André Mauchin  ---
It looks like that:

============================
# Run tests in check section
%bcond_without check

# https://github.com/derekparker/delve
%global goipath         github.com/derekparker/delve
Version:                1.1.0

%global common_description %{expand:
Delve is a debugger for the Go programming language. The goal of the project 
is to provide a simple, full featured debugging tool for Go. Delve should be 
easy to invoke and easy to use. Chances are if you're using a debugger, things 
aren't going your way. With that in mind, Delve should stay out of your way as 
much as possible.}

%gometa

Name:           delve
Release:        1%{?dist}
Summary:        A debugger for the Go programming language
# Detected licences
# - Expat License at 'LICENSE'
License:        MIT
URL:            %{gourl}
Source0:        %{gosource}

BuildRequires: golang(github.com/cosiner/argv)
BuildRequires: golang(github.com/mattn/go-colorable)
BuildRequires: golang(github.com/mattn/go-isatty)
BuildRequires: golang(github.com/peterh/liner)
BuildRequires: golang(github.com/pkg/profile)
BuildRequires: golang(github.com/sirupsen/logrus)
BuildRequires: golang(github.com/spf13/cobra)
BuildRequires: golang(golang.org/x/arch/x86/x86asm)
BuildRequires: golang(golang.org/x/sys/unix)
BuildRequires: golang(golang.org/x/sys/windows)
BuildRequires: golang(gopkg.in/yaml.v2)

%description
%{common_description}

%package -n %{goname}-devel
Summary:       %{summary}
BuildArch:     noarch

%description -n %{goname}-devel
%{common_description}

This package contains library source intended for
building other packages which use import path with
%{goipath} prefix.

%prep
%forgesetup

rm -rf vendor/

%build
%gobuildroot
%gobuild -o _bin/dlv %{goipath}/cmd/dlv

%install
%goinstall
install -Dpm 0755 _bin/dlv %{buildroot}%{_bindir}/dlv

%if %{with check}
%check
%gochecks
%endif

%files
%license LICENSE
%doc CONTRIBUTING.md CHANGELOG.md
%doc Documentation/*
%{_bindir}/dlv

%files -n %{goname}-devel -f devel.file-list
%license LICENSE

%changelog
* Tue Oct 30 2018 Derek Parker  - 1.1.0-1
- First package for Fedora

==================================

The only missing package is golang.org/x/arch, the other might need to be
updated.

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

--- Comment #7 from Robert-André Mauchin  ---
BuildRequires: golang(github.com/mattn/go-colorable) is to be removed as it is
Windows only.

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1645681

--- Comment #8 from Robert-André Mauchin  ---
I've updated all the dependencies and added a Review Request for
golang.org/x/arch.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1645681
[Bug 1645681] Review Request: golang-x-arch - Machine architecture
information used by the Go toolchain

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

--- Comment #9 from Derek Parker  ---
Thanks Robert-Andre! I'll take the updated spec you've provided and use that as
well. Thanks for that, by the way.

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

--- Comment #10 from Derek Parker  ---
Is there anyone reviewing the above request for `golang.org/x/arch`? Once that
is in and unblocks this package I'd love to move forward.

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

--- Comment #11 from Tom Stellard  ---
I don't think I have permissions to sponsor Derek, if another commenter is able
to sponsor and wants take over this review, that is fine with me.

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Dan Horák  ---
I can sponsor Derek, but I'm not familiar with Go packaging. So if someone
trustworthy could do the actual review, I'll do the sponsorship then.

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

--- Comment #13 from Derek Parker  ---
Looks like the other packaged was reviewed:
https://bugzilla.redhat.com/show_bug.cgi?id=1645681.

I'll work on this more today, and update everything.

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

--- Comment #14 from Derek Parker  ---
The dependency (x/arch) requires a dep to be packaged (rsc.io/pdf). I'll work
on packaging that.

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294

Derek Parker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1654879

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1654879
[Bug 1654879] Review Request: rsc - Machine architecture information used
by the Go toolchain

[Bug 1645294] Review Request: delve - Debugger for Go programming language

https://bugzilla.redhat.com/show_bug.cgi?id=1645294
Bug 1645294 depends on bug 1654879, which changed state.

Bug 1654879 Summary: Review Request: rsc-pdf: PDF Reader written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1654879

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |NOTABUG