https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Bug ID: 1703542 Summary: Review Request: afterburn - A simple cloud provider agent Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rfairley@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-afterburn/fedo... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/rust-afterburn/fedo... Description: A simple cloud provider agent. Afterburn sources metadata from cloud providers (e.g. hostname, IP address, instance ID for AWS), and applies the metadata to the system. This can include things like writing the metadata as environment variables in a file to be read by other utilities, writing SSH keys, or configuring network units. See: https://github.com/coreos/afterburn/blob/master/README.md Fedora Account System Username: rfairley
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Robert Fairley rfairley@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: afterburn - |Review Request: |A simple cloud provider |rust-afterburn - A simple |agent |cloud provider agent
--- Comment #1 from Robert Fairley rfairley@redhat.com --- Note that the rust crate dependencies are vendored here. Initially, efforts were made to use crates packaged in Fedora, and we are close to this, however a number of dependencies still need to be packaged [1]. We would like to have Afterburn available in Fedora CoreOS and sourced from the Fedora stable repo quite soon (within the next month or so) in time to release a preview of Fedora CoreOS [2], and believe that vendoring the dependencies is easiest for now. Later on, we plan to use the RPM-packaged crates for the dependencies.
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #2 from Robert Fairley rfairley@redhat.com --- (In reply to Robert Fairley from comment #1)
Note that the rust crate dependencies are vendored here. Initially, efforts were made to use crates packaged in Fedora, and we are close to this, however a number of dependencies still need to be packaged [1]. We would like to have Afterburn available in Fedora CoreOS and sourced from the Fedora stable repo quite soon (within the next month or so) in time to release a preview of Fedora CoreOS [2], and believe that vendoring the dependencies is easiest for now. Later on, we plan to use the RPM-packaged crates for the dependencies.
Apologies, these should refer to:
[1] https://paste.fedoraproject.org/paste/di3MmbCetHvIE3XSetxe4A [2] https://github.com/coreos/fedora-coreos-tracker/issues/4
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |i.gnatenko.brain@gmail.com Assignee|nobody@fedoraproject.org |i.gnatenko.brain@gmail.com
--- Comment #4 from Igor Gnatenko i.gnatenko.brain@gmail.com --- How many dependencies are we talking about?
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1703642 (rust-slog-async)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1703642 [Bug 1703642] Review Request: rust-slog-async - Asynchronous drain for slog-rs
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1703643 (rust-slog-term)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1703643 [Bug 1703643] Review Request: rust-slog-term - Unix terminal drain and formatter for slog-rs
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1703645 (rust-openssh-keys)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1703645 [Bug 1703645] Review Request: rust-openssh-keys - Read and write OpenSSH public keys
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1703649 (rust-serde-xml-rs)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1703649 [Bug 1703649] Review Request: rust-serde-xml-rs - xml-rs based deserializer for Serde (compatible with 0.9+)
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #5 from Igor Gnatenko i.gnatenko.brain@gmail.com --- I think the only pieces which are missing are:
* mockito (somebody is packaging it, not sure how successful -- https://bugzilla.redhat.com/show_bug.cgi?id=1698710) * pnet (requires porting to syn/quote, upstream would be happy to take a patch -- https://github.com/libpnet/libpnet/issues/355) * reqwest (needs to be updated in Fedora, you can probably relax version unless you are using features from 0.9.15+) * slog-scope (either needs to be ported to arc-swap or old crossbeam has to be added to fedora -- https://github.com/slog-rs/scope/pull/7) * update-ssh-keys (optional, easy to package)
The rest I have packaged and added as dependencies for this bug.
---
So the only big thing is porting pnet... And I'm pretty sure you can spend some time working on it :)
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #6 from Igor Gnatenko i.gnatenko.brain@gmail.com --- And even with pnet, there is quite easy workaround.. Just depend on pnet_datalink and pnet_base directly (since you are using functions only from those). None of those needs syntex_*.
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1703650 | |(rust-pnet_datalink)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1703650 [Bug 1703650] Review Request: rust-pnet_datalink - Cross-platform, datalink layer networking
https://bugzilla.redhat.com/show_bug.cgi?id=1703542 Bug 1703542 depends on bug 1703649, which changed state.
Bug 1703649 Summary: Review Request: rust-serde-xml-rs - xml-rs based deserializer for Serde (compatible with 0.9+) https://bugzilla.redhat.com/show_bug.cgi?id=1703649
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1703542 Bug 1703542 depends on bug 1703643, which changed state.
Bug 1703643 Summary: Review Request: rust-slog-term - Unix terminal drain and formatter for slog-rs https://bugzilla.redhat.com/show_bug.cgi?id=1703643
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1703542 Bug 1703542 depends on bug 1703650, which changed state.
Bug 1703650 Summary: Review Request: rust-pnet_datalink - Cross-platform, datalink layer networking https://bugzilla.redhat.com/show_bug.cgi?id=1703650
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1703542 Bug 1703542 depends on bug 1703642, which changed state.
Bug 1703642 Summary: Review Request: rust-slog-async - Asynchronous drain for slog-rs https://bugzilla.redhat.com/show_bug.cgi?id=1703642
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1703542 Bug 1703542 depends on bug 1703645, which changed state.
Bug 1703645 Summary: Review Request: rust-openssh-keys - Read and write OpenSSH public keys https://bugzilla.redhat.com/show_bug.cgi?id=1703645
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #7 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Created attachment 1559504 --> https://bugzilla.redhat.com/attachment.cgi?id=1559504&action=edit use-pnet-subcrates-directly.diff
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1698710
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1698710 [Bug 1698710] Review Request: rust-mockito - HTTP mocking for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1703750 (rust-slog-scope)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1703750 [Bug 1703750] Review Request: rust-slog-scope - Logging scopes for slog-rs
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1703760 (rust-mockito)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1703760 [Bug 1703760] Review Request: rust-mockito - HTTP mocking for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1703542 Bug 1703542 depends on bug 1698710, which changed state.
Bug 1698710 Summary: Review Request: rust-mockito - HTTP mocking for Rust https://bugzilla.redhat.com/show_bug.cgi?id=1698710
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=1703542 Bug 1703542 depends on bug 1703750, which changed state.
Bug 1703750 Summary: Review Request: rust-slog-scope - Logging scopes for slog-rs https://bugzilla.redhat.com/show_bug.cgi?id=1703750
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE Last Closed| |2019-04-28 09:58:44
--- Comment #8 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Folks,
I have imported this in separate bugzilla with fixed packaging (no bundling, systemd scriptlets and such). I've added Robert as an admin to the repo.
Let me know if you will need this in F28/F29/F30. In that case we will need to create a module and such.
*** This bug has been marked as a duplicate of bug 1703775 ***
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #9 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Forgot to mention Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=34505881
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #10 from Jonathan Lebon jlebon@redhat.com --- @Igor, awesome thanks *so much* for getting this through quickly. :)
Let me know if you will need this in F28/F29/F30.
Yes, we'll need this for F30.
In that case we will need to create a module and such.
Gotcha. Should we file a separate bug for this? Is there a tool for generating the modulemd automatically?
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
Dusty Mabe dustymabe@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dustymabe@redhat.com
--- Comment #11 from Dusty Mabe dustymabe@redhat.com --- @Igor - thank you so much!
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #12 from Robert Fairley rfairley@redhat.com --- Thanks very much @Igor for getting this in to Fedora!
I requested an f30 branch for `rpms/rust-afterburn` [1], an `afterburn` module [2], and an f30 branch for that module [3]:
[1] https://pagure.io/releng/fedora-scm-requests/issue/11484 [2] https://pagure.io/releng/fedora-scm-requests/issue/11485 [3] https://pagure.io/releng/fedora-scm-requests/issue/11486
I think for a tool to generate the modulemd, we could try this: https://docs.fedoraproject.org/en-US/modularity/making-modules/defining-modu... Will give this a go.
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #13 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Ugh. Please don't request f30 branches ever. They are not needed and you won't be able to do anything with it.
First thing you need to decide on how you are going to push updates. Are you planning to support "4.x", then "5.x" at the same time? Or you are planning to constantly update?
You can use http://pagure.io/fedora-rust/modularity-utils to generate yaml
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #14 from Dusty Mabe dustymabe@redhat.com --- (In reply to Igor Gnatenko from comment #13)
Ugh. Please don't request f30 branches ever. They are not needed and you won't be able to do anything with it.
Talked with igor. Looks like if we are building in a module with crates from rawhide it will auto build for f29, f30, f31 etc..
First thing you need to decide on how you are going to push updates. Are you planning to support "4.x", then "5.x" at the same time? Or you are planning to constantly update?
Just `latest` AFAIU.
You can use http://pagure.io/fedora-rust/modularity-utils to generate yaml
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #15 from Robert Fairley rfairley@redhat.com --- Per discussion in IRC #fedora-rust, I requested a `rolling` branch for `modules/afterburn`: https://pagure.io/releng/fedora-scm-requests/issue/11493
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- afterburn-rolling-3020190507144241.2c789dff has been submitted as an update to Fedora 30 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-ca040be1f2
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- afterburn-rolling-2920190507144241.b8a06959 has been submitted as an update to Fedora 29 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-76aa228c64
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- afterburn-rolling-2820190507144241.1e15db1a has been submitted as an update to Fedora 28 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-3935c626a5
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- afterburn-rolling-3020190507144241.2c789dff has been pushed to the Fedora 30 Modular stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- afterburn-rolling-2920190507144241.b8a06959 has been pushed to the Fedora 29 Modular stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1703542
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- afterburn-rolling-2820190507144241.1e15db1a has been pushed to the Fedora 28 Modular stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com