[Bug 575185] New: Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-bunch - python dictionary with attribute-style access

https://bugzilla.redhat.com/show_bug.cgi?id=575185

Summary: Review Request: python-bunch - python dictionary with
                    attribute-style access
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://toshio.fedorapeople.org/packages/python-bunch.spec
SRPM URL:
http://toshio.fedorapeople.org/packages/python-bunch-1.0.0-1.fc12.src.rpm
Description:
python-bunch provides a python class which can perform as a dict whose keys are
also accessible as attributes, similar to JavaScript objects.  For instance::
> > > import bunch
> > > people = bunch.Bunch({'alice': 'here', 'bob': 'there'})
> > > print people['alice'], people.alice

here here

The piece of python-bunch that sets it apart from similar modules found inside
other projects is the bunchify() function which recursively converts from
a dict to a Bunch::
> > > multi_level = {'array': ['scalar', {'mapping': 'to show recursion'} ]}
> > > bunch.bunchify(multi_level)

Bunch(array=['scalar', Bunch(mapping='to show recursion')])

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #1 from Toshio Ernie Kuratomi  2010-03-19 13:13:10 EDT ---
rpmlint notes the following:

python-bunch.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/bunch/__init__.py 0644 /usr/bin/env

This file has doctests in it and a driver for the doctests.

python-bunch.src: W: spelling-error %description -l en_US alice -> Alice,
slice, alive
python-bunch.src: W: spelling-error %description -l en_US bunchify -> bunchy,
Bunche, bunch
python-bunch.src: W: spelling-error %description -l en_US multi -> mulch, mufti

These are part of the example code in the description

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #2 from Toshio Ernie Kuratomi  2010-03-19 13:32:41 EDT ---
Scratch build F12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2063387
Scratch build F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2063375

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Parag AN(पराग)  2010-05-09 23:57:38 EDT ---
Sorry was busy and away last weekend.

+ is ok
- is Needs work

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2176218

+ rpmlint output for SRPM and for RPM.
python-bunch.src: W: spelling-error %description -l en_US alice -> Alice,
slice, alive
python-bunch.src: W: spelling-error %description -l en_US bunchify -> bunchy,
Bunche, bunch
python-bunch.src: W: spelling-error %description -l en_US multi -> mulch, mufti
python-bunch.noarch: W: spelling-error %description -l en_US alice -> Alice,
slice, alive
python-bunch.noarch: W: spelling-error %description -l en_US bunchify ->
bunchy, Bunche, bunch
python-bunch.noarch: W: spelling-error %description -l en_US multi -> mulch,
mufti
python-bunch.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/bunch/__init__.py 0644L /usr/bin/env
2 packages and 0 specfiles checked; 1 errors, 6 warnings.
==> All these can be ignored and are false messages.

+ source files match upstream url (sha1sum)
d6f0d0f626218b5c955f233d4d45ef18727ff4ea  bunch-1.0.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
- BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no -devel subpackage
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Suggestions:
1) we can remove build time dependency on dos2unix by using sed in %prep
See https://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings
also good if timestamps are preserved.

APPROVED.

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

Toshio Ernie Kuratomi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Toshio Ernie Kuratomi  2010-05-10 00:53:21 EDT ---
Thanks Parag!

New Package CVS Request
=======================
Package Name: python-bunch
Short Description: python dictionary with attribute-style access
Owners: toshio
Branches: F-11 F-12 F-13 EL-5
InitialCC:

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #5 from Kevin Fenzi  2010-05-11 00:40:43 EDT ---
CVS done (by process-cvs-requests.py).

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #6 from Fedora Update System  2010-05-12 06:09:16 EDT ---
python-bunch-1.0.0-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/python-bunch-1.0.0-1.el5

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #7 from Fedora Update System  2010-05-12 06:09:36 EDT ---
python-bunch-1.0.0-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/python-bunch-1.0.0-1.fc12

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #8 from Fedora Update System  2010-05-12 06:09:40 EDT ---
python-bunch-1.0.0-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/python-bunch-1.0.0-1.fc13

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #9 from Fedora Update System  2010-05-12 06:09:46 EDT ---
python-bunch-1.0.0-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/python-bunch-1.0.0-1.fc11

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #10 from Toshio Ernie Kuratomi  2010-05-12 06:12:40 EDT ---
Package Change Request
======================
Package Name: python-bunch
New Branches: EL-6
Owners: toshio

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #11 from Fedora Update System  2010-05-12 13:54:28 EDT ---
python-bunch-1.0.0-1.fc11 has been pushed to the Fedora 11 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-bunch'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/python-bunch-1.0.0-1.fc11

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #12 from Fedora Update System  2010-05-12 13:58:34 EDT ---
python-bunch-1.0.0-1.fc12 has been pushed to the Fedora 12 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-bunch'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/python-bunch-1.0.0-1.fc12

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #13 from Fedora Update System  2010-05-12 14:01:18 EDT ---
python-bunch-1.0.0-1.fc13 has been pushed to the Fedora 13 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-bunch'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/python-bunch-1.0.0-1.fc13

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #14 from Fedora Update System  2010-05-13 21:06:10 EDT ---
python-bunch-1.0.0-1.el5 has been pushed to the Fedora EPEL 5 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-bunch'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/python-bunch-1.0.0-1.el5

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #15 from Fedora Update System  2010-05-20 14:40:19 EDT ---
python-bunch-1.0.0-1.fc13 has been pushed to the Fedora 13 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |python-bunch-1.0.0-1.fc13
         Resolution|                            |ERRATA

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #16 from Fedora Update System  2010-05-20 14:47:36 EDT ---
python-bunch-1.0.0-1.fc12 has been pushed to the Fedora 12 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|python-bunch-1.0.0-1.fc13   |python-bunch-1.0.0-1.fc12

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #17 from Fedora Update System  2010-05-20 14:49:51 EDT ---
python-bunch-1.0.0-1.fc11 has been pushed to the Fedora 11 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|python-bunch-1.0.0-1.fc12   |python-bunch-1.0.0-1.fc11

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

--- Comment #18 from Fedora Update System  2010-06-03 11:01:05 EDT ---
python-bunch-1.0.0-1.el5 has been pushed to the Fedora EPEL 5 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575185

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|python-bunch-1.0.0-1.fc11   |python-bunch-1.0.0-1.el5