[Bug 675364] New: Review Request: perl-Digest-JHash - Perl extension for 32 bit Jenkins Hashing Algorithm

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Digest-JHash -  Perl extension for 32 bit Jenkins Hashing Algorithm

https://bugzilla.redhat.com/show_bug.cgi?id=675364

Summary: Review Request: perl-Digest-JHash -  Perl extension
                    for 32 bit Jenkins Hashing Algorithm
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Digest-JHash.spec
SRPM URL:
http://corsepiu.fedorapeople.org/packages/perl-Digest-JHash-0.07-1.fc15.src....

Description: 
The Digest::JHash module allows you to use the fast JHash hashing algorithm
developed by Bob Jenkins from within Perl programs. The algorithm takes as
input a message of arbitrary length and produces as output a 32-bit
"message digest" of the input in the form of an unsigned long integer.

[Bug 675364] Review Request: perl-Digest-JHash - Perl extension for 32 bit Jenkins Hashing Algorithm

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675364

Iain Arnell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #1 from Iain Arnell  2011-02-27 04:48:43 EST ---
+ source files match upstream.  
    273adb11b5c4701dc43273d82ab26dd9  Digest-JHash-0.07.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
    Artistic 2.0

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2869957

+ package installs properly.
+ rpmlint has no complaints:
    3 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
    perl(Digest::JHash) = 0.07
    perl-Digest-JHash = 0.07-1.fc16
    perl-Digest-JHash(x86-64) = 0.07-1.fc16
=
    libc.so.6()(64bit)  
    libc.so.6(GLIBC_2.2.5)(64bit)  
    perl(DynaLoader)  
    perl(Exporter)  
    perl(:MODULE_COMPAT_5.12.3)  
    perl(strict)  
    perl(vars)  
    perl(warnings)

+ %check is present and all tests pass.
    PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
    t/jhash.t ......... ok
    t/pod.t ........... ok
    t/pod_coverage.t .. ok
    All tests successful.
    Files=3, Tests=7,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.09 cusr  0.02
csys =  0.13 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

A nice simple clean package. APPROVED.

[Bug 675364] Review Request: perl-Digest-JHash - Perl extension for 32 bit Jenkins Hashing Algorithm

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675364

Ralf Corsepius  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from Ralf Corsepius  2011-02-27 06:52:05 EST ---
Thanks again, Iain.

New Package SCM Request
=======================
Package Name: perl-Digest-JHash
Short Description: Perl extension for 32 bit Jenkins Hashing Algorithm
Owners: corsepiu
Branches: f13 f14 f15
InitialCC: perl-sig

[Bug 675364] Review Request: perl-Digest-JHash - Perl extension for 32 bit Jenkins Hashing Algorithm

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675364

--- Comment #3 from Jason Tibbitts  2011-02-28 09:57:25 EST ---
Git done (by process-git-requests).

[Bug 675364] Review Request: perl-Digest-JHash - Perl extension for 32 bit Jenkins Hashing Algorithm

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675364

Ralf Corsepius  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
        Last Closed|                            |2011-03-04 02:19:57