[Bug 2176670] New: Review Request: fedora-iot-config - ostree configuration file for Fedora IoT
https://bugzilla.redhat.com/show_bug.cgi?id=2176670
Bug ID: 2176670 Summary: Review Request: fedora-iot-config - ostree configuration file for Fedora IoT Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: pwhalen@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
SPEC: https://pwhalen.fedorapeople.org/packages/fedora-iot-config/fedora-iot-confi... SRPM: https://pwhalen.fedorapeople.org/packages/fedora-iot-config/fedora-iot-confi...
Description: Fedora IoT configuration file for ostree repositories.
FAS: pwhalen
Scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=98466256
https://bugzilla.redhat.com/show_bug.cgi?id=2176670
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://fedoraproject.org/
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5616167 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2176670
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pbrobinson@gmail.com Assignee|nobody@fedoraproject.org |pbrobinson@gmail.com Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2176670
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #2 from Peter Robinson pbrobinson@gmail.com --- This looks mostly fine, just one small piece:
install -d %{buildroot}%{_sysconfdir}/ostree/remotes.d/
%dir %{_sysconfdir}/ostree/remotes.d
That directory shouldn't need to be created as it's owned/created by the ostree-libs package so we should just add that as a BuildReq so it's there during build, and a Requires.
That can be fixed before commit, other than that this is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2176670
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/fedora-iot-config
https://bugzilla.redhat.com/show_bug.cgi?id=2176670
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8dcfdd9e10 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8dcfdd9e10
https://bugzilla.redhat.com/show_bug.cgi?id=2176670
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8dcfdd9e10 has been pushed to the Fedora 38 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8dcfdd9e10
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2176670
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2023-04-19 01:38:48
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8dcfdd9e10 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com