[Bug 2158276] New: Review Request: rust-libmimalloc-sys - Sys crate wrapping the mimalloc allocator
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
Bug ID: 2158276 Summary: Review Request: rust-libmimalloc-sys - Sys crate wrapping the mimalloc allocator Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/rust-libmimalloc-sys.spec SRPM URL: https://salimma.fedorapeople.org/rust-libmimalloc-sys-0.1.28-1.fc37.src.rpm
Description: Sys crate wrapping the mimalloc allocator.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5200801 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-215...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Blocks| |2158280
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2158280 [Bug 2158280] Review Request: rust-mimalloc - Performance and security oriented drop-in allocator
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |davide@cavalca.name Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |davide@cavalca.name
--- Comment #2 from Davide Cavalca davide@cavalca.name --- Please double check that the license file included is correct, it looks like it's the one for the bundled C library?
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- Updated the spec, and filed a PR upstream to include the license text. Both texts are now included:
RPM build warnings: File listed twice: /usr/share/cargo/registry/libmimalloc-sys-0.1.28/LICENSE.txt File listed twice: /usr/share/cargo/registry/libmimalloc-sys-0.1.28/c_src/mimalloc/LICENSE
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Davide Cavalca davide@cavalca.name --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
--- Comment #5 from Michel Alexandre Salim michel@michel-slm.name --- Thanks!
fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 4s ⬢ [fedora-toolbox:37] ❯ set -gx C libmimalloc-sys
fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) ⬢ [fedora-toolbox:37] ❯ set -gx B 2158276
fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) ⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B https://pagure.io/releng/fedora-scm-requests/issue/50260
fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 4s ⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9 https://pagure.io/releng/fedora-scm-requests/issue/50261
fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 6s ⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases https://pagure.io/releng/fedora-scm-requests/issue/50262 https://pagure.io/releng/fedora-scm-requests/issue/50263
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libmimalloc-sys
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-7c5c162f7e has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-4eaf0ab067 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4eaf0ab067
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-3514393fb3 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3514393fb3
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-01-08 01:20:21
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-4eaf0ab067 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-3514393fb3 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2158276
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com